Addressbook name changes

Nathan_Gray-2 2008-05-16 14:22:34 UTC #1

Ralf, last week you made a whole bunch of name changes in
addressbook. These are for an autoload?
What is the new and improved way to access the addressbook? Is
ExecMethod() still the best?

Nathan Gray
nathan at goarctic dot com

This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft® Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/

eGroupWare-developers mailing list
eGroupWare-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/egroupware-developers

Ralf_Becker_6 2008-05-16 14:46:40 UTC #2

Hi Nathan,

Nathan Gray schrieb:

Ralf, last week you made a whole bunch of name changes in
addressbook. These are for an autoload?

yep

What is the new and improved way to access the addressbook?
Is ExecMethod() still the best?

Depends what you want to archive and how the called object is coded?

Most existing eGW objects and method, are not static, therefore you have
to use ExecMethod or instanciate the object (with new if autoload is
working for that object).

If the object has static methods (I already used that for many new
classes), you can call that direct class::method($param) or you can
(since 1-2 weeks) use $method = ‘class::method’; and
ExecMethod($method,$param); or call_user_func_array($method,$param). The
last requires php5.2 and can therefore not be used in eGW1.6, as we only
require php5.1. Beside that it’s always preferable in terms of
performance to use a native php function.

Static methods also make sense, as they dont require the constructor to
run, if you dont need the information/data.

Ralf

Ralf Becker
eGroupWare Training & Support ==> http://www.egroupware-support.de
Outdoor Unlimited Training GmbH [www.outdoor-training.de]
Handelsregister HRB Kaiserslautern 3587
Geschäftsführer Birgit und Ralf Becker
Leibnizstr. 17, 67663 Kaiserslautern, Germany
Telefon +49 (0)631 31657-0

This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft® Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/

eGroupWare-developers mailing list
eGroupWare-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/egroupware-developers

Nathan_Gray-2 2008-05-16 15:00:11 UTC #3

Hi Nathan,
…
Depends what you want to archive and how the called object is coded?

Sorry, I should have been more specific the first time.
I have things like the following:
ExecMethod(‘addressbook.bocontacts.read’, $order->get_bill_to_address())
ExecMethod(‘addressbook.bocontacts.delete’, $branch[‘postal_address’]);
ExecMethod(‘addressbook.bocontacts.merge’, array($this-

get_addressbook_id(), $account_contact[‘id’]));
ExecMethod(‘addressbook.bocontacts.fileas’, $contact);
ExecMethod2(‘phpgwapi.bolink.title’, ‘addressbook’, $contact);

Which don’t work anymore.

Should they be replaced with:
addressbook_bo::read($order->get_bill_to_address());
addressbook_bo::delete($branch[‘postal_address’]);
…
egw_link::title(‘addressbook’, $contact)
?

Nathan Gray
nathan at goarctic dot com

This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft® Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/

eGroupWare-developers mailing list
eGroupWare-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/egroupware-developers

Ralf_Becker_6 2008-05-16 15:39:10 UTC #4

Hi Nathan,

Nathan Gray schrieb:

Hi Nathan,
…
Depends what you want to archive and how the called object is coded?

Sorry, I should have been more specific the first time.
I have things like the following:
ExecMethod(‘addressbook.bocontacts.read’, $order->get_bill_to_address())

ExecMethod(‘addressbook.addressbook_bo.read’, …)

$addressbook = new addressbook_bo();
$addressbook->read(…);

ExecMethod(‘addressbook.bocontacts.delete’, $branch[‘postal_address’]);
ExecMethod(‘addressbook.bocontacts.merge’, array($this-

get_addressbook_id(), $account_contact[‘id’]));
ExecMethod(‘addressbook.bocontacts.fileas’, $contact);

ExecMethod2(‘phpgwapi.bolink.title’, ‘addressbook’, $contact);

That should be still working, but it makes more sense to use the static
methods of the new egw_link class:

egw_link::title(‘addressbook’,$contact);

Which don’t work anymore.

Should they be replaced with:
addressbook_bo::read($order->get_bill_to_address());
addressbook_bo::delete($branch[‘postal_address’]);

These dont work, as addressbook_bo::read is not static method.

…
egw_link::title(‘addressbook’, $contact)

That’s ok, as egw_link::title(…) is static

Ralf

This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft® Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/

eGroupWare-developers mailing list
eGroupWare-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/egroupware-developers

Nathan_Gray-2 2008-05-16 20:25:22 UTC #5

Hi Nathan,

…
ExecMethod(‘addressbook.addressbook_bo.read’, …)

or

$addressbook = new addressbook_bo();
$addressbook->read(…);
…
egw_link::title(‘addressbook’,$contact);

Thanks, got it all sorted.

Nathan Gray
nathan at goarctic dot com

This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft® Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/

eGroupWare-developers mailing list
eGroupWare-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/egroupware-developers