If you ask me, this section is not correct after all.
It cleans out every empty (e.g.: Null, ‘’, 0) value in the config, depending
on the
empty value given. I am not sure that this is desired.
I think only the value to the config_name should be deleted.
But:
Inserting/updating first will make sure, that there is something we can
delete.
But this will produce another transaction with the database, that is
probably useless.
A problem may be, the return value the delete is giving if no row was
deleted.
Best regards
Klaus
“Nathan Gray” nathan@goarctic.com schrieb:
phpgwapi/inc/class.config.inc.php, around line 152
Config checks to see if the new value is empty, and if it is, unsets
the config variable, and deletes any configuration setting with an
empty value.
Shouldn’t it insert / update the value first, so it can be caught in
the mass delete? Or should it delete only that variable?
I can change it, I just want to understand first.
Nathan Gray
nathan at goarctic dot com
Extra punctuation??? Ug!!!
Just say no! Punctuation marks do not gain significance if you
increase their number, they make you look silly. One is sufficient.
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference
Register now and save $200. Hurry, offer ends at 11:59 p.m.,
Monday, April 7! Use priority code J8TLD2.
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone
eGroupWare-developers mailing list
eGroupWare-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/egroupware-developers
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference
Don’t miss this year’s exciting event. There’s still time to save $100.
Use priority code J8TL2D2.
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone
eGroupWare-developers mailing list
eGroupWare-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/egroupware-developers
