Hi Nathan et all,
I just reworked the interfaces, and now they are hopefully consitent.
…
Here is the UML and description:
http://www.tine20.org/wiki/index.php/Developers/Egwbase/Timemachine
Egwbase_Record_Interface->getId() returns String,
Egwbase_Timemachine_Model_ModificationLog->record_identifier is of
type int. Maybe I don’t understand how this is supposed to tie
together, or maybe you haven’t had the chance to update
Egwbase_Record_Interface to reflect your datatype changes, but it
still seems inconsistant.
For Egwbase_Timemachine_ModificationLog::getModifications(…) is
_identifier supposed to be the
Egwbase_Timemachine_Model_ModificationLog identifier or the
record_identifier? I think record_identifier would be more useful, I
can’t see the use of identifier when you have the
getModification(_identifier) call.
If there are not other ideas, i’ll start coding tomorrow.
The multipart bit I mentioned is in pERP there are quite a few
documents with headers and child records. Sales orders with sales
order lines, invoices with invoice lines, shipments with shipment
lines. Also, I have multiple document types in the same application
(different tables of course). For example, in Accounts Receivable,
there are clients, invoices, receipts, etc.
I can link these using the current link system (which is great) by
using multi-part string keys for the same application: CLIENT:23,
INVOICE:213, and INVOICE:213:4 for linking directly to a line.
I suspect I could do history by using multipart modified_attribute,
such as CLIENT:status or SHIPMENT:expected_date similar to how I do
linking, but that would complicate everything. If record_identifier
is a String to match Egwbase_Record_Interface->getId(), then I could
put a multipart key like CLIENT:23 in there.
Stuff to keep in mind, but it probably affects me more than anyone else.
I had to postpone it a bit as work on child 2.0 (http://corneliusweiss.de/?p=53
)
Congratulations. We had a laugh at the release announcement.
Nathan Gray
nathan at goarctic dot com
Extra punctuation??? Ug!!!
Just say no! Punctuation marks do not gain significance if you
increase their number, they make you look silly. One is sufficient.
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft® Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
eGroupWare-developers mailing list
eGroupWare-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/egroupware-developers