InfoLog CSV import fails silently with 1.4.002

Bugzilla_from_mark 2008-04-23 21:17:25 UTC #1

Thanks to the eGroupware developers for a useful project.

I’m currently working on setting up 1.4.002.

I’ve run into a glitch with the InfoLog CSV importer.

After selecting a file and submitting the form, the original
empty form is returned with no error message.

I expected that either the submission would succeed in some form,
or an errot would be returned. This was silent failure.

I opened up the source code and compared it to the Addressbook CSV
importer and could not see immediately that appeared wrong. (I’m a
professional programmer, but am not as strong in PHP).

Any suggestions for debugging this are welcome.

Thanks!

Mark

–
. . . . . . . . . . . . . . . . . . . . . . . . . . .
Mark Stosberg Principal Developer
mark@summersault.com Summersault, LLC
765-939-9301 ext 202 database driven websites
. . . . . http://www.summersault.com/ . . . . . . . .

This SF.net email is sponsored by the 2008 JavaOne(SM) Conference
Don’t miss this year’s exciting event. There’s still time to save $100.
Use priority code J8TL2D2.
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone

eGroupWare-developers mailing list
eGroupWare-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/egroupware-developers

pgoerzen 2008-04-24 13:05:51 UTC #2

After selecting a file and submitting the form, the original
empty form is returned with no error message.

Hi Mark,

Is there anything of interest in Apache’s error.log file?

–
Peter Goerzen
I.S. Development
Hustler Turf Equipment/Excel Industries, Inc.
(620) 327-1180

eGroupWare-developers mailing list
eGroupWare-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/egroupware-developers

Bugzilla_from_mark 2008-04-29 23:01:40 UTC #3

After selecting a file and submitting the form, the original
empty form is returned with no error message.

Hi Mark,

Is there anything of interest in Apache’s error.log file?

Peter,

That’s a good suggestion. As an experienced developer, I should have looked
there first! However, there’s absolutely no additional information there.

Unless there are further suggestions from the list, it seems the like
next step would be for me to add debugging statements into the eGroupware
code base to see where it is going off-track.

Also, I could using a very basic CSV file, to confirm that there was some
characteristic about my file which triggers the behavior. (The file
I originally triggered this with must remain confidential).

Mark

eGroupWare-developers mailing list
eGroupWare-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/egroupware-developers

Ralf_Becker_6 2008-04-30 06:07:37 UTC #4

Hi Mark,

csv import is a very basic linear script, which should be easy to debug.

If you find something, let us know here …

Ralf

Mark Stosberg schrieb:

After selecting a file and submitting the form, the original
empty form is returned with no error message.
Hi Mark,

Is there anything of interest in Apache’s error.log file?

Peter,

That’s a good suggestion. As an experienced developer, I should have looked
there first! However, there’s absolutely no additional information there.

Unless there are further suggestions from the list, it seems the like
next step would be for me to add debugging statements into the eGroupware
code base to see where it is going off-track.

Also, I could using a very basic CSV file, to confirm that there was some
characteristic about my file which triggers the behavior. (The file
I originally triggered this with must remain confidential).
Mark

–
Ralf Becker
eGroupWare Training & Support ==> http://www.egroupware-support.de
Outdoor Unlimited Training GmbH [www.outdoor-training.de]
Handelsregister HRB Kaiserslautern 3587
Geschäftsführer Birgit und Ralf Becker
Leibnizstr. 17, 67663 Kaiserslautern, Germany
Telefon +49 (0)631 31657-0

eGroupWare-developers mailing list
eGroupWare-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/egroupware-developers

Bugzilla_from_mark 2008-04-30 19:28:45 UTC #5

csv import is a very basic linear script, which should be easy to
debug.

If you find something, let us know here …

Thanks for the response, Ralf. Here’s what I found:

The import proceeds fine with with a minimal test CSV file
with two rows and three columns. My file, which is 12M and has
many rows and columns, triggers the issue.

I first suspected a max file-upload size, and up’ed both the local & global
values to 100M. (This server only does eGroupware). I used the built-in
phpinfo() script to check that the new max upload sizes were in effect and
tried again. Same result.

I traced the failure point to this line in infolog/csv_import.php:

if (isset($_FILES[‘csvfile’][‘tmp_name’]))

This is not getting set when it should be. I tried checking the error code after
this line, but it was not set:

debugging added

error_log("got? ".$_FILES[‘csvfile’][‘error’]);

My PHP could be stronger, but it appears there is some fundamental issue before
things even really get started, and some additional error checking is needed.
I thought checking for the “error” code above would be the thing to add, but
apparently something else is needed.

Further ideas?

I appreciate your help.

Mark

eGroupWare-developers mailing list
eGroupWare-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/egroupware-developers

Ralf_Becker_6 2008-04-30 20:21:24 UTC #6

Hi Mark,

beside upload_max_filesize you also have to set post_max_size, otherwise
apache stops the upload and the array is not set - causing the isset()
to return false.

With big files you also might have to consider the memory_limit.

All this problems should cause an entry in apache’s error_log.

Ralf

Mark Stosberg schrieb:

csv import is a very basic linear script, which should be easy to
debug.

If you find something, let us know here …

Thanks for the response, Ralf. Here’s what I found:

The import proceeds fine with with a minimal test CSV file
with two rows and three columns. My file, which is 12M and has
many rows and columns, triggers the issue.

I first suspected a max file-upload size, and up’ed both the local & global
values to 100M. (This server only does eGroupware). I used the built-in
phpinfo() script to check that the new max upload sizes were in effect and
tried again. Same result.

I traced the failure point to this line in infolog/csv_import.php:

if (isset($_FILES[‘csvfile’][‘tmp_name’]))

This is not getting set when it should be. I tried checking the error code after
this line, but it was not set:

debugging added

error_log("got? ".$_FILES[‘csvfile’][‘error’]);

My PHP could be stronger, but it appears there is some fundamental issue before
things even really get started, and some additional error checking is needed.
I thought checking for the “error” code above would be the thing to add, but
apparently something else is needed.

Further ideas?

I appreciate your help.
Mark

eGroupWare-developers mailing list
eGroupWare-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/egroupware-developers

Bugzilla_from_mark 2008-05-05 20:35:36 UTC #7

Hi Mark,

beside upload_max_filesize you also have to set post_max_size, otherwise
apache stops the upload and the array is not set - causing the isset()
to return false.

That created a breakthrough. Thanks, Ralf!

It would still be nice if the application could respond to this more gracefully
than the silent failure that’s presented to the user now.

Mark

eGroupWare-developers mailing list
eGroupWare-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/egroupware-developers