Patch - "More News" not visible in sitemgr when limit is 1

[Hans-Jurgen_Tappe]

Hi!

There is a problem (at least in the sitemgr) when a news_admin module
is configured to show a single news item (like the complete, newest)
plus the “more news Link”.
The “More News” Link is not shown because the so_sql classes search function
does not return the total number.

I assume this is a performance optimization (while at least with mysql it does
not seem to save a lot of resources). Is there anything why the patch below
should not be applied? The patch re-adds the total row count in case the limit
is 1. This would be a great help.

Thanks and best regards,
Hans-Jürgen

Index: quilt/egroupware/etemplate/inc/class.so_sql.inc.php

— quilt.orig/egroupware/etemplate/inc/class.so_sql.inc.php 2008-06-28 16:08:46.000000000 +0200
+++ quilt/egroupware/etemplate/inc/class.so_sql.inc.php 2008-06-28 17:59:42.000000000 +0200
@@ -815,7 +815,7 @@
}
else // no UNION
{

•                   if ($start !== false && $num_rows != 1) // need to get the total too, saved in $this->total
  

•                   if ($start !== false)   // need to get the total too, saved in $this->total
                    {
                            if ($this->db->Type == 'mysql' && $this->db->ServerInfo['version'] >= 4.0)
                            {
  

---

Check out the new SourceForge.net Marketplace.
It’s the best place to buy or sell services for
just about anything Open Source.
http://sourceforge.net/services/buy/index.php

---

eGroupWare-developers mailing list
eGroupWare-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/egroupware-developers

[Randy_J_Houlahan_B.S]

Thanks! I have been meaning to tackle that one.
Looks good. I hope it gets committed.

Hi!

There is a problem (at least in the sitemgr) when a news_admin module
is configured to show a single news item (like the complete, newest)
plus the “more news Link”.
The “More News” Link is not shown because the so_sql classes search function
does not return the total number.

I assume this is a performance optimization (while at least with mysql it does
not seem to save a lot of resources). Is there anything why the patch below
should not be applied? The patch re-adds the total row count in case the limit
is 1. This would be a great help.

Thanks and best regards,
Hans-Jürgen

Index: quilt/egroupware/etemplate/inc/class.so_sql.inc.php

— quilt.orig/egroupware/etemplate/inc/class.so_sql.inc.php 2008-06-28 16:08:46.000000000 +0200
+++ quilt/egroupware/etemplate/inc/class.so_sql.inc.php 2008-06-28 17:59:42.000000000 +0200
@@ -815,7 +815,7 @@
}
else // no UNION
{

•                   if ($start !== false && $num_rows != 1) // need to get the total too, saved in $this->total
  

•                   if ($start !== false)   // need to get the total too, saved in $this->total
                    {
                            if ($this->db->Type == 'mysql' && $this->db->ServerInfo['version'] >= 4.0)
                            {
  

---

Check out the new SourceForge.net Marketplace.
It’s the best place to buy or sell services for
just about anything Open Source.
http://sourceforge.net/services/buy/index.php

---

eGroupWare-developers mailing list
eGroupWare-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/egroupware-developers