Small re-design of notifications

jaytraxx 2007-12-18 16:36:05 UTC #1

Hi all,

just committed a small re-design of notifications. The reason is that I noticed some awkward constellations in the code that could made further extendig a bit tricky.

So, here it is. I hope there aren’t any bugs, but I really tested it one hour non-stop … If you encounter AJAX-Errors, please purge your clients cache.

Design note:

The main class is responsible for routing the notification to all the recipients in respect to their prefs and having fallbacks.
Each backend is responsible for sending ONE message to ONE user. The backends render additional infos from given attribs like $sender, $subject, $links … themselves now. This is more flexible.
AJAX for egwpopup is now put into a separate file, so future AJAX things like notifying about new mails will be easier to implement. Furthermore it was helpful to strengthen the constructor’s signature of the backends a bit.

To everyone who already made another backend. Sorry, you have to adapt your backend a bit. It’s not so much … Have a look at the changelog from one of the standard backends. This will give you the best information about the changes. If you encounter problems, you could also send the backend to me.

Have fun!
Bye
Christian

Aleksander_Adamowsk2 2007-12-19 17:23:29 UTC #2

To everyone who already made another backend. Sorry, you have to adapt your
backend a bit. It’s not so much … Have a look at the changelog from one of
the standard backends. This will give you the best information about the
changes. If you encounter problems, you could also send the backend to me.

Have fun!
Bye
Christian

Hi Christian!

Thanks for notifying us.

Here’s an updated version of the SMS backend. Please have a look at
the code and do any corrections you find necessary.

It has already been tested WRT sending SMS through a modem.

I’ve done a couple of cosmetic fixes too:

The SMS backend no longer removes the first rows of a notification
since 3G phones are able to accept longer SMS messages in several
160-character parts and we don’t have to reduce the message’s length
so much.
The SMS is shortened to a maximum length of 3*160 characters, not
159 as before, for the same reason as above.

–
Best Regards,
Aleksander Adamowski
http://olo.org.pl

jaytraxx 2007-12-19 18:04:52 UTC #3

Hi Aleksander,

thanx a lot. If I add SMS to /trunk I will recall you for your "newest"
version of the backend, ok? That could really take a while, cause there
are a handful other plans to do before, but it well be done, ok?

Bye
Christian

Aleksander Adamowski schrieb:

To everyone who already made another backend. Sorry, you have to adapt your
backend a bit. It’s not so much … Have a look at the changelog from one of
the standard backends. This will give you the best information about the
changes. If you encounter problems, you could also send the backend to me.

Have fun!
Bye
Christian

Hi Christian!

Thanks for notifying us.

Here’s an updated version of the SMS backend. Please have a look at
the code and do any corrections you find necessary.

It has already been tested WRT sending SMS through a modem.

I’ve done a couple of cosmetic fixes too:

The SMS backend no longer removes the first rows of a notification
since 3G phones are able to accept longer SMS messages in several
160-character parts and we don’t have to reduce the message’s length
so much.

The SMS is shortened to a maximum length of 3*160 characters, not
159 as before, for the same reason as above.

SF.Net email is sponsored by:
Check out the new SourceForge.net Marketplace.
It’s the best place to buy or sell services
for just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace

eGroupWare-developers mailing list
eGroupWare-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/egroupware-developers

SF.Net email is sponsored by:
Check out the new SourceForge.net Marketplace.
It’s the best place to buy or sell services
for just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace

eGroupWare-developers mailing list
eGroupWare-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/egroupware-developers

Aleksander_Adamowsk2 2007-12-20 10:16:20 UTC #4

Hi Aleksander,

thanx a lot. If I add SMS to /trunk I will recall you for your "newest"
version of the backend, ok? That could really take a while, cause there
are a handful other plans to do before, but it well be done, ok?

OK, BTW, did you notice a PHP warning your class causes in the logs?

Here it is:
PHP Warning: Call-time pass-by-reference has been deprecated -
argument passed by value; If you would like to pass it by reference,
modify the declaration of mb_ereg(). If you would
like to enable call-time pass-by-reference, you can set
allow_call_time_pass_reference to true in your INI file. However,
future versions may not support this any longer. in
EGROUPWARE_PATH/notifications/inc/
class.notification.inc.php on line 419

–
Best Regards,
Aleksander Adamowski
http://olo.org.pl

eGroupWare-developers mailing list
eGroupWare-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/egroupware-developers

jaytraxx 2007-12-20 12:28:33 UTC #5

Hi Aleksander,

No, I didn’t cause my php is probably in allow_call_time_pass_reference-mode
I took ereg() from the official php docs, and they do it still that way in the syntax description. But it should be possible to not pass it by reference. I will keep it in mind and fix it the next time.
Thx again…

Bye
Christain

Aleksander Adamowski-3:

Here it is:
PHP Warning: Call-time pass-by-reference has been deprecated -
argument passed by value; If you would like to pass it by reference,
modify the declaration of mb_ereg(). If you would
like to enable call-time pass-by-reference, you can set
allow_call_time_pass_reference to true in your INI file. However,
future versions may not support this any longer. in
EGROUPWARE_PATH/notifications/inc/
class.notification.inc.php on line 419

–
Best Regards,
Aleksander Adamowski
http://olo.org.pl

SF.Net email is sponsored by:
Check out the new SourceForge.net Marketplace.
It’s the best place to buy or sell services
for just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace

eGroupWare-developers mailing list
eGroupWare-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/egroupware-developers

Ralf_Becker_6 2007-12-20 17:30:38 UTC #6

Hi Christian,

allow_call_time_pass_reference is by default off in php5, so we should
not rely on it.

If a function has referencial parameters in it’s declaration, that’s
fine, you should not doublicate it in the call.

If that (depricated) feature is switched on, you can call a function not
declaring a parameter to be referencial, as referencial parameter while
calling it. That’s what’s depricated.

Ralf

jaytraxx schrieb:

Hi Aleksander,

Aleksander Adamowski-3 wrote:

Hi Aleksander,

thanx a lot. If I add SMS to /trunk I will recall you for your "newest"
version of the backend, ok? That could really take a while, cause there
are a handful other plans to do before, but it well be done, ok?
OK, BTW, did you notice a PHP warning your class causes in the logs?

No, I didn’t cause my php is probably in allow_call_time_pass_reference-mode

I took ereg() from the official php docs, and they do it still that way in
the syntax description. But it should be possible to not pass it by
reference. I will keep it in mind and fix it the next time.
Thx again…

Bye
Christain

Aleksander Adamowski-3 wrote:

Here it is:
PHP Warning: Call-time pass-by-reference has been deprecated -
argument passed by value; If you would like to pass it by reference,
modify the declaration of mb_ereg(). If you would
like to enable call-time pass-by-reference, you can set
allow_call_time_pass_reference to true in your INI file. However,
future versions may not support this any longer. in
EGROUPWARE_PATH/notifications/inc/
class.notification.inc.php on line 419

–
Best Regards,
Aleksander Adamowski
http://olo.org.pl

SF.Net email is sponsored by:
Check out the new SourceForge.net Marketplace.
It’s the best place to buy or sell services
for just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace

eGroupWare-developers mailing list
eGroupWare-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/egroupware-developers

–
Ralf Becker
eGroupWare Training & Support ==> http://www.egroupware-support.de
Outdoor Unlimited Training GmbH [www.outdoor-training.de]
Handelsregister HRB Kaiserslautern 3587
Geschäftsführer Birgit und Ralf Becker
Leibnizstr. 17, 67663 Kaiserslautern, Germany
Telefon +49 (0)631 31657-0

This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft® Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/

eGroupWare-developers mailing list
eGroupWare-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/egroupware-developers

Nathan_Gray-2 2007-12-20 19:14:03 UTC #7

Hi all,

just committed a small re-design of notifications. The reason is
that I
noticed some awkward constellations in the code that could made
further
extendig a bit tricky.

So, here it is. I hope there aren’t any bugs, but I really tested it
one
hour non-stop … If you encounter AJAX-Errors, please purge your
clients
cache.

Any idea what the default expiry is, or how to force it?
I can’t give instructions in advance, because nobody will listen, and
I can’t have everyone calling me.
However Christmas is coming, and if the expiry time is right, maybe I
can update tomorrow and have everything just work…

Nathan Gray
nathan at goarctic dot com

Extra punctuation??? Ug!!!
Just say no! Punctuation marks do not gain significance if you
increase their number, they make you look silly. One is sufficient.

This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft® Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/

eGroupWare-developers mailing list
eGroupWare-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/egroupware-developers

jaytraxx 2007-12-20 19:56:23 UTC #8

Hi Ralf,

Ralf Becker schrieb:

Hi Christian,

allow_call_time_pass_reference is by default off in php5, so we should
not rely on it.

If a function has referencial parameters in it’s declaration, that’s
fine, you should not doublicate it in the call.

If that (depricated) feature is switched on, you can call a function not
declaring a parameter to be referencial, as referencial parameter while
calling it. That’s what’s depricated.

thx, the PHP world get’s clearer everyday …

Bye
Christian

Ralf

jaytraxx schrieb:

Hi Aleksander,

Aleksander Adamowski-3 wrote:

Hi Aleksander,

thanx a lot. If I add SMS to /trunk I will recall you for your "newest"
version of the backend, ok? That could really take a while, cause there
are a handful other plans to do before, but it well be done, ok?
OK, BTW, did you notice a PHP warning your class causes in the logs?

No, I didn’t cause my php is probably in allow_call_time_pass_reference-mode

I took ereg() from the official php docs, and they do it still that way in
the syntax description. But it should be possible to not pass it by
reference. I will keep it in mind and fix it the next time.
Thx again…

Bye
Christain

Aleksander Adamowski-3 wrote:

Here it is:
PHP Warning: Call-time pass-by-reference has been deprecated -
argument passed by value; If you would like to pass it by reference,
modify the declaration of mb_ereg(). If you would
like to enable call-time pass-by-reference, you can set
allow_call_time_pass_reference to true in your INI file. However,
future versions may not support this any longer. in
EGROUPWARE_PATH/notifications/inc/
class.notification.inc.php on line 419

–
Best Regards,
Aleksander Adamowski
http://olo.org.pl

SF.Net email is sponsored by:
Check out the new SourceForge.net Marketplace.
It’s the best place to buy or sell services
for just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace

eGroupWare-developers mailing list
eGroupWare-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/egroupware-developers

This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft® Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/

eGroupWare-developers mailing list
eGroupWare-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/egroupware-developers

jaytraxx 2007-12-20 20:20:21 UTC #9

Hi again Aleksander,

Aleksander Adamowski schrieb:

Hi Aleksander,

thanx a lot. If I add SMS to /trunk I will recall you for your "newest"
version of the backend, ok? That could really take a while, cause there
are a handful other plans to do before, but it well be done, ok?

OK, BTW, did you notice a PHP warning your class causes in the logs?

Here it is:
PHP Warning: Call-time pass-by-reference has been deprecated -
argument passed by value; If you would like to pass it by reference,
modify the declaration of mb_ereg(). If you would
like to enable call-time pass-by-reference, you can set
allow_call_time_pass_reference to true in your INI file. However,
future versions may not support this any longer. in
EGROUPWARE_PATH/notifications/inc/
class.notification.inc.php on line 419

just committed a really short fix for that (removed the ‘&’).

bye
Christian

This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft® Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/

eGroupWare-developers mailing list
eGroupWare-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/egroupware-developers