Syntax error in r24836/r24837

pgoerzen 2007-12-20 21:13:41 UTC #1

Greetings,

In 1.4 snapshot from today (20071220), SyncML generates an error:

PHP Parse error: syntax error, unexpected T_DEFAULT in /usr/share/egroupware/phpgwapi/inc/horde/Horde/SyncML/Command/Put.php on line 216

The following patch corrected the issue for me. I believe it preserves the intended semantics.

Thanks,
Peter

— /usr/share/egroupware/phpgwapi/inc/horde/Horde/SyncML/Command/Results.php.dist 2007-12-20 14:22:35.934096297 -0600
+++ /usr/share/egroupware/phpgwapi/inc/horde/Horde/SyncML/Command/Results.php 2007-12-20 14:48:14.558254297 -0600
@@ -154,13 +154,14 @@
{
switch (strtolower(trim($matches[1])))
{

                                  case 'outlook plug-in'

                                  default:

                                          $this->_deviceInfo['deviceType'] = 'workstation';

                                          break;

                                  case 'pocket pc plug-in'

                                          $this->_deviceInfo['deviceType'] = 'windowsmobile';

                                          break;

                          case 'pocket pc plug-in':

                                  $this->_deviceInfo['deviceType'] = 'windowsmobile';

                                  break;

                          case 'outlook plug-in':

```
                          default:
```

                                  $this->_deviceInfo['deviceType'] = 'workstation';

                                  break;

                          }
                  }
          }

— /usr/share/egroupware/phpgwapi/inc/horde/Horde/SyncML/Command/Put.php.dist 2007-12-20 14:22:24.037352797 -0600
+++ /usr/share/egroupware/phpgwapi/inc/horde/Horde/SyncML/Command/Put.php 2007-12-20 14:46:54.921277297 -0600
@@ -212,13 +212,13 @@
{
switch (strtolower(trim($matches[1])))
{

                                  case 'outlook plug-in'

                                  default:

                                          $this->_deviceInfo['deviceType'] = 'workstation';

                                          break;

                                  case 'pocket pc plug-in'

                                          $this->_deviceInfo['deviceType'] = 'windowsmobile';

                                          break;

                          case 'pocket pc plug-in':

                                  $this->_deviceInfo['deviceType'] = 'windowsmobile';

                                  break;

                          case 'outlook plug-in':

```
                          default:
```

                                  $this->_deviceInfo['deviceType'] = 'workstation';

Ralf_Becker_6 2007-12-20 21:21:31 UTC #2

Thanks Peter,

committed your fix to trunk.

Ralf

pgoerzen schrieb:

Greetings,

In 1.4 snapshot from today (20071220), SyncML generates an error:

PHP Parse error: syntax error, unexpected T_DEFAULT in
/usr/share/egroupware/phpgwapi/inc/horde/Horde/SyncML/Command/Put.php on
line 216

The following patch corrected the issue for me. I believe it preserves the
intended semantics.

Thanks,
Peter

/usr/share/egroupware/phpgwapi/inc/horde/Horde/SyncML/Command/Results.php.dist
2007-12-20 14:22:35.934096297 -0600
+++
/usr/share/egroupware/phpgwapi/inc/horde/Horde/SyncML/Command/Results.php
2007-12-20 14:48:14.558254297 -0600
@@ -154,13 +154,14 @@
{
switch (strtolower(trim($matches[1])))
{

                                  case 'outlook plug-in'

                                  default:

$this->_deviceInfo[‘deviceType’] = ‘workstation’;

                                          break;

                                  case 'pocket pc plug-in'

$this->_deviceInfo[‘deviceType’] = ‘windowsmobile’;

                                          break;

                          case 'pocket pc plug-in':

                                  $this->_deviceInfo['deviceType'] =

‘windowsmobile’;

                                  break;

                          case 'outlook plug-in':

```
                          default:
```

                                  $this->_deviceInfo['deviceType'] =

‘workstation’;

                                  break;

                          }
                  }
          }

/usr/share/egroupware/phpgwapi/inc/horde/Horde/SyncML/Command/Put.php.dist
2007-12-20 14:22:24.037352797 -0600
+++ /usr/share/egroupware/phpgwapi/inc/horde/Horde/SyncML/Command/Put.php
2007-12-20 14:46:54.921277297 -0600
@@ -212,13 +212,13 @@
{
switch (strtolower(trim($matches[1])))
{

                                  case 'outlook plug-in'

                                  default:

$this->_deviceInfo[‘deviceType’] = ‘workstation’;

                                          break;

                                  case 'pocket pc plug-in'

$this->_deviceInfo[‘deviceType’] = ‘windowsmobile’;

                                          break;

                          case 'pocket pc plug-in':

                                  $this->_deviceInfo['deviceType'] =

‘windowsmobile’;

                                  break;

                          case 'outlook plug-in':

```
                          default:
```

                                  $this->_deviceInfo['deviceType'] =

‘workstation’;

Peter Goerzen
I.S. Development
Hustler Turf Equipment, Inc.

–
Ralf Becker
eGroupWare Training & Support ==> http://www.egroupware-support.de
Outdoor Unlimited Training GmbH [www.outdoor-training.de]
Handelsregister HRB Kaiserslautern 3587
Geschäftsführer Birgit und Ralf Becker
Leibnizstr. 17, 67663 Kaiserslautern, Germany
Telefon +49 (0)631 31657-0

This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft® Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/

eGroupWare-developers mailing list
eGroupWare-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/egroupware-developers

Patrick_Bihan-Faou-5 2007-12-22 02:58:52 UTC #3

Hi,

Sorry for the typos. Thanks to Peter to finding this quickly and thanks to
Ralf
for commiting the fix.

Again sorry!

Merry Xmass!

Patrick.

Thanks Peter,

committed your fix to trunk.

Ralf

pgoerzen schrieb:

Greetings,

In 1.4 snapshot from today (20071220), SyncML generates an error:

PHP Parse error: syntax error, unexpected T_DEFAULT in
/usr/share/egroupware/phpgwapi/inc/horde/Horde/SyncML/Command/Put.php on
line 216

The following patch corrected the issue for me. I believe it preserves
the

intended semantics.

Thanks,
Peter

/usr/share/egroupware/phpgwapi/inc/horde/Horde/SyncML/Command/Results.php.dist

2007-12-20 14:22:35.934096297 -0600
+++
/usr/share/egroupware/phpgwapi/inc/horde/Horde/SyncML/Command/Results.php

2007-12-20 14:48:14.558254297 -0600
@@ -154,13 +154,14 @@
{
switch (strtolower(trim($matches[1])))
{

                                  case 'outlook plug-in'

                                  default:

$this->_deviceInfo[‘deviceType’] = ‘workstation’;

                                          break;

                                  case 'pocket pc plug-in'

$this->_deviceInfo[‘deviceType’] = ‘windowsmobile’;

                                          break;

                          case 'pocket pc plug-in':

                                  $this->_deviceInfo['deviceType']

‘windowsmobile’;

                                  break;

                          case 'outlook plug-in':

```
                          default:
```

                                  $this->_deviceInfo['deviceType']

‘workstation’;

                                  break;

                          }
                  }
          }

/usr/share/egroupware/phpgwapi/inc/horde/Horde/SyncML/Command/Put.php.dist

2007-12-20 14:22:24.037352797 -0600
+++ /usr/share/egroupware/phpgwapi/inc/horde/Horde/SyncML/Command/Put.php

2007-12-20 14:46:54.921277297 -0600
@@ -212,13 +212,13 @@
{
switch (strtolower(trim($matches[1])))
{

                                  case 'outlook plug-in'

                                  default:

$this->_deviceInfo[‘deviceType’] = ‘workstation’;

                                          break;

                                  case 'pocket pc plug-in'

$this->_deviceInfo[‘deviceType’] = ‘windowsmobile’;

                                          break;

                          case 'pocket pc plug-in':

                                  $this->_deviceInfo['deviceType']

‘windowsmobile’;

                                  break;

                          case 'outlook plug-in':

```
                          default:
```

                                  $this->_deviceInfo['deviceType']

‘workstation’;
                                  break;
                          }
                  }
          }
Peter Goerzen
I.S. Development
Hustler Turf Equipment, Inc.
–
Ralf Becker
eGroupWare Training & Support ==> http://www.egroupware-support.de
Outdoor Unlimited Training GmbH [www.outdoor-training.de]
Handelsregister HRB Kaiserslautern 3587
Geschäftsführer Birgit und Ralf Becker
Leibnizstr. 17, 67663 Kaiserslautern, Germany
Telefon +49 (0)631 31657-0

This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft® Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/

eGroupWare-developers mailing list
eGroupWare-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/egroupware-developers

This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft® Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/

eGroupWare-developers mailing list
eGroupWare-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/egroupware-developers

Henk_van_Lingen-2 2007-12-29 16:52:41 UTC #4

Hi,

Sorry for the typos. Thanks to Peter to finding this quickly and thanks to
Ralf
for commiting the fix.

Please also commit the fix to the 1.4 tree, which still has this problem.

Regards,

–
Henk van Lingen, Systems Administrator & DBA (o- -+
Dept. of Computer Science, Utrecht University. /\ |
phone: +31-30-2534107 v_/_
http://henk.vanlingen.net/ http://www.tuxtown.net/netiquette/

This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft® Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/

eGroupWare-developers mailing list
eGroupWare-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/egroupware-developers