Workflow, egw_db & ADOdb functions

Nathan_Gray-2 2008-03-25 15:45:26 UTC #1

The workflow uses $GLOBALS[‘egw’]->ADOdb for its database access, and
one of the first things it does with MySQL is disconnect and reconnect
$GLOBALS[‘egw’]->db as mysqlt. Why $GLOBALS[‘egw’]->db instead of
the provided $db?
It also calls ADOdb functions, such as SelectLimit().

In trunk, trying to load an Instance gives:
Invalid db object passed to BaseManager constructor

I switched class.workflow_instancemanager.inc.php Line 11 from:
parent::InstanceManager($GLOBALS[‘egw’]->ADOdb);
to:
parent::InstanceManager($GLOBALS[‘egw’]->db);
which avoids that error. I now get :
Fatal error: Call to undefined method egw_db::SelectLimit() in /var/
www/perpdevel/workflow/inc/engine/src/common/Base.php on line 158
however I can’t figure out why that function doesn’t exist, because
egw_db includes adodb/adodb.inc.php, which defines the function on
line 1097.

Nathan Gray
nathan at goarctic dot com

This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft® Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/

eGroupWare-developers mailing list
eGroupWare-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/egroupware-developers

Ralf_Becker_6 2008-03-25 18:39:59 UTC #2

Hi Nathan,

afaik workflow uses ADOdb direct, so you cant give it an egw_db object.

Maybe you can pass it a clone of $GLOBALS[‘egw’]->ADOdb

Ralf

Nathan Gray schrieb:

The workflow uses $GLOBALS[‘egw’]->ADOdb for its database access, and
one of the first things it does with MySQL is disconnect and reconnect
$GLOBALS[‘egw’]->db as mysqlt. Why $GLOBALS[‘egw’]->db instead of
the provided $db?
It also calls ADOdb functions, such as SelectLimit().

In trunk, trying to load an Instance gives:
Invalid db object passed to BaseManager constructor

I switched class.workflow_instancemanager.inc.php Line 11 from:
parent::InstanceManager($GLOBALS[‘egw’]->ADOdb);
to:
parent::InstanceManager($GLOBALS[‘egw’]->db);
which avoids that error. I now get :
Fatal error: Call to undefined method egw_db::SelectLimit() in /var/
www/perpdevel/workflow/inc/engine/src/common/Base.php on line 158
however I can’t figure out why that function doesn’t exist, because
egw_db includes adodb/adodb.inc.php, which defines the function on
line 1097.

Nathan Gray
nathan at goarctic dot com

This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft® Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/

eGroupWare-developers mailing list
eGroupWare-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/egroupware-developers

–
Ralf Becker
eGroupWare Training & Support ==> http://www.egroupware-support.de
Outdoor Unlimited Training GmbH [www.outdoor-training.de]
Handelsregister HRB Kaiserslautern 3587
Geschäftsführer Birgit und Ralf Becker
Leibnizstr. 17, 67663 Kaiserslautern, Germany
Telefon +49 (0)631 31657-0

This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft® Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/

eGroupWare-developers mailing list
eGroupWare-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/egroupware-developers

Nathan_Gray-2 2008-03-25 19:02:50 UTC #3

Hi Nathan,

afaik workflow uses ADOdb direct, so you cant give it an egw_db
object.

Maybe you can pass it a clone of $GLOBALS[‘egw’]->ADOdb

I tried that, but it doesn’t seem to exist. Where is it created?

Nathan Gray
nathan at goarctic dot com

This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft® Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/

eGroupWare-developers mailing list
eGroupWare-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/egroupware-developers

Ralf_Becker_6 2008-03-25 19:37:22 UTC #4

$GLOBALS[‘egw’]->ADOdb is created in egw_db::connect()

Ralf

Nathan Gray schrieb:

Hi Nathan,

afaik workflow uses ADOdb direct, so you cant give it an egw_db
object.

Maybe you can pass it a clone of $GLOBALS[‘egw’]->ADOdb

I tried that, but it doesn’t seem to exist. Where is it created?

Nathan Gray
nathan at goarctic dot com

This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft® Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/

eGroupWare-developers mailing list
eGroupWare-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/egroupware-developers

This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft® Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/

eGroupWare-developers mailing list
eGroupWare-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/egroupware-developers

Nathan_Gray-2 2008-03-25 20:24:26 UTC #5

$GLOBALS[‘egw’]->ADOdb is created in egw_db::connect()

Found it, thanks. Any objections to committing the following back to
trunk?

Index: class.workflow_instance.inc.php

— class.workflow_instance.inc.php (revision 25155)
+++ class.workflow_instance.inc.php (working copy)
@@ -10,7 +10,7 @@
{
function workflow_Instance()
{

  	parent::Instance($GLOBALS['egw']->ADOdb);

```
  	parent::Instance($GLOBALS['egw']->db->link_id());
  }
```
}
?>
Index: class.workflow_instancemanager.inc.php
===================================================================
— class.workflow_instancemanager.inc.php (revision 25155)
+++ class.workflow_instancemanager.inc.php (working copy)
@@ -8,7 +8,7 @@
{
function workflow_instancemanager()
{

  	parent::InstanceManager($GLOBALS['egw']->ADOdb);

```
  	parent::InstanceManager($GLOBALS['egw']->db->link_id());
  }
```
}
?>
Index: engine/src/common/Base.php
===================================================================
— engine/src/common/Base.php (revision 25155)
+++ engine/src/common/Base.php (working copy)
@@ -23,7 +23,7 @@
//Force transactionnal mysql (Innodb) -> mysqlt
if ($db->databaseType==‘mysql’)
{

```
  $GLOBALS['egw']->db->disconnect();
```

  $db->disconnect();
	$db = $GLOBALS['egw']->db->connect(
  	$GLOBALS['egw_info']['server']['db_name'],

Nathan Gray
nathan at goarctic dot com

This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft® Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/

eGroupWare-developers mailing list
eGroupWare-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/egroupware-developers

Ralf_Becker_6 2008-03-26 07:12:23 UTC #6

Hi Nathan,

I have nothing to object, but also no idea about the workflow app

Regis Leroy is the maintainer, thought I cant think he’ll object if you
get the code working again …

Ralf

Nathan Gray schrieb:

$GLOBALS[‘egw’]->ADOdb is created in egw_db::connect()

Found it, thanks. Any objections to committing the following back to
trunk?

Index: class.workflow_instance.inc.php

— class.workflow_instance.inc.php (revision 25155)
+++ class.workflow_instance.inc.php (working copy)
@@ -10,7 +10,7 @@
{
function workflow_Instance()
{
	parent::Instance($GLOBALS['egw']->ADOdb);
	parent::Instance($GLOBALS['egw']->db->link_id());
	}
}
?>
Index: class.workflow_instancemanager.inc.php
===================================================================
— class.workflow_instancemanager.inc.php (revision 25155)
+++ class.workflow_instancemanager.inc.php (working copy)
@@ -8,7 +8,7 @@
{
function workflow_instancemanager()
{
	parent::InstanceManager($GLOBALS['egw']->ADOdb);
	parent::InstanceManager($GLOBALS['egw']->db->link_id());
	}
}
?>
Index: engine/src/common/Base.php
===================================================================
— engine/src/common/Base.php (revision 25155)
+++ engine/src/common/Base.php (working copy)
@@ -23,7 +23,7 @@
//Force transactionnal mysql (Innodb) -> mysqlt
if ($db->databaseType==‘mysql’)
{
$GLOBALS['egw']->db->disconnect();
$db->disconnect();
	$db = $GLOBALS['egw']->db->connect(
		$GLOBALS['egw_info']['server']['db_name'],
Nathan Gray
nathan at goarctic dot com

This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft® Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/

eGroupWare-developers mailing list
eGroupWare-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/egroupware-developers

Check out the new SourceForge.net Marketplace.
It’s the best place to buy or sell services for
just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace

eGroupWare-developers mailing list
eGroupWare-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/egroupware-developers

Regis_Leroy 2008-03-26 18:41:59 UTC #7

no objection

Nathan_Gray-2 2008-03-26 19:02:00 UTC #8

no objection

Ok, thanks. If you notice anything horrible, please feel free to
correct it.
There were a few more than those 3, but I’m pretty sure I got them all.

Nathan Gray
nathan at goarctic dot com

eGroupWare-developers mailing list
eGroupWare-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/egroupware-developers