Workflow non-interactive start

Nathan_Gray-2 2008-01-10 23:32:22 UTC #1

@regis

About a year ago you said:

your start activity should be non-interactive (if the engine says
you cannot we’ll change that).
(http://www.nabble.com/sending-instances-through-activities-td9739919s3741.html#a10150802
)

Currently (trunk), the engine still requires an interactive start. Ok
if I patch as follows? Seems to be working OK.

Index: engine/src/ProcessManager/ActivityManager.php

— engine/src/ProcessManager/ActivityManager.php (revision 24871)
+++ engine/src/ProcessManager/ActivityManager.php (working copy)
@@ -401,7 +401,6 @@
5) Standalone and view activities cannot have transitions
6) Non intractive activities non-auto routed must have some role
so the user can “send” the activity

1. start activities must be autorouted and interactive
  */
  function validate_process_activities($pId)
  {
  @@ -426,7 +425,7 @@
  }
// Rule 2 end must be reachable from start
// and Rule 7 start activities must be autorouted and interactive

// and Rule 7 start activities must be autorouted
$nodes = Array();
$endId = $this->getOne('select wf_activity_id from '
.GALAXIA_TABLE_PREFIX.‘activities where wf_p_id=? and
wf_type=?’, array($pId,‘end’));
@@ -446,9 +445,6 @@
$result = $this->query($query, array($pId,‘start’));
while($res = $result->fetchRow()) {
$start_node[‘id’] = $res[‘wf_activity_id’];

 if(!($res['wf_is_interactive'] == 'y')) {

       $errors[] = tra('start activities must be interactive');

 }
  if(!($res['wf_is_autorouted'] == 'y')) {
        $errors[] = tra('start activities must be autorouted');
  }

I’d also like to add egroupware hook support for agents, if that’s OK.

Nathan Gray
nathan at goarctic dot com

Extra punctuation??? Ug!!!
Just say no! Punctuation marks do not gain significance if you
increase their number, they make you look silly. One is sufficient.

Check out the new SourceForge.net Marketplace.
It’s the best place to buy or sell services for
just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace

eGroupWare-developers mailing list
eGroupWare-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/egroupware-developers

Regis_Leroy 2008-01-11 08:30:19 UTC #2

Well at least this remove the tests from the engine.
So egegctively engine won’t prevent you about that fact.
Then you should test everything is really working.
If you have no big problems I’ll commit this in the trunk.

About hook support for agents you could try it effectively.
Agents needs to be derived from the agents bases classes, in that sense
they’re already hooks of the activities.

Régis,

Nathan_Gray-2 2008-01-11 16:22:09 UTC #3

Well at least this remove the tests from the engine.
So egegctively engine won’t prevent you about that fact.
Then you should test everything is really working.
If you have no big problems I’ll commit this in the trunk.

I tried those changes April last year, haven’t noticed anything bad,
but I don’t know what to look for. Seems to work, but obviously you
know your code better than I.

About hook support for agents you could try it effectively.
Agents needs to be derived from the agents bases classes, in that
sense they’re already hooks of the activities.

I was thinking about changing engine/compiler/agents_pre.php and
engine/config.egw.inc.php->galaxia_get_agents_list() to also check an
egroupware hook ‘workflow_agent’, so other applications can provide
their own agents without copying in the files and editing the list in
config.egw.inc.php similar to how the link system works.

It seems that only ui_agent* is called directly from the engine in
agents_pre.php, and that bo_agent* can reside wherever.
I’m a little confused as to how the AdminActivityOptions works though,
as it references an undeclared variable $this->t.

Does that sound ok? Good idea? Any files I missed?

Nathan Gray
nathan at goarctic dot com

Extra punctuation??? Ug!!!
Just say no! Punctuation marks do not gain significance if you
increase their number, they make you look silly. One is sufficient.

eGroupWare-developers mailing list
eGroupWare-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/egroupware-developers

Nathan_Gray-2 2008-01-11 16:54:15 UTC #4

I’m a little confused as to how the AdminActivityOptions works though,
as it references an undeclared variable $this->t.

Sorry, I tracked this down. It’s not undeclared, it’s inherited.

Nathan Gray
nathan at goarctic dot com

Extra punctuation??? Ug!!!
Just say no! Punctuation marks do not gain significance if you
increase their number, they make you look silly. One is sufficient.

eGroupWare-developers mailing list
eGroupWare-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/egroupware-developers

Nathan_Gray-2 2008-06-02 21:37:41 UTC #5

About hook support for agents you could try it effectively.
Agents needs to be derived from the agents bases classes, in that
sense they’re already hooks of the activities.

I submitted a patch for review,
http://www.egroupware.org:8080/egroupware/index.php?menuaction=tracker.uitracker.edit&tr_id=1392

It adds the ability for any eGW application to provide a workflow
agent without any copying or linking of source files.
Applications should support the hook ‘workflow_agent’. The hook
function should return an array like:
return array(
array(
‘wf_agent_type’ => ‘perp_build’,
‘wf_agent_priority’ => 1,
‘wf_agent_class’ => ‘perp_manufacturing.ui_agent_perp_build’
),
array(
‘wf_agent_type’ => ‘custom_agent’,
‘wf_agent_priority’ => 1,
‘wf_agent_class’ => ‘appname.classname’
)
);

Of course, the agent class must still extend ui_agent.
If there are no objections, I’ll commit it.

Nathan Gray
nathan at goarctic dot com

This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft® Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/

eGroupWare-developers mailing list
eGroupWare-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/egroupware-developers