R35509 - in /trunk/felamimail: inc/class.ajaxfelamimail.inc.php inc/class.uiwidgets.inc.php js/jscode/viewMainScreen.js

Old eGW-svn
1

Author: igel457
New Revision: 35509

URL: http://svn.stylite.de/viewvc/egroupware?rev=35509&view=rev
Log:
Fixed memory leak when refresh() is called, added mail_cleanup() method

Modified:
trunk/felamimail/inc/class.ajaxfelamimail.inc.php
trunk/felamimail/inc/class.uiwidgets.inc.php
trunk/felamimail/js/jscode/viewMainScreen.js

Modified: trunk/felamimail/inc/class.ajaxfelamimail.inc.php
URL: http://svn.stylite.de/viewvc/egroupware/trunk/felamimail/inc/class.ajaxfelamimail.inc.php?rev=35509&r1=35508&r2=35509&view=diff

— trunk/felamimail/inc/class.ajaxfelamimail.inc.php (original)
+++ trunk/felamimail/inc/class.ajaxfelamimail.inc.php Sun Jun 26 16:57:48 2011
@@ -493,6 +493,7 @@
{
if($this->_debug) error_log(“ajaxfelamimail::generateMessageList with $_folderName,$modifyoffset”.function_backtrace());
$response = new xajaxResponse();

  •   	$response->addScript("mail_cleanup()");
  	$response->addScript("activeServerID=".$this->imapServerID.";");
  	$response->addScript("activeFolder = \"".$_folderName."\";");
  	$response->addScript("activeFolderB64 = \"".base64_encode($_folderName)."\";");

Modified: trunk/felamimail/inc/class.uiwidgets.inc.php
URL: http://svn.stylite.de/viewvc/egroupware/trunk/felamimail/inc/class.uiwidgets.inc.php?rev=35509&r1=35508&r2=35509&view=diff

— trunk/felamimail/inc/class.uiwidgets.inc.php (original)
+++ trunk/felamimail/inc/class.uiwidgets.inc.php Sun Jun 26 16:57:48 2011
@@ -510,19 +510,15 @@
$js = '
if (typeof mailGrid == “undefined”) var mailGrid = null;
$(document).ready(function() {

  • $(window).resize(handleResize);

  • // Cleanup any old instance

  • mail_cleanup();

  • // Create the base objects and feed them with data
    var actionManager = egw_getActionManager(“felamimail”);
    var objectManager = egw_getObjectManager(“felamimail”);

    // Load the felamimail actions
    actionManager.updateActions(’.json_encode($actions=$this->get_actions($action_links)).’);

  • // Remove any old mailGrid actionObject instance

  • if (mailGrid != null)

  • {

  •   mailGrid.dataRoot.actionObject.remove();

  • }

    mailGrid = new egwGrid(document.getElementById(“divMessageTableList”),
    ’.json_encode($this->get_columns_obj(true,$foldertype,$_folderName)->get_assoc()).’, objectManager, egw_email_fetchDataProc,

Modified: trunk/felamimail/js/jscode/viewMainScreen.js
URL: http://svn.stylite.de/viewvc/egroupware/trunk/felamimail/js/jscode/viewMainScreen.js?rev=35509&r1=35508&r2=35509&view=diff

— trunk/felamimail/js/jscode/viewMainScreen.js (original)
+++ trunk/felamimail/js/jscode/viewMainScreen.js Sun Jun 26 16:57:48 2011
@@ -1369,3 +1369,9 @@
“felamimail.ajaxfelamimail.copyMessages”, target, messages);
}

+function mail_cleanup() {

  • var objectManager = egw_getObjectManager(“felamimail”);
  • objectManager.clear();
  • mailGrid = null;
  • $("#divMessageTableList").children().remove();
    +}

All of the data generated in your IT infrastructure is seriously valuable.
Why? It contains a definitive record of application performance, security
threats, fraudulent activity, and more. Splunk takes this data and makes
sense of it. IT sense. And common sense.
http://p.sf.net/sfu/splunk-d2d-c2

eGroupWare-cvs mailing list
eGroupWare-cvs@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/egroupware-cvs