Small display glitch in email / felamimail

Old eGW-developers
1

Hello Egroupware-developers,

I found a little display glitch in the email view (also preview).

When a message comes with plain text - an email-address is displayed
quite strange: Before and after the address there are additional
blanks and when pointing the the address (hover) the underline goes
before and after the address.

See attached litte picture.

Thanks.

–
Best regards,
Tin mailto:tinpos@gmail.com

2

this one is known and most probably caused by “linkifying” emailaddresses.

3

Hello Klaus,

Wednesday, January 19, 2011, 10:29:51 AM, you wrote:

this one is known and most probably caused by “linkifying” emailaddresses.

Sorry, I don’t understand…

The example was a really plain text email.

BTW. The www-link was dark blue and the email-link was blue. I didn’t
found where to change these colors…

Thanks.

–
Best regards,
Tin mailto:tinpos@gmail.com

Protect Your Site and Customers from Malware Attacks
Learn about various malware tactics and how to avoid them. Understand
malware threats, the impact they can have on your business, and how you
can protect your company and customers by using code signing.
http://p.sf.net/sfu/oracle-sfdevnl

eGroupWare-developers mailing list
eGroupWare-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/egroupware-developers

4

Plain text messages are processed within felamimail before displaying.
We attept to make clickable links from email adresses and links.

5

Hello Klaus,

Wednesday, January 19, 2011, 10:41:01 AM, you wrote:

Plain text messages are processed within felamimail before displaying.
We attept to make clickable links from email adresses and links.

Ok, thanks it’s clear now.

But is there any possibility to have an influence how messages are
"precessed before displaying" - eg. colors and formatting?

–
Best regards,
Tin mailto:tinpos@gmail.com

Protect Your Site and Customers from Malware Attacks
Learn about various malware tactics and how to avoid them. Understand
malware threats, the impact they can have on your business, and how you
can protect your company and customers by using code signing.
http://p.sf.net/sfu/oracle-sfdevnl

eGroupWare-developers mailing list
eGroupWare-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/egroupware-developers

6

In a way sure, not via UI, but by coding - yes.
But it is (can be) a quite complex issue. Not an easy one to tell you where to go and what to do (, depending on what you want to do exactly.)

7

Hello Klaus,

Wednesday, January 19, 2011, 12:48:33 PM, you wrote:

In a way sure, not via UI, but by coding - yes.
But it is (can be) a quite complex issue. Not an easy one to tell
you where to go and what to do (, depending on what you want to do exactly.)

What I want, very simple:

  1. That links (http and email) are underlined (not only on hoover) and
    that the colors of links for http and email links are the same.

  2. Email links don’t have additional blanks before and after the
    link-text.

–
Best regards,
Tin mailto:tinpos@gmail.com

Protect Your Site and Customers from Malware Attacks
Learn about various malware tactics and how to avoid them. Understand
malware threats, the impact they can have on your business, and how you
can protect your company and customers by using code signing.
http://p.sf.net/sfu/oracle-sfdevnl

eGroupWare-developers mailing list
eGroupWare-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/egroupware-developers

8

I take that as feature request.

you may have a look in the meantime at class.uidisplay.inc.php
function makeComposeLink and parseHREF
In makeComposeLink (trunk, line 213) the color of the link is explizitly defined, you may remove that, and the spaces before and after the email are added (Remove them too).
Please report any unwanted sideeffects, that may occur.

9

Hello Klaus,

removing spaces worked well - no “unwanted sideeffect” noticed. In my
opinion it makes really no sense to have these spaces before and after
the address. Changing color works as well.

I would like to have the hint now where to change the color of the
http-link - seems to be not in this file.

Thanks.

Tin

Wednesday, January 19, 2011, 1:42:01 PM, you wrote:

I take that as feature request.

you may have a look in the meantime at class.uidisplay.inc.php
function makeComposeLink and parseHREF
In makeComposeLink (trunk, line 213) the color of the link is
explizitly defined, you may remove that, and the spaces before and
after the email are added (Remove them too).
Please report any unwanted sideeffects, that may occur.

Von: “Tin” tinpos@gmail.com
An: "development of eGroupWare,for active developers"
egroupware-developers@lists.sourceforge.net
Datum: Wed, 19 Jan 2011 13:26:52 +0100

Hello Klaus,

Wednesday, January 19, 2011, 12:48:33 PM, you wrote:

In a way sure, not via UI, but by coding - yes.
But it is (can be) a quite complex issue. Not an easy one to tell
you where to go and what to do (, depending on what you want to do exactly.)

What I want, very simple:

  1. That links (http and email) are underlined (not only on hoover) and
    that the colors of links for http and email links are the same.

  2. Email links don’t have additional blanks before and after the
    link-text.

–
Best regards,
Tin mailto:tinpos@gmail.com

Protect Your Site and Customers from Malware Attacks
Learn about various malware tactics and how to avoid them. Understand
malware threats, the impact they can have on your business, and how you
can protect your company and customers by using code signing.
http://p.sf.net/sfu/oracle-sfdevnl

eGroupWare-developers mailing list
eGroupWare-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/egroupware-developers

Protect Your Site and Customers from Malware Attacks
Learn about various malware tactics and how to avoid them. Understand
malware threats, the impact they can have on your business, and how you
can protect your company and customers by using code signing.
http://p.sf.net/sfu/oracle-sfdevnl

eGroupWare-developers mailing list
eGroupWare-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/egroupware-developers

10

Hello

Wednesday, January 19, 2011, 7:53:02 PM, you wrote:

I would like to have the hint now where to change the color of the
http-link - seems to be not in this file.

I added in …/felamimail/templates/default/app.css the lines

/* added by tin */
.td_display a {
color: blue ! important;
}

This works - http-links in emails are now blue and not in the default
link color (something like “navi”).

–
Best regards,
Tin mailto:tinpos@gmail.com

Protect Your Site and Customers from Malware Attacks
Learn about various malware tactics and how to avoid them. Understand
malware threats, the impact they can have on your business, and how you
can protect your company and customers by using code signing.
http://p.sf.net/sfu/oracle-sfdevnl

eGroupWare-developers mailing list
eGroupWare-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/egroupware-developers