Addressbook; one change and one error

[Joze_Benedicic]

Hi!

I’m using:
latest SVN

I’d have some comments and propositions for addressbook.
First one is the possibility to organize contacts by location. If you click it organize that is shown is the same as if you are organizing by department. I was looking in the code and I found the line in class.addressbook_ui.inc.php, line 62; I’ve changed as it shows below.

‘org_name,adr_one_locality’ => lang(‘Organisations by location’),

‘org_name,adr_one_street’ => lang(‘Organisations by location’),

This is my suggestion to fix in the code.

Second thing is the question:
In the addressbook you have the feature to import CSV addressbook. I can do that without any problem as long as I’m not trying to import contact_id. Them it returns me the next error:

Invalid SQL: REPLACE INTO egw_addressbook (contact_owner,contact_private,n_family,n_given,n_prefix,n_suffix,n_fn,org_name,org_unit,contact_role,
adr_one_street,adr_one_locality,adr_one_postalcode,adr_one_countryname,contact_email,contact_modified,contact_modifier,,contact_id) VALUES (61662,0,'YXZ','ANDREJ',NULL,'med.','ANDREJ XYZ dr.dent.med.','ZDRAVSTVENI DOM','ZOBOZDRAVSTVO','ZDRAVNIKI','ZOBNA, 36','LJUBLJANA','1000','SLOVENIJA','andrej.xxytz@z.sda',1275901938,51430,'contact_etag=contact_etag+1',8557):
You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'contact_id) VALUES (61662,0,'YXZ','ANDREJ',NULL,'med.','ANDREJ ' at line 1

It seems like there is a problem with query, because I get two commas before contact_id.

And for the last I’d like to ask how this REPLACE feature is working? You have two fields under the fields where you choose what you are importing, but I don’t know how to choose them correctly to get previously imported people rewritten and not added.

Regards.

[Leithoff_Klaus]

Locality is the town, you intend to do it by street.
This may be usefull in some special cases but in general, i dont think so.
I object.

REPLACE is a feature of MYSQL and is used to do either an update if the
keyvalue is already existing or an insert if not
http://dev.mysql.com/doc/refman/5.1/en/replace.html

As I tested with trunk and imported an csv myself for tests sake, I could
not reproduce your error. I suggest, you check your field assignments for
your import.

[Joze_Benedicic]

Locality is the town, you intend to do it by street.
This may be usefull in some special cases but in general, i dont think so.
I object.

I do agree, that we may be too little to say that this should be changed, but what about if this line would be changed to parameter? Is that possible? That user would be able to choose which field he would like to organize from. Either city or street address?

As I tested with trunk and imported an csv myself for tests sake, I could
not reproduce your error. I suggest, you check your field assignments for
your import.

The weird thing here is that if I choose numbered field as uid I am able to import files without a problem. But then I don’t know how can I update users next time I import data (eg. next month). If I import that field as contact_id it returns me the Error I wrote before. I could post data sample if needed, because me and my colleague just can’t find the sollution for that problem.

regards.

[Leithoff_Klaus]

you may define a custom field with your external id.
you can pick that one as key at the end of the allocation map. (at least in
trunk, this will be available with the 1.8 but is not in 1.6)
So you may either wait for 1.8, or choose trunk (not recommended for
production), or choose an EPL from stylite.

If you want that as parameter, put in a feature request at egroupware.org
tracker.

[Joze_Benedicic]

Now I’ve came to an even deeper problem with this Locality\street address issue. We’ve changed the line from previous post, so we can see all of our streets.
Next thing we want to do is to get all our users from one location\street, to be seen then you click on magnifying glass icon. If I click on that icon I get all users, which is logical because we’ve only changed the showing line. Now we were searching, but nothing found. Anyone who knows what else to change to get it work?

[Leithoff_Klaus]

Inspect the element (the magnifying glass)
Check with function index (sets the selctbox to org_view with Locality) and
get_rows step through and check query at the beginning and the stuff passed
on to search) You will find your way.

kl@stylite.de
Stylite GmbH
[ open style of IT ]
Morschheimer Strasse 15
67292 Kirchheimbolanden

fon 06352 . 70629-0
fax 06352 . 70629-30
www.stylite.de

Geschäftsführer: Andre Keller, Gudrun Müller, Ralf Becker
Handelsregister Kaiserslautern HRB 30575
USt-ID: DE214280951