Another bug in syncml (with or whitout patch) and correction

zorg 2009-06-13 21:45:27 UTC #1

Like i have explain in a mail before

Here is the problem

When someone invite a group of partipicant if he had no right on this group
then the calendar event added can’t be synchronized by the member of
the group but it appear on the calendar without problem

the event get sync if the member accept the event

after looking in the code I think i have found why

in file
syncml/calendar/lib/api.php
line 122
we have

if (isset($event[‘participants’][$user]) && ($show_rejected || $event[‘participants’][$user] != ‘R’))

the problem is if the event comming from the search (calendar_bo_inc.php) contain onky a group (from the user) the participant didn’t answer

$event[‘participants’][$user] is not true

for me the solution would be to write only (because everything is filter before with the search)

if ( ($show_rejected || $event[‘participants’][$user] != ‘R’))

hope it help

Crystal Reports - New Free Runtime and 30 Day Trial
Check out the new simplified licensing option that enables unlimited
royalty-free distribution of the report engine for externally facing
server and web deployment.
http://p.sf.net/sfu/businessobjects

eGroupWare-developers mailing list
eGroupWare-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/egroupware-developers

zorg 2009-06-19 09:36:23 UTC #2

The first solution I have gave was not good at all

SO I have look deeper in the code and test it in production for few day
and now it seem to be ok

in fact we need to add before line 122 " if
(isset($event[‘participants’][$user]) && ($show_rejected ||
$event[‘participants’][$user] != ‘R’))"

this line
$boCalendar->enum_groups($event);

to get all the participant from the group add

If you have use le patch from
(http://k.noc.de/index.php?option=com_content&view=article&id=6)
you need to add it before line 244
if ((!$startDate || $startDate <= $event[‘start’]
&& $event[‘end’] <=
$endDate)

zorg a écrit :$boCalendar->enum_groups($event);

Like i have explain in a mail before

Here is the problem

When someone invite a group of partipicant if he had no right on this group
then the calendar event added can’t be synchronized by the member of
the group but it appear on the calendar without problem

the event get sync if the member accept the event

after looking in the code I think i have found why

in file
syncml/calendar/lib/api.php
line 122
we have

if (isset($event[‘participants’][$user]) && ($show_rejected || $event[‘participants’][$user] != ‘R’))

the problem is if the event comming from the search (calendar_bo_inc.php) contain onky a group (from the user) the participant didn’t answer

$event[‘participants’][$user] is not true

for me the solution would be to write only (because everything is filter before with the search)

if ( ($show_rejected || $event[‘participants’][$user] != ‘R’))

hope it help

Crystal Reports - New Free Runtime and 30 Day Trial
Check out the new simplified licensing option that enables unlimited
royalty-free distribution of the report engine for externally facing
server and web deployment.
http://p.sf.net/sfu/businessobjects

eGroupWare-developers mailing list
eGroupWare-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/egroupware-developers

eGroupWare-developers mailing list
eGroupWare-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/egroupware-developers

zorg 2009-08-06 16:12:53 UTC #3

Hello
here i resent and old bug and patch that should be fix (except if it has
be already done)

When someone invite a group of partipicant if he had no right on this
group then the calendar event added can’t be synchronized by the
member of the group but it appear on the calendar without problem

in fact we need to add before line 122 " if
(isset($event[‘participants’][$user]) && ($show_rejected ||
$event[‘participants’][$user] != ‘R’))"

this line
$boCalendar->enum_groups($event);

to get all the participant from the group add

Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify your report design, integration and deployment - and focus on
what you do best, core application coding. Discover what’s new with
Crystal Reports now. http://p.sf.net/sfu/bobj-july

eGroupWare-developers mailing list
eGroupWare-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/egroupware-developers

Joerg_Lehrke-2 2009-08-06 20:36:41 UTC #4

Hi,

I’ll put your fix in my next version.

Thanks for your help!
         J"org

Hello
here i resent and old bug and patch that should be fix (except if it has
be already done)

When someone invite a group of partipicant if he had no right on this
group then the calendar event added can’t be synchronized by the
member of the group but it appear on the calendar without problem

in fact we need to add before line 122 " if
(isset($event[‘participants’][$user]) && ($show_rejected ||
$event[‘participants’][$user] != ‘R’))"

this line
$boCalendar->enum_groups($event);

to get all the participant from the group add

If you have use le patch from
(http://k.noc.de/index.php?option=com_content&view=article&id=6)
you need to add it before line 244
if ((!$startDate || $startDate <= $event[‘start’]
&& $event[‘end’] <=
$endDate)

eGroupWare-developers mailing list
eGroupWare-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/egroupware-developers