Bug in egroupware - affects ajax select widget (at least)

[Raphael_Alla-2]

Hi,

I found the following bug (?) in egroupware.

Description of the bug:
If, for an extension, the onchange parametre tries to use the expand name
feature of egroupware, then it will be passed to the extension prior to the
expand_name function being called. It affects the ajax_select_widget because
of the use it makes of the onchange parametre.

For instance, if in your ajax_select_widget you have an onchange function of
the form ‘updateRow(${row})’, the ${row} will not be updated with the row
number as expected.

The same issue would potentially affect other egroupware extension widgets.

Solution:
Add the following lines in uietemplate.inc.php on line 923
if (strchr($cell[‘onchange’],’$’) || $cell[‘onchange’]{0} ==
’@’)
{
$cell[‘onchange’] =
$this->expand_name($cell[‘onchange’],$show_c,$show_row,$content[’.c’],$content[’.row’],$content);
}

Please apply the above patch to uieetemplate.

Regards

Raphael Alla

–
Raphael Alla
Mitija Australia
+61 4 15 678 576
+687 78 86 86
http://www.mitija.com

[Ralf_Becker_6]

Hi Raphael,

line 923 is in template_name above show_cell in trunk, maybe you’re on a
different version.

I added it testwise on direct above:

// the while loop allows to build extensions from other extensions
// please note: only the first extension’s post_process function is
called !!!
list($type,$sub_type) = explode(’-’,$cell[‘type’]);
while ((!$this->types[$cell[‘type’]] || !empty($sub_type)) &&
$this->haveExtension($type,‘pre_process’))

and removed it further down …

I commit the change, if I dont run into problems with it in the next
days. Please remind me, if I forget it …

Ralf

Raphael Alla schrieb:

Hi,

I found the following bug (?) in egroupware.

Description of the bug:
If, for an extension, the onchange parametre tries to use the expand
name feature of egroupware, then it will be passed to the extension
prior to the expand_name function being called. It affects the
ajax_select_widget because of the use it makes of the onchange parametre.

For instance, if in your ajax_select_widget you have an onchange
function of the form ‘updateRow(${row})’, the ${row} will not be updated
with the row number as expected.

The same issue would potentially affect other egroupware extension widgets.

Solution:
Add the following lines in uietemplate.inc.php on line 923
if (strchr($cell[‘onchange’],’$’) || $cell[‘onchange’]{0} ==
’@’)
{
$cell[‘onchange’] =
$this->expand_name($cell[‘onchange’],$show_c,$show_row,$content[’.c’],$content[’.row’],$content);
}

Please apply the above patch to uieetemplate.

Regards

Raphael Alla

–
Raphael Alla
Mitija Australia
+61 4 15 678 576
+687 78 86 86
http://www.mitija.com

---

---

This SF.net email is sponsored by the 2008 JavaOne(SM) Conference
Register now and save $200. Hurry, offer ends at 11:59 p.m.,
Monday, April 7! Use priority code J8TLD2.
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone

---

---

eGroupWare-developers mailing list
eGroupWare-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/egroupware-developers

–
Ralf Becker
eGroupWare Training & Support ==> http://www.egroupware-support.de
Outdoor Unlimited Training GmbH [www.outdoor-training.de]
Handelsregister HRB Kaiserslautern 3587
Geschäftsführer Birgit und Ralf Becker
Leibnizstr. 17, 67663 Kaiserslautern, Germany
Telefon +49 (0)631 31657-0

---

This SF.net email is sponsored by the 2008 JavaOne(SM) Conference
Don’t miss this year’s exciting event. There’s still time to save $100.
Use priority code J8TL2D2.
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone

---

eGroupWare-developers mailing list
eGroupWare-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/egroupware-developers