Bug in icalsrv.php(?)

Pakus 2006-10-13 16:25:33 UTC #21

Hi Ralf,

I was wrong. I thought you have developed icalsrv.php
Now I see that I was wrong.

On icalsrv site:
http://www.xs4all.nl/~jvl/software/egroupware/icalsrv/html/index.html

Say that bugs/errors can be submited to:
https://sourceforge.net/tracker/?group_id=78745&atid=554338

But I think It’s outdated.
Do u think we should submit an error on egw tracker?

I’m revising the code, but I don’t know where’s the problem.

Hi Paco,

I have no idea about iCal Server. The patch ignores a not set user-id
(which the search function requires) and uses the current user instead.

As you have the same problem with infolog, I guess iCal Server fails to
pass a user-id.

Ralf

Paco Orozco schrieb:

Hi Oscar,

logged in not with the default domain, I enter the url
(http://…/icalsrv.php/default.ics), I’m prompted for user and password
(which SHOULDN’T happen, since I’m logged in) and entering user (not
user@domain) and password, I get the sql error and when I go back to the
previous screen, I find I’ve been taken to another domain (I think because
the default domain is searched instead), possibly even logging out,
depending on if the user exists on both domains. It’s the second time I
reply because of this

As I understand you are prompted for login because your session can’t
be verified. I’ve been investigating the code, and qhen icalsrv.php
calls class.bocal.inc.php there’s a problem with the session
verification, I think it’s not passing user information.

This is the problem, because It can’t verify you, so It prompts you
for a password.

May Ralf can put some light in this bug.
I’ve tried to follow the code in order to know why is buggy, but I
can’t figure out.

Ralf, can you give us an advice?

Your latest patches on SVN hide the SQL error, but It’s still wrong,
because It can’t SELECT calendar entries for user.

See u.

–
eGroupWare Training & Support ==> http://www.egroupware-support.de
1.2 Release Offer: 250Euro for a Standard Update or Installation
including 1h Telefonsupport und ein gedrucktes deutsches Handbuch

Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642

eGroupWare-developers mailing list
eGroupWare-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/egroupware-developers

–

Aquel que planta árboles bajo los
que sabe muy bien que nunca se
sentara, ha descubierto el auténtico
significado de la vida.

Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642

eGroupWare-developers mailing list
eGroupWare-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/egroupware-developers

Pakus 2006-10-14 18:21:43 UTC #22

Hiya,

Well, as I mentioned before I think there was a problem with session
handler and I was on true.

Now I’ve patched icalsrv.php in order to allow HTTP authentication.
I’m not sending a patch file (diff) because changes are too deep.

To test it, you must change icalsrv.php (1.2.105, the only that I’ve
tested) by mine one (see attached).

It always forces to authenticate HTTP, maybe in future version I
try to use cookies (if exists).

Known problems:

It isn’t using cookies, so If you are logged on EGW and point to
icalsrv.php you should put user/pass again
It always create a new session (I don’t know if it’s a problem)
User virtual calendar, diferent that user logged in, doesn’t work.
On the version that I’ve based it doesn’t works

Thanks to all… I’ll try to maintain and improve this icalsrv.php.

–

Aquel que planta árboles bajo los
que sabe muy bien que nunca se
sentara, ha descubierto el auténtico
significado de la vida.

Eric_D_Schabell-2 2006-10-17 07:32:51 UTC #23

I will take a look at this later today, let you know what I think.

Ralf is about to make some structural changes in the development tree (for
icalsrv/egwical directories) I believe, getting ready for the 1.4 release so
need to check this fix now.

Regards,
erics

Eric D. Schabell M.Sc - http://www.schabell.com

Eric_D_Schabell-2 2006-10-17 10:17:50 UTC #24

I have taken a look, this does fix the problem with failing infolog query. I
see no reason not to add this in to the TRUNK version. I have created a
patch here (see attached) and am including my mentor Lars so that he can
commit it to trunk should he see fit. I have only tested it with my own
calendar setup here for 1.3 development tree (TRUNK). I will ask my user
base to test it in the coming days, should anything turn up I will let you
know.

Thanks Paco for the time and effort.

Lars, can you take a look at getting this into trunk?

Regards,
erics

Eric D. Schabell M.Sc - http://www.schabell.com

Eric_D_Schabell-2 2006-10-17 10:19:17 UTC #25

This time with the patch attached… doh!

Bugzilla_from_adi 2006-10-17 10:53:19 UTC #26

Hi Eric!

I have taken a look, this does fix the problem with failing infolog query.
It does – absolutely!

Thanks Paco for the time and effort.
Thanks to both of you!

Now icalsrv seems to work fine again – I just applied the patches and ran a
quick test…

– Adi

eGroupWare-developers mailing list
eGroupWare-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/egroupware-developers

nl2-2 2006-11-03 22:12:26 UTC #27

Hello Pakus,

I think is there any problem with session handler.[/quote]

If you hack into “phpgwapi/inc/class.sessions_php4.inc.php on line 64” as the php-error says you can see the combination session_id($this->sessionid); and session_start();. When you type between this lines of code “echo $this->sessionid;” you would see the session printed at the page. I was suprised to see my username! So the session_id was “prename.lastname”. And yes, there is an invalid character, the “.” I think most of you are using prename.name as login and so the . will also be in your session.

But I didn’t fount the line where the session-id is defined. Maybe it comes from the htaccess-login? It would be better to change it into an md5-hash. Maybe this helps to find the solution for this problem. Would be nice

Niels.

Oscar_Manuel_Gomez_S 2006-12-29 11:39:42 UTC #28

Oscar Manuel Gómez Senovilla escribió:

Paco Orozco pakusland@gmail.com escribió:

Hiya,

I’ve copied the three modified files from SVN to my 1.2.105 egw.
Now I’ve got the same error than last Adi Kriegisch (see below).
On my logs I’m seeing a session error, I think this session handler
error is associate with SQL error, because soinfolog::search is unable
to obtain info_owner value

I think there’s a serious bug in keeping (at least) the domain. I saw this
and reported long time ago, but it seems that a multidomain installation
triggers the error better than a one-domain installation (though I didn’t
test this in a one-domain and 1.2 recently). In my current test, being
logged in not with the default domain, I enter the url
(http://…/icalsrv.php/default.ics), I’m prompted for user and password
(which SHOULDN’T happen, since I’m logged in) and entering user (not
user@domain) and password, I get the sql error and when I go back to the
previous screen, I find I’ve been taken to another domain (I think because
the default domain is searched instead), possibly even logging out,
depending on if the user exists on both domains. It’s the second time I
reply because of this

I think I’ve found the solution for this, as a side effect of the work
in news_admin. In icalsrv.php, about line 138, I’ve replaced

$domain = $GLOBALS[‘egw_info’][‘server’][‘default_domain’];

with

$domain = $GLOBALS[‘egw_info’][‘user’][‘domain’];

and I can relocate the user in the started session back and forth.

Please review this. If you want me to commit this change, let me know.

Regards.

----------------------------------------------------------------------|
http://counter.li.org info: Linux user: 92390 - Linux machine: 39301 |
Oscar Manuel Gómez Senovilla - omgsATescomposlinux.org |
GPG Key at http://pgp.escomposlinux.org |
----------------------------------------------------------------------|

Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net’s Techsay panel and you’ll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV

eGroupWare-developers mailing list
eGroupWare-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/egroupware-developers

Oscar_Manuel_Gomez_S 2006-12-29 13:24:21 UTC #29

Oscar Manuel Gómez Senovilla escribió:

Oscar Manuel Gómez Senovilla escribió:

Paco Orozco pakusland@gmail.com escribió:

Hiya,

I’ve copied the three modified files from SVN to my 1.2.105 egw.
Now I’ve got the same error than last Adi Kriegisch (see below).
On my logs I’m seeing a session error, I think this session handler
error is associate with SQL error, because soinfolog::search is unable
to obtain info_owner value

I think there’s a serious bug in keeping (at least) the domain. I saw this
and reported long time ago, but it seems that a multidomain installation
triggers the error better than a one-domain installation (though I didn’t
test this in a one-domain and 1.2 recently). In my current test, being
logged in not with the default domain, I enter the url
(http://…/icalsrv.php/default.ics), I’m prompted for user and password
(which SHOULDN’T happen, since I’m logged in) and entering user (not
user@domain) and password, I get the sql error and when I go back to the
previous screen, I find I’ve been taken to another domain (I think because
the default domain is searched instead), possibly even logging out,
depending on if the user exists on both domains. It’s the second time I
reply because of this

I think I’ve found the solution for this, as a side effect of the work
in news_admin. In icalsrv.php, about line 138, I’ve replaced

$domain = $GLOBALS[‘egw_info’][‘server’][‘default_domain’];

with

$domain = $GLOBALS[‘egw_info’][‘user’][‘domain’];

and I can relocate the user in the started session back and forth.

I think this is better:

$GLOBALS['egw_info']['server']['default_domain']=$domain =

$GLOBALS[‘egw_info’][‘user’][‘domain’]

There’s also another bug that I think at least I’ve reduced (not sure if
fixed is too much): every time icalsrv.php is accessed, a new session is
created, regardless any existing sessions. In a moment I’ve reached over
40 sessions (which is not really true). To fix this, I’ve changed line
62 in icalsrv.php, setting ‘icalsrv’ instead of ‘login’ as currentapp,
and by the moment it seems to work.

Please review this. If you want me to commit this change, let me know.

Please keep reviewing.

Regards.

----------------------------------------------------------------------|
http://counter.li.org info: Linux user: 92390 - Linux machine: 39301 |
Oscar Manuel Gómez Senovilla - omgsATescomposlinux.org |
GPG Key at http://pgp.escomposlinux.org |
----------------------------------------------------------------------|

eGroupWare-developers mailing list
eGroupWare-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/egroupware-developers

ralfbecker_dr 2006-12-29 13:36:22 UTC #30

Hi Oscar,

maybe it’s a good idea to put that mail also in the patch manager, as
the other 2 patches for iCalServer.

Ralf

Oscar Manuel Gómez Senovilla schrieb:

Oscar Manuel Gómez Senovilla escribió:

Oscar Manuel Gómez Senovilla escribió:

Paco Orozco pakusland@gmail.com escribió:

Hiya,

I’ve copied the three modified files from SVN to my 1.2.105 egw.
Now I’ve got the same error than last Adi Kriegisch (see below).
On my logs I’m seeing a session error, I think this session handler
error is associate with SQL error, because soinfolog::search is unable
to obtain info_owner value
I think there’s a serious bug in keeping (at least) the domain. I saw this
and reported long time ago, but it seems that a multidomain installation
triggers the error better than a one-domain installation (though I didn’t
test this in a one-domain and 1.2 recently). In my current test, being
logged in not with the default domain, I enter the url
(http://…/icalsrv.php/default.ics), I’m prompted for user and password
(which SHOULDN’T happen, since I’m logged in) and entering user (not
user@domain) and password, I get the sql error and when I go back to the
previous screen, I find I’ve been taken to another domain (I think because
the default domain is searched instead), possibly even logging out,
depending on if the user exists on both domains. It’s the second time I
reply because of this

I think I’ve found the solution for this, as a side effect of the work
in news_admin. In icalsrv.php, about line 138, I’ve replaced

$domain = $GLOBALS[‘egw_info’][‘server’][‘default_domain’];

with

$domain = $GLOBALS[‘egw_info’][‘user’][‘domain’];

and I can relocate the user in the started session back and forth.

I think this is better:
$GLOBALS['egw_info']['server']['default_domain']=$domain =
$GLOBALS[‘egw_info’][‘user’][‘domain’]

There’s also another bug that I think at least I’ve reduced (not sure if
fixed is too much): every time icalsrv.php is accessed, a new session is
created, regardless any existing sessions. In a moment I’ve reached over
40 sessions (which is not really true). To fix this, I’ve changed line
62 in icalsrv.php, setting ‘icalsrv’ instead of ‘login’ as currentapp,
and by the moment it seems to work.

Please review this. If you want me to commit this change, let me know.

Please keep reviewing.

Regards.

eGroupWare-developers mailing list
eGroupWare-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/egroupware-developers

–
eGroupWare Training & Support ==> http://www.egroupware-support.de
1.2 Release Offer: 250Euro for a Standard Update or Installation
including 1h Telefonsupport und ein gedrucktes deutsches Handbuch

eGroupWare-developers mailing list
eGroupWare-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/egroupware-developers

Oscar_Manuel_Gomez_S 2006-12-29 14:04:25 UTC #31

Ralf Becker escribió:

Hi Oscar,

maybe it’s a good idea to put that mail also in the patch manager, as
the other 2 patches for iCalServer.

Ok, done.

I remember that Jan told me to still having some time on holidays, and
for whatever reason maybe he forgot or didn’t receive the mail for the
patches, so I propose to give some prudential time (~ 1 week) and if the
developers are too inactive, commit these changes (I think they’re
important), with the possibility of being enhanced or rolled back if
there are any problems. I can commit my changes in these circumstances.

Regards.

----------------------------------------------------------------------|
http://counter.li.org info: Linux user: 92390 - Linux machine: 39301 |
Oscar Manuel Gómez Senovilla - omgsATescomposlinux.org |
GPG Key at http://pgp.escomposlinux.org |
----------------------------------------------------------------------|

eGroupWare-developers mailing list
eGroupWare-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/egroupware-developers

Henry101 2008-12-17 06:48:39 UTC #32

Hi,

Im trying to set the value of ‘info_responsible’ field to be $this->user everytime.

I dont want to display the info_responsible value in the user interface, instead i want this value to be set explicitly to the user who is creating the new Infolog entry when they click the Save button.

Does anyone have any idea on how to do this? Please help