Calendar List view and Recurring Events

Hans-Jurgen_Tappe 2010-04-22 21:34:46 UTC #1

Hi!

Is it a bug or a feature that there is no popup in the 1.6 list view when
I select to edit a recurring event, whether I want to edit only the one
event or the series? From the list view, I have to manually declare the
exception and then edit the event. This is irritating because the users
here forget that they are going to edit the whole series instead of just
one event.

In trunk, it is even worse, there the event is silently unchained from
the series, so it is impossible to edit the series from the list view.
This does not seem to be a user-friendly behavior.

Any suggestion? Should this be solved or is this somehow intended or
technically required?

Thanks,
Hans-Jürgen

eGroupWare-developers mailing list
eGroupWare-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/egroupware-developers

ngegw 2010-04-22 21:42:49 UTC #2

…
In trunk, it is even worse, there the event is silently unchained from
the series, so it is impossible to edit the series from the list view.
This does not seem to be a user-friendly behavior.

Are you using latest trunk? It should ask you with a nice popup, as of today.
If not, I’ll have to get some more information from you.
The onclick of the edit button for a series should be
edit_series(cal_id, datestamp).

Nathan

eGroupWare-developers mailing list
eGroupWare-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/egroupware-developers

Hans-Jurgen_Tappe 2010-04-22 21:56:34 UTC #3

Hello Nathan!

Nathan Gray schrieb:

On Thu, Apr 22, 2010 at 3:34 PM, Hans-Juergen Tappe

In trunk, it is even worse, there the event is silently unchained from
the series, so it is impossible to edit the series from the list view.
This does not seem to be a user-friendly behavior.
Are you using latest trunk?

Today in the morning, European time.

It should ask you with a nice popup, as of today.

You are right (just update the code again). Thanks a lot for the updates
in trunk, they really look much more modern, compared to the old
JavaScript alert.

Do you know what the behavior in 1.6 should be? Has there ever been such
a popup in the list view? I personally did not use the list view a lot in
the past.

Best regards,
Hans-Jürgen

eGroupWare-developers mailing list
eGroupWare-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/egroupware-developers

ngegw 2010-04-22 22:04:35 UTC #4

…
You are right (just update the code again). Thanks a lot for the updates
in trunk, they really look much more modern, compared to the old
JavaScript alert.

I didn’t make the popup, I just applied it to the list view. I agree,
it looks very nice.

Do you know what the behavior in 1.6 should be? Has there ever been such
a popup in the list view? I personally did not use the list view a lot in
the past.

I didn’t use it a lot either, but I think it was editing the series every time.

Nathan

eGroupWare-developers mailing list
eGroupWare-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/egroupware-developers

Ralf_Becker_Stylite 2010-04-23 09:16:22 UTC #5

I added the popup to trunk, as I always struggeled with the wording of
the old confirm dialog.

What’s missing in 1.6 is not necessarily the new popup, but Nathans fix
to ask that question in list view too and open a different url based on
the answer. Currently 1.6 always creates an exception, which is surely
not desired. Nathan fixed that in Trunk, with the current code of trunk
(new popup).

So in principle we would need to merge:

r29818: better understandable dialog for editing recuring events
(plus missing translations)
r29911: nicer styling for edit series popup, moved stylites to
app.css file
r29943: Use the pretty popup to ask about editing series or exception

@Hans-Jürgen: you wana give it a try?

@Nathan: r29911 + r29943 also need to be merged to EPL-9.2, can you do
that, or should I?

Ralf

…
You are right (just update the code again). Thanks a lot for the updates
in trunk, they really look much more modern, compared to the old
JavaScript alert.

I didn’t make the popup, I just applied it to the list view. I agree,
it looks very nice.

Do you know what the behavior in 1.6 should be? Has there ever been such
a popup in the list view? I personally did not use the list view a lot in
the past.

I didn’t use it a lot either, but I think it was editing the series every time.

Nathan

eGroupWare-developers mailing list
eGroupWare-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/egroupware-developers

–
Ralf Becker
Director Software Development

Stylite GmbH
[open style of IT]

Morschheimer Strasse 15
67292 Kirchheimbolanden

fon +49 (0) 6352 70629-0
fax +49 (0) 6352 70629-30
mailto: rb@stylite.de

www.stylite.de
www.egroupware.org

Geschäftsführer Andre Keller,
Gudrun Müller, Ralf Becker
Registergericht Kaiserslautern HRB 30575
Umsatzsteuer-Id / VAT-Id: DE214280951

eGroupWare-developers mailing list
eGroupWare-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/egroupware-developers

Hans-Jurgen_Tappe 2010-04-23 12:00:39 UTC #6

Hello Ralf!

Ralf Becker schrieb:

So in principle we would need to merge:

r29818: better understandable dialog for editing recuring events
(plus missing translations)

r29911: nicer styling for edit series popup, moved stylites to
app.css file

r29943: Use the pretty popup to ask about editing series or exception
@Hans-Jürgen: you wana give it a try?

I can do that if we want to add the feature in the stable branch.
But give me some days for understanding and testing.

Best regards,
Hans-Jürgen

eGroupWare-developers mailing list
eGroupWare-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/egroupware-developers

ngegw 2010-04-23 14:42:14 UTC #7

@Nathan: r29911 + r29943 also need to be merged to EPL-9.2, can you do
that, or should I?

I forgot my SVN password

eGroupWare-developers mailing list
eGroupWare-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/egroupware-developers

Hans-Jurgen_Tappe 2010-04-24 20:31:22 UTC #8

Hi Ralf!

Ralf Becker schrieb:

I added the popup to trunk, as I always struggeled with the wording of
the old confirm dialog.

In trunk, when I open home or calendar, the popup is always there.
If I choose edit series, I get the URL

menuaction=calendar.calendar_uiforms.edit&cal_id=undefined&date=undefined
and en error saying
Warning: Invalid argument supplied for foreach() in
/var/www/egroupware/etemplate/inc/class.historylog_widget.inc.php on line 140

Or for “edit exception”:
menuaction=calendar.calendar_uiforms.edit&cal_id=undefined&date=undefined&exception=1

Can you please fix this?

Also, from the usability perspective, I personally would prefer a
hovering popup. It currently makes the calendar jump each time it opens.
maybe, you also want to change the CSS class in order to achieve the
hovering effect.

Thanks and best regards,
Hans-Jürgen

eGroupWare-developers mailing list
eGroupWare-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/egroupware-developers

Ralf_Becker_Stylite 2010-04-26 07:05:22 UTC #9

Hi Hans-Jürgen,

Hi Ralf!

Ralf Becker schrieb:

I added the popup to trunk, as I always struggeled with the wording of
the old confirm dialog.

In trunk, when I open home or calendar, the popup is always there.

I can NOT confirm that!

The popup is hidden unless you click on an event. Are you talking about
Trunk or merging it into 1.6 (you might have missed to merge the css
stuff into calendar/templates/default/app.css

If I choose edit series, I get the URL

menuaction=calendar.calendar_uiforms.edit&cal_id=undefined&date=undefined

Sure only the click on an event fills cal_id and date.

Ralf

and en error saying
Warning: Invalid argument supplied for foreach() in
/var/www/egroupware/etemplate/inc/class.historylog_widget.inc.php on line 140

Or for “edit exception”:
menuaction=calendar.calendar_uiforms.edit&cal_id=undefined&date=undefined&exception=1

Can you please fix this?

Also, from the usability perspective, I personally would prefer a
hovering popup. It currently makes the calendar jump each time it opens.
maybe, you also want to change the CSS class in order to achieve the
hovering effect.

Thanks and best regards,
Hans-Jürgen

eGroupWare-developers mailing list
eGroupWare-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/egroupware-developers

–
Ralf Becker
Director Software Development

Stylite GmbH
[open style of IT]

Morschheimer Strasse 15
67292 Kirchheimbolanden

fon +49 (0) 6352 70629-0
fax +49 (0) 6352 70629-30
mailto: rb@stylite.de

www.stylite.de
www.egroupware.org

Geschäftsführer Andre Keller,
Gudrun Müller, Ralf Becker
Registergericht Kaiserslautern HRB 30575
Umsatzsteuer-Id / VAT-Id: DE214280951

eGroupWare-developers mailing list
eGroupWare-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/egroupware-developers