Calendar Participants Sorting

[sank]

I find that calendar participant sorting drives me crazy. Currently it sorts by database order, which is to say it is not sorted at all. So I wrote a fix that I am submitting for possible inclusion in the future. My improved sorting alphabetizes by participant[‘title’] after separating into groups: User, Group Invitation, Group.

class.calendar_uiforms.inc.php
// Default sorting sucks. We can do better.
if (!function_exists(‘cmp’))
{
function cmp($a, $b)
{
// Sort by group first, then name
$grpsort = -1*strcmp($a[‘app’],$b[‘app’]); // User, then Group Invite, then Group
return ($grpsort)?$grpsort: strcmp($a[‘title’],$b[‘title’]);
}
}
usort($content[‘participants’], ‘cmp’);

I don’t have the exact line number it should go on, as i have other customizations that aren’t useful for the general audience, but it goes right before “// resouces / apps we shedule, atm. resources and addressbook” and right after the end of the “foreach($participants as $id => $status)” loop.

I put the cmp function nested because i’m lazy and it’s easier to merge the code. Anonymous function was my first attempt, but alas i’m using php 5.2, and anonymous functions were added in 5.3.

Anyway, i hope this can improve the user experience for all (and I don’t want to have to merge it in manually again on my next update :- )

Cheers,

[Ralf_Becker_Stylite]

Hi,

commited something simmilar in all branches.

Thanks for the feedback

Ralf

I find that calendar participant sorting drives me crazy. Currently it sorts
by database order, which is to say it is not sorted at all. So I wrote a
fix that I am submitting for possible inclusion in the future. My improved
sorting alphabetizes by participant[‘title’] after separating into groups:
User, Group Invitation, Group.

class.calendar_uiforms.inc.php
// Default sorting sucks. We can do better.
if (!function_exists(‘cmp’))
{
function cmp($a, $b)
{
// Sort by group first, then name
$grpsort = -1*strcmp($a[‘app’],$b[‘app’]); // User, then Group Invite,
then Group
return ($grpsort)?$grpsort: strcmp($a[‘title’],$b[‘title’]);
}
}
usort($content[‘participants’], ‘cmp’);

I don’t have the exact line number it should go on, as i have other
customizations that aren’t useful for the general audience, but it goes
right before "// resouces / apps we shedule, atm. resources and addressbook"
and right after the end of the "foreach($participants as $id => $status)"
loop.

I put the cmp function nested because i’m lazy and it’s easier to merge the
code. Anonymous function was my first attempt, but alas i’m using php 5.2,
and anonymous functions were added in 5.3.

Anyway, i hope this can improve the user experience for all (and I don’t
want to have to merge it in manually again on my next update :- )

Cheers,

–
View this message in context: http://egroupware.219119.n3.nabble.com/Calendar-Participants-Sorting-tp3986880.html
Sent from the egroupware-developers mailing list archive at Nabble.com.

---

Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_d2d_nov

---

eGroupWare-developers mailing list
eGroupWare-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/egroupware-developers

–
Ralf Becker
Director Software Development

Stylite AG

Morschheimer Strasse 15 | Tel. +49 6352 70629 0
D-67292 Kirchheimbolanden | Fax. +49 6352 70629 30

Email: rb@stylite.de

www.stylite.de | www.egroupware.org

Managing Directors: Andre Keller | Ralf Becker | Gudrun Mueller
Chairman of the supervisory board: Prof. Dr. Birger Leon Kropshofer

VAT DE214280951 | Registered HRB 31158 Kaiserslautern Germany

---

Monitor your physical, virtual and cloud infrastructure from a single
web console. Get in-depth insight into apps, servers, databases, vmware,
SAP, cloud infrastructure, etc. Download 30-day Free Trial.
Pricing starts from $795 for 25 servers or applications!
http://p.sf.net/sfu/zoho_dev2dev_nov

---

eGroupWare-developers mailing list
eGroupWare-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/egroupware-developers

[sank]

Great! Thanks!

Is this the correct method for submitting such things, or is there a better way to make suggestions like this?

Cheers,