Cannot add resource picture

[xenolevis]

Morning All,

I am not able to use my own pictures for resources.
This worked well in the past and there are a number of resources already with custom pictures. However for new resources if I try to add a picture I always get the error

Picture type is not supported, sorry!

I have not added resources in a long time so I cannot tell you when this behavior started. Now running 17.1.20180209. Nothing in the httpd error logs, nothing I find helpful in the access logs. I have tried jpg and png files of various sizes down to 64x64 pixel.

Any thoughts?
Cheers!

[RalfBecker]

Found that error message in the code:

EGroupware/egroupware/blob/master/resources/inc/class.resources_bo.inc.php#L916

It means your browser reported an unsupported mime-type, or as you tried it with png and jpeg it probably reported “application/octet-stream”. Please give my following fix a try:

	function save_picture($file,$resouce_id)
	{
		switch($file['type'])
		{
			case 'image/gif':
				$src_img = imagecreatefromgif($file['tmp_name']);
				break;
			case 'image/jpeg':
			case 'image/pjpeg':
				$src_img = imagecreatefromjpeg($file['tmp_name']);
				break;
			case 'image/png':
			case 'image/x-png':
				$src_img = imagecreatefrompng($file['tmp_name']);
				break;
			case 'application/octet-stream':
				$file['type'] = Api\MimeMagic::filename2mime($file['tmp_name']);
				return $this->save_picture($file, $resouce_id);
			default:
				return $file['type'].': '.lang('Picture type is not supported, sorry!');
		}

		$tmp_name = tempnam($GLOBALS['egw_info']['server']['temp_dir'],'resources-picture');
		imagejpeg($src_img,$tmp_name);
		imagedestroy($src_img);

		Link::attach_file('resources',$resouce_id,array(
			'tmp_name' => $tmp_name,
			'name'     => self::PICTURE_NAME,
			'type'     => 'image/jpeg',
		));
	}

Let me know if that fixes the problem for you, then I will add it to next maintenance release.
It also reports not the mime-type as part of the error.

Ralf

[xenolevis]

Hi Ralf, thanks for the code.
The mime-type was indeed application/octet-stream. But now I get this:

A request to the EGroupware server returned with an error: NetworkError: A network error occurred. (0)

Please reload the EGroupware desktop (F5 / Cmd+r). If the error persists, contact your administrator for help and ask to check the error-log of the webserver.

URL: /egroupware/json.php?menuaction=EGroupware\Api\Etemplate::ajax_process_content

… and the error log informs me that the http server crashes with a segmentation fault.

Sorry, this just got more complicated.

[RalfBecker]

What PHP version and Linux distribution is that?

[xenolevis]

PHP 5.6.34
CentOS Linux release 7.4.1708

From what I can tell Api\MimeMagic::filename2mime($file[‘tmp_name’]) returns application/octet-stream, so the recursive call leads to a crash.

[xenolevis]

I tried this:

 function save_picture($file,$resouce_id)
    {
            $file['type'] = Api\MimeMagic::filename2mime($file['tmp_name']);
            switch($file['type'])
            {
                    case 'image/gif':
                            $src_img = imagecreatefromgif($file['tmp_name']);
                            break;
                    case 'image/jpeg':
                    case 'image/pjpeg':
                            $src_img = imagecreatefromjpeg($file['tmp_name']);
                            break;
                    case 'image/png':
                    case 'image/x-png':
                            $src_img = imagecreatefrompng($file['tmp_name']);
                            break;
                    default:
                            return $file['type'].': '.$file['tmp_name'].': '.lang('Picture type is not supported, sorry!');
            }

Looks like the file name has no extension.

[xenolevis]

I went and added case ‘application/octet-stream’ to the other png mime types, just to test functionality, and it works!
So it’s definitely a matter of $file[’‘type’] being application/octet-stream and $file[‘tmp_name’] not having an extension.

[RalfBecker]

Ok, used the wrong name, please try the following:

	function save_picture($file,$resource_id)
	{
		if ($file['type'] == 'application/octet-stream')
		{
			$file['type'] = Api\MimeMagic::filename2mime($file['name']);
		}
		switch($file['type'])
		{
			case 'image/gif':
				$src_img = imagecreatefromgif($file['tmp_name']);
				break;
			case 'image/jpeg':
			case 'image/pjpeg':
				$src_img = imagecreatefromjpeg($file['tmp_name']);
				break;
			case 'image/png':
			case 'image/x-png':
				$src_img = imagecreatefrompng($file['tmp_name']);
				break;
			default:
				return $file['type'].': '.lang('Picture type is not supported, sorry!');
		}

		$tmp_name = tempnam($GLOBALS['egw_info']['server']['temp_dir'],'resources-picture');
		imagejpeg($src_img,$tmp_name);
		imagedestroy($src_img);

		Link::attach_file('resources',$resource_id,array(
			'tmp_name' => $tmp_name,
			'name'     => self::PICTURE_NAME,
			'type'     => 'image/jpeg',
		));
	}

$file[‘name’] should contain the extension and now I make sure not to get into a recursion, if there is no extension.

Ralf

[xenolevis]

Fixed!
Thanks Ralf!

I’ll mark this as solved first thing tomorrow morning as right now I don’t remember my credentials on the forum

RalfBecker EGroupware GmbH
March 19
Ok, used the wrong name, please try the following:

> 	function save_picture($file,$resource_id) { if ($file['type'] == 'application/octet-stream') { $file['type'] = Api\MimeMagic::filename2mime($file['name']); } switch($file['type']) { case 'image/gif': $src_img = imagecreatefromgif($file['tmp_name']); break; case 'image/jpeg': case 'image/pjpeg': $src_img = imagecreatefromjpeg($file['tmp_name']); break; case 'image/png': case 'image/x-png': $src_img = imagecreatefrompng($file['tmp_name']); break; default: return $file['type'].': '.lang('Picture type is not supported, sorry!'); } $tmp_name = tempnam($GLOBALS['egw_info']['server']['temp_dir'],'resources-picture'); imagejpeg($src_img,$tmp_name); imagedestroy($src_img); Link::attach_file('resources',$resource_id,array( 'tmp_name' => $tmp_name, 'name' => self::PICTURE_NAME, 'type' => 'image/jpeg', )); }

[RalfBecker]

I don’t remember my credentials on the forum

There’s a password reset, if have not forgotten your email

[xenolevis]

It’s allright, this browser knows it.
Cheers Ralf!