Code which needs to get reworked #1

[Lars_Kneschke-2]

Hello!

While being on the hunt to find the ldap performance bottleneck, I stumbled
across addressbook/index.php.

This file is a very good example for wasted performance. We are including
header.inc.php(which means we are restoring the whole eGW environment) just
to redirect the user to another page after we have build up the environment.

Either we can redirect the user immediately to the right page, without
building up the enviroment or we can display the content directly without a
redirect.

Lars Kneschke
CTO OfficeSpot.Net
Metaways Infosystems GmbH
Pickhuben 2-4, D-20457 Hamburg

eGroupWare Support: http://www.egroupware-support.net
OfficeSpot.Net Collaboration Server: http://cs.officespot.net
our proposal for the next major eGroupWare release: http://www.tine20.org

E-Mail: mailto:l.kneschke@metaways.de
Web: http://www.metaways.de
Tel: +49 (0)40 317031-21
Fax: +49 (0)40 317031-921
Mobile: +49 (0)175 9304324

Metaways Infosystems GmbH - Sitz: D-22967 Tremsbüttel
Handelsregister: Amtsgericht Ahrensburg HRB 4508
Geschäftsführung: Hermann Thaele, Lüder-H.Thaele

[Raphael_Alla-2]

Hi Lars,

under the same topic, I can think of other areas which could be improved:

1. caching the menu generation. In most cases, the output html will be
   always the same for most of the ui, yet it is recreated from scratch
2. The same applies to etemplates. With the exception of the row repeat
   feature, these are mostly static and generated on the fly each time the
   script is called

Cheers

Raphaël

Hello!

While being on the hunt to find the ldap performance bottleneck, I
stumbled across addressbook/index.php.

This file is a very good example for wasted performance. We are including
header.inc.php(which means we are restoring the whole eGW environment)
just to redirect the user to another page after we have build up the
environment.

Either we can redirect the user immediately to the right page, without
building up the enviroment or we can display the content directly without a
redirect.

Lars Kneschke
CTO OfficeSpot.Net
Metaways Infosystems GmbH
Pickhuben 2-4, D-20457 Hamburg

eGroupWare Support: http://www.egroupware-support.net
OfficeSpot.Net Collaboration Server: http://cs.officespot.net
our proposal for the next major eGroupWare release: http://www.tine20.org

E-Mail: mailto:l.kneschke@metaways.de
Web: http://www.metaways.de
Tel: +49 (0)40 317031-21
Fax: +49 (0)40 317031-921
Mobile: +49 (0)175 9304324

Metaways Infosystems GmbH - Sitz: D-22967 Tremsbüttel
Handelsregister: Amtsgericht Ahrensburg HRB 4508
Geschäftsführung: Hermann Thaele, Lüder-H.Thaele

This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft® Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/

---

eGroupWare-developers mailing list
eGroupWare-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/egroupware-developers

–
Raphael Alla
Mitija Australia
+61 4 15 678 576
+687 78 86 86
http://www.mitija.com

[Lars_Kneschke-2]

“Raphael Alla” raphael.alla@gmail.com schrieb:

Hi Lars,

under the same topic, I can think of other areas which could be improved:

1. caching the menu generation. In most cases, the output html will be
   always the same for most of the ui, yet it is recreated from scratch
2. The same applies to etemplates. With the exception of the row repeat
   feature, these are mostly static and generated on the fly each time the
   script is called
   Yes. That’s right. Only the rows need to get rendered on demand.

For Tine 2.0 we are doing it the same way.

The layout of the screen is placed in the Javascript file, which got
executed by the client. And then in the next step, we add the data to a form
or the rows to a grid.

This way we have splited the basic user interface from the data to be
displayed.

Lars Kneschke
CTO OfficeSpot.Net
Metaways Infosystems GmbH
Pickhuben 2-4, D-20457 Hamburg

eGroupWare Support: http://www.egroupware-support.net
OfficeSpot.Net Collaboration Server: http://cs.officespot.net
our proposal for the next major eGroupWare release: http://www.tine20.org

E-Mail: mailto:l.kneschke@metaways.de
Web: http://www.metaways.de
Tel: +49 (0)40 317031-21
Fax: +49 (0)40 317031-921
Mobile: +49 (0)175 9304324

Metaways Infosystems GmbH - Sitz: D-22967 Tremsbüttel
Handelsregister: Amtsgericht Ahrensburg HRB 4508
Geschäftsführung: Hermann Thaele, Lüder-H.Thaele

---

This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft® Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/

---

eGroupWare-developers mailing list
eGroupWare-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/egroupware-developers