Hi all!
Ralf Becker schrieb:
So go ahead and fix it 
When I install from backup file in current trunk, I receive the
following message:
Warning: Missing argument 3 for db_backup::restore(), called in
/var/www/egroupware/setup/index.php on line 316 and defined in
/var/www/egroupware/phpgwapi/inc/class.db_backup.inc.php on line 340
Klaus, you have been a bit earlier with the core fix than me.
Actually, from the design of the restore function, I think that the
filename should rather not be a default=’’ optional parameter because if
the code forgets to set the file name, it will not be possible to perform
a zip based restore.
So I would propose to change the order of function arguments and remove
the “=’’” which makes the filename argument mandatory in all calls.
Furthermore, I propose to comment out the very noisy echo during restore
in class.db_backup.inc.php:435.
//echo “
$table_name => “.self::write_array($schema,1).”
\n”;
Should we add a define which can be used by developers to enable debugging?
Also, during restore, the printouts which omit some table entries look
like error messages, e.g. the message about “##last-check-run##” and
"exclude_tables" around line 470 ff… I would propose to add at least a
"lang(‘ok’)" somewhere in the context in order to avoid irritating admin
requests - or hide the messages in non-debug mode.
Best regards and have a nice weekend! Please keep me posted if any of
these places should be changed by myself.
Hans-Jürgen
Throughout its 18-year history, RSA Conference consistently attracts the
world’s best and brightest in the field, creating opportunities for Conference
attendees to learn about information security’s most important issues through
interactions with peers, luminaries and emerging and established companies.
http://p.sf.net/sfu/rsaconf-dev2dev
eGroupWare-developers mailing list
eGroupWare-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/egroupware-developers
