Debugging group managers loss in the admin module

egw-dev 2012-05-16 14:21:12 UTC #1

Hello the dev team,

When editing a group or the ACLs of a group, the managers for the said
groups are lost… This bug is corrected with the function set_members
in the accounts_sql as below…

phpgwapi\class.accounts_sql.inc.php

/**

Set the members of a group
@param array $members array with uidnumber or uid’s
@param int $gid gidnumber of group to set
*/
function set_members($members,$gid)
{
//echo “
accounts::set_members(”.print_r($members,true).",$gid)
\n";

// Spirea-YLF - may 2012 - Get the current rights on the group
$rights = $GLOBALS[‘egw’]->acl->get_all_rights($gid, ‘phpgw_group’);

$GLOBALS[‘egw’]->acl->delete_repository(‘phpgw_group’,$gid,false);

if (is_array($members))
{
foreach($members as $id)
{
// Spirea-YLF - may 2012 - Reset rights as they where before the update
// If no rights before => new user for this group => acl_right = 1
$acl_right = isset($rights[$id]) ? $rights[$id] : 1;

$GLOBALS[‘egw’]->acl->add_repository(‘phpgw_group’,$gid,$id,$acl_right);
// $GLOBALS[‘egw’]->acl->add_repository(‘phpgw_group’,$gid,$id,1);
}
}
}

Best regards,

–
Thomas Chaillot
Spirea
tel : 01 41 19 27 72
www : www.spirea.fr

Live Security Virtual Conference
Exclusive live event will cover all the ways today’s security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/

eGroupWare-developers mailing list
eGroupWare-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/egroupware-developers