eGroupware backup enhancement

Hans-Jurgen_Tappe 2009-07-17 18:49:29 UTC #1

Hi!

I would like to add a housekeeping mechanism to the backup mechanism,
which allows the following settings:

[ 0] Delete backups older after this number of days (0 for never).
[ 0] Keep at least this number of backup files in place.

The numbers could be any number (basically between 0 and 9999) with zero
as a default value for no automated housekeeping.
Are there plans for this feature or can I just add this? Is there a
chance to integrate this into trunk later? Are there any restrictions (in
addition to the usual eGroupware coding rules) which would need to be
taken into account?

For my installations, I would like to limit the number of backup files
without manually deleting them after a while…

Best regards,
Hans-Jürgen

Enter the BlackBerry Developer Challenge
This is your chance to win up to $100,000 in prizes! For a limited time,
vendors submitting new applications to BlackBerry App World™ will have
the opportunity to enter the BlackBerry Developer Challenge. See full prize
details at: http://p.sf.net/sfu/Challenge

eGroupWare-developers mailing list
eGroupWare-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/egroupware-developers

Ralf_Becker_6 2009-07-18 07:26:09 UTC #2

Hi Hans-Jürgen,

Hans-Juergen Tappe schrieb:

Hi!

I would like to add a housekeeping mechanism to the backup mechanism,
which allows the following settings:

[ 0] Delete backups older after this number of days (0 for never).
[ 0] Keep at least this number of backup files in place.

I would prefer to have only a single option for that, an with a
reasonable default eg. 30 days.

The numbers could be any number (basically between 0 and 9999) with zero
as a default value for no automated housekeeping.
Are there plans for this feature or can I just add this? Is there a
chance to integrate this into trunk later? Are there any restrictions (in
addition to the usual eGroupware coding rules) which would need to be
taken into account?

Nope go ahead and implement it. I will commit it to trunk.

Ralf

For my installations, I would like to limit the number of backup files
without manually deleting them after a while…

Best regards,
Hans-Jürgen

–
Ralf Becker
Director Software Development

Stylite GmbH
[open style of IT]

Morschheimer Strasse 15
67292 Kirchheimbolanden

fon +49 (0) 6352 70629-0
fax +49 (0) 6352 70629-30
mailto: rb@stylite.de

www.stylite.de
www.egroupware.org

Geschäftsführer Andre Keller, Gudrun Müller,
Nigel Vickers und Ralf Becker
Registergericht Kaiserslautern HRB 30575
Umsatzsteuer-Id / VAT-Id: DE214280951

eGroupWare-developers mailing list
eGroupWare-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/egroupware-developers

Hans-Jurgen_Tappe 2009-07-29 21:23:04 UTC #3

Hi Ralf!

Ralf Becker schrieb:

I would like to add a housekeeping mechanism to the backup mechanism,
which allows the following settings:
[ 0] Delete backups older after this number of days (0 for never).
[ 0] Keep at least this number of backup files in place.
I would prefer to have only a single option for that, an with a
reasonable default eg. 30 days.

Please advise, what’s your concern? Is it session data, maintainability
or general usability?
The patch now has both options but I could easily remove the “minimum
number to keep” option. It would not hurt to keep only the “minimum
livetime” - except for the cases where the async or cron job failed and
the backup storage would decrease to zero without further notice…

I’ve put the patch against trunk into the tracker:
2197 Patches Admin
Just have a look and advise.

Best regards,
Hans-Jürgen

Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify your report design, integration and deployment - and focus on
what you do best, core application coding. Discover what’s new with
Crystal Reports now. http://p.sf.net/sfu/bobj-july

eGroupWare-developers mailing list
eGroupWare-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/egroupware-developers

Ralf_Becker_6 2009-07-30 06:13:45 UTC #4

Hi Hans-Jürgen,

Hans-Juergen Tappe schrieb:

Hi Ralf!

Ralf Becker schrieb:

I would like to add a housekeeping mechanism to the backup mechanism,
which allows the following settings:
[ 0] Delete backups older after this number of days (0 for never).
[ 0] Keep at least this number of backup files in place.
I would prefer to have only a single option for that, an with a
reasonable default eg. 30 days.

Please advise, what’s your concern? Is it session data, maintainability
or general usability?

Simply the fact that EGroupware already has far to many options

Every single one has it’s meaning and reasoning, the total sum is to
much for our average admin. That’s why I would prefer a single option,
like “How many backups do you want to keep (default 30)”.

The patch now has both options but I could easily remove the “minimum
number to keep” option. It would not hurt to keep only the “minimum
livetime” - except for the cases where the async or cron job failed and
the backup storage would decrease to zero without further notice…

To add that logic makes sense, I only think it does not need a second
option for it.

I’ve put the patch against trunk into the tracker:
2197 Patches Admin
Just have a look and advise.

You made many useful patches for EGroupware: What do you think about
joining the team?

Ralf

Ralf Becker
Director Software Development

Stylite GmbH
[open style of IT]

Morschheimer Strasse 15
67292 Kirchheimbolanden

fon +49 (0) 6352 70629-0
fax +49 (0) 6352 70629-30
mailto: rb@stylite.de

www.stylite.de
www.egroupware.org

Geschäftsführer Andre Keller, Gudrun Müller,
Nigel Vickers und Ralf Becker
Registergericht Kaiserslautern HRB 30575
Umsatzsteuer-Id / VAT-Id: DE214280951

eGroupWare-developers mailing list
eGroupWare-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/egroupware-developers

Hans-Jurgen_Tappe 2009-07-31 19:18:22 UTC #5

Hi!

Ralf Becker schrieb:

Please advise, what’s your concern? Is it session data, maintainability
or general usability?
Simply the fact that EGroupware already has far to many options

OK, I agree. Don’t provoke too much “how do I” questions.

Every single one has it’s meaning and reasoning, the total sum is to
much for our average admin. That’s why I would prefer a single option,
like “How many backups do you want to keep (default 30)”.

I modified the patch to only the "How many backups do you want to keep"
option. Still, I left the default value at zero (disabled) because I
don’t want to decide on the other admin’s backup strategy…
BTW: Currently, the value is restricted to max. 999.

The patch now has both options but I could easily remove the “minimum
number to keep” option. It would not hurt to keep only the “minimum
livetime” - except for the cases where the async or cron job failed and
the backup storage would decrease to zero without further notice…
To add that logic makes sense, I only think it does not need a second
option for it.

Right, I modified the patch to only perform the cleanup on successful
backups.

I’ve put the patch against trunk into the tracker:
2197 Patches Admin

The updated patch is attached to the tracker item.

Best regards,
Hans-Jürgen

eGroupWare-developers mailing list
eGroupWare-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/egroupware-developers