Email Notification in Tracker 1.6

CLorenzo-2 2009-11-05 11:04:40 UTC #1

Hi.

I have already opened a bug regarding this, but I think that I can solve this with a little help from any developer

I have noticed that the tracker email notifications have a less meaningful subject than in 1.4

In 1.4 the email subject was :

Tracker Queue - Tracker ID: Tracker subject

in 1.6 and trunk is:

Tracker ID - Tracker subject

so is not including the tracker queue!!!

I have localiced the proper code in class.tracker_tracking.inc.php on line 116 function get_subect

this function do not retunr the tracker queue name I have try to add it but my knowledge of php is almost null

I think this could be added as we have the tracker queue id in tr_tracker (I I understanded the code), the only that I need to know is how I can retrieve the Tracker Queue name with this tr_tracker which function could I use or how to construct the sentence that will return the queue name in order to be appended at the begining of the return sentence.

Many Thanks

Oscar_van_Eijk-3 2009-11-05 11:19:12 UTC #2

Hi,

You don’t need to retrieve the tracked since it’s already there.
Changing line 116 from:
return ‘#’.$data[‘tr_id’].’ - ‘.$data[‘tr_summary’];
to:
return $data[‘tr_tracker’].’ - ‘.$data[‘tr_id’].’: '.$data[‘tr_summary’];
will change the subject back to what it was in 1.4.

Keep in mind however this subject is also used by the mailhandler module; if
you enabled that, the module might not be able to recognize replies on
existing tickets and create a new one for all incoming mails.

I’m not sure why the subject layout was changed but; I might create a config
option for that.

Oscar

----------------originele bericht-----------------

CLorenzo-2 2009-11-05 12:31:02 UTC #3

Hi Oscar.

Many thanks for your helo.

tt_oscar wrote:

Hi,

You don’t need to retrieve the tracked since it’s already there.
Changing line 116 from:
return ‘#’.$data[‘tr_id’].’ - ‘.$data[‘tr_summary’];
to:
return $data[‘tr_tracker’].’ - ‘.$data[‘tr_id’].’: '.$data[‘tr_summary’];
will change the subject back to what it was in 1.4.

I already have tested this, but this gives me the Number or ID of the
tracker queue and Not the tracker Queue name, so I need to use this Tracker
queue ID to retrieve his name.

tt_oscar wrote:

Keep in mind however this subject is also used by the mailhandler module;
if
you enabled that, the module might not be able to recognize replies on
existing tickets and create a new one for all incoming mails.

I’m not sure why the subject layout was changed but; I might create a
config
option for that.

We don’t plan to use this feature, but Is good to know this. (Perhaps we can
place the Queue name after the tr_id to don’t break this

Thanks again

–
View this message in context: http://old.nabble.com/email-Notification-in-Tracker-1.6-tp26211159s3741p26213628.html

Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify your report design, integration and deployment - and focus on
what you do best, core application coding. Discover what’s new with
Crystal Reports now. http://p.sf.net/sfu/bobj-july

eGroupWare-developers mailing list
eGroupWare-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/egroupware-developers

CLorenzo-2 2009-11-05 12:31:15 UTC #4

Hi Oscar.

Many thanks for your help.

I already have tested this, but this gives me the Number or ID of the tracker queue and Not the tracker Queue name, so I need to use this Tracker queue ID to retrieve his name.

We don’t plan to use this feature, but Is good to know this. (Perhaps we can place the Queue name after the tr_id to don’t break this

Thanks again

Ralf_Becker_6 2009-11-05 12:44:00 UTC #5

Hi Oscar,

if we keep the hash in front of the number, the mailhandler should work.

I suggest we simply re-adding the queue in all branches:

return $data[‘tr_tracker’].’ #’.$data[‘tr_id’].’: '.$data[‘tr_summary’];

Ralf

Oscar van Eijk schrieb:

Hi,

You don’t need to retrieve the tracked since it’s already there.
Changing line 116 from:
return ‘#’.$data[‘tr_id’].’ - ‘.$data[‘tr_summary’];
to:
return $data[‘tr_tracker’].’ - ‘.$data[‘tr_id’].’: '.$data[‘tr_summary’];
will change the subject back to what it was in 1.4.

Keep in mind however this subject is also used by the mailhandler module; if
you enabled that, the module might not be able to recognize replies on
existing tickets and create a new one for all incoming mails.

I’m not sure why the subject layout was changed but; I might create a config
option for that.

Oscar

----------------originele bericht-----------------
Van: “clorenzo” clmates@mundo-r.com
Aan: egroupware-developers@lists.sourceforge.net
Datum: Thu, 5 Nov 2009 03:04:41 -0800 (PST)

Hi.

I have already opened a bug regarding this, but I think that I can solve
this with a little help from any developer

I have noticed that the tracker email notifications have a less meaningful
subject than in 1.4

In 1.4 the email subject was :

Tracker Queue - Tracker ID: Tracker subject

in 1.6 and trunk is:

Tracker ID - Tracker subject

so is not including the tracker queue!!!

I have localiced the proper code in class.tracker_tracking.inc.php on line
116 function get_subect

this function do not retunr the tracker queue name I have try to add it
but
my knowledge of php is almost null

I think this could be added as we have the tracker queue id in tr_tracker
(I
I understanded the code), the only that I need to know is how I can
retrieve
the Tracker Queue name with this tr_tracker which function could I use or
how to construct the sentence that will return the queue name in order to
be
appended at the begining of the return sentence.

Many Thanks

–
View this message in context:
http://old.nabble.com/email-Notification-in-Tracker-1.6-tp26211159s3
741p26211159.html
Sent from the egroupware-developers mailing list archive at Nabble.com.

Let Crystal Reports handle the reporting - Free Crystal Reports 2008
30-Day
trial. Simplify your report design, integration and deployment - and focus
on
what you do best, core application coding. Discover what’s new with
Crystal Reports now. http://p.sf.net/sfu/bobj-july

eGroupWare-developers mailing list
eGroupWare-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/egroupware-developers

–
Ralf Becker
Director Software Development

Stylite GmbH
[open style of IT]

Morschheimer Strasse 15
67292 Kirchheimbolanden

fon +49 (0) 6352 70629-0
fax +49 (0) 6352 70629-30
mailto: rb@stylite.de

www.stylite.de
www.egroupware.org

Geschäftsführer Andre Keller,
Gudrun Müller, Ralf Becker
Registergericht Kaiserslautern HRB 30575
Umsatzsteuer-Id / VAT-Id: DE214280951

eGroupWare-developers mailing list
eGroupWare-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/egroupware-developers

Oscar_van_Eijk-3 2009-11-05 13:20:50 UTC #6

Ralf,

Sounds good to me. It makes sense to have the trackerqueue in the subject.
Looking at the mailhandler, the hash is required indeed, with a leading
blank, a colon is optional. A trailing blank is also required, both in Trunk
and 1.6, so no problems there.

Oscar

----------------originele bericht-----------------
egroupware-developers@lists.sourceforge.net

Hi Oscar,

if we keep the hash in front of the number, the mailhandler should work.

I suggest we simply re-adding the queue in all branches:

return $data[‘tr_tracker’].’ #’.$data[‘tr_id’].’:
’.$data[‘tr_summary’];

Ralf

Oscar van Eijk schrieb:

Hi,

You don’t need to retrieve the tracked since it’s already there.
Changing line 116 from:
return ‘#’.$data[‘tr_id’].’ - ‘.$data[‘tr_summary’];
to:
return $data[‘tr_tracker’].’ - ‘.$data[‘tr_id’].’:
’.$data[‘tr_summary’];
will change the subject back to what it was in 1.4.

Keep in mind however this subject is also used by the mailhandler module;
if

you enabled that, the module might not be able to recognize replies on
existing tickets and create a new one for all incoming mails.

I’m not sure why the subject layout was changed but; I might create a
config

option for that.

Oscar

----------------originele bericht-----------------
Van: “clorenzo” clmates@mundo-r.com
Aan: egroupware-developers@lists.sourceforge.net
Datum: Thu, 5 Nov 2009 03:04:41 -0800 (PST)

Hi.

I have already opened a bug regarding this, but I think that I can solve
this with a little help from any developer

I have noticed that the tracker email notifications have a less
meaningful
subject than in 1.4

In 1.4 the email subject was :

Tracker Queue - Tracker ID: Tracker subject

in 1.6 and trunk is:

Tracker ID - Tracker subject

so is not including the tracker queue!!!

I have localiced the proper code in class.tracker_tracking.inc.php on
line
116 function get_subect

this function do not retunr the tracker queue name I have try to add it
but
my knowledge of php is almost null

I think this could be added as we have the tracker queue id in
tr_tracker

(I

I understanded the code), the only that I need to know is how I can
retrieve
the Tracker Queue name with this tr_tracker which function could I use
or

how to construct the sentence that will return the queue name in order
to

be

appended at the begining of the return sentence.

Many Thanks

–
View this message in context:

http://old.nabble.com/email-Notification-in-Tracker-1.6-tp262111
59s3
741p26211159.html
Sent from the egroupware-developers mailing list archive at
Nabble.com.

Let Crystal Reports handle the reporting - Free Crystal Reports 2008
30-Day
trial. Simplify your report design, integration and deployment - and
focus
on
what you do best, core application coding. Discover what’s new with
Crystal Reports now. http://p.sf.net/sfu/bobj-july

eGroupWare-developers mailing list
eGroupWare-developers@lists.sourceforge.net

https://lists.sourceforge.net/lists/listinfo/egroupware-develope
rs

–
Ralf Becker
Director Software Development

Stylite GmbH
[open style of IT]

Morschheimer Strasse 15
67292 Kirchheimbolanden

fon +49 (0) 6352 70629-0
fax +49 (0) 6352 70629-30
mailto: rb@stylite.de

www.stylite.de
www.egroupware.org

Geschäftsführer Andre Keller,
Gudrun Müller, Ralf Becker
Registergericht Kaiserslautern HRB 30575
Umsatzsteuer-Id / VAT-Id: DE214280951

Let Crystal Reports handle the reporting - Free Crystal Reports 2008
30-Day
trial. Simplify your report design, integration and deployment - and focus
on
what you do best, core application coding. Discover what’s new with
Crystal Reports now. http://p.sf.net/sfu/bobj-july

eGroupWare-developers mailing list
eGroupWare-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/egroupware-developers

–

Oscar van Eijk

Oveas Functionality Provider
Zwaardenburg 63 – 3437 RJ Nieuwegein
T: +31(0)30 - 889 7812 – F: +31(0)30 - 889 9117
[http://oveas.com – info@oveas.com ->
http://oveas.com]

eGroupWare-developers mailing list
eGroupWare-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/egroupware-developers

CLorenzo-2 2009-11-05 13:28:51 UTC #7

Hi Ralf.

As I said to Oscar this will only add the Queue internal ID and not the Queue name, we need to use $data[‘tr_tracker’] to retrieve the queue name, that is what I need to know how.

Thanks

Oscar_van_Eijk-3 2009-11-06 11:06:42 UTC #8

Changed in trunk and 1.6.

Ralf,

Sounds good to me. It makes sense to have the trackerqueue in the subject.
Looking at the mailhandler, the hash is required indeed, with a leading
blank, a colon is optional. A trailing blank is also required, both in Trunk
and 1.6, so no problems there.

Oscar

----------------originele bericht-----------------
Van: “Ralf Becker” rb@stylite.de
Aan: "development of eGroupWare,\for active developers"
egroupware-developers@lists.sourceforge.net
Datum: Thu, 05 Nov 2009 13:44:00 +0100

Hi Oscar,

if we keep the hash in front of the number, the mailhandler should work.

I suggest we simply re-adding the queue in all branches:

return $data[‘tr_tracker’].’ #’.$data[‘tr_id’].’:
’.$data[‘tr_summary’];

Ralf

Oscar van Eijk schrieb:

Hi,

You don’t need to retrieve the tracked since it’s already there.
Changing line 116 from:
return ‘#’.$data[‘tr_id’].’ - ‘.$data[‘tr_summary’];
to:
return $data[‘tr_tracker’].’ - ‘.$data[‘tr_id’].’:
’.$data[‘tr_summary’];
will change the subject back to what it was in 1.4.

Keep in mind however this subject is also used by the mailhandler module;
if

you enabled that, the module might not be able to recognize replies on
existing tickets and create a new one for all incoming mails.

I’m not sure why the subject layout was changed but; I might create a
config

option for that.

Oscar

----------------originele bericht-----------------
Van: “clorenzo” clmates@mundo-r.com
Aan: egroupware-developers@lists.sourceforge.net
Datum: Thu, 5 Nov 2009 03:04:41 -0800 (PST)

Hi.

I have already opened a bug regarding this, but I think that I can solve
this with a little help from any developer

I have noticed that the tracker email notifications have a less
meaningful
subject than in 1.4

In 1.4 the email subject was :

Tracker Queue - Tracker ID: Tracker subject

in 1.6 and trunk is:

Tracker ID - Tracker subject

so is not including the tracker queue!!!

I have localiced the proper code in class.tracker_tracking.inc.php on
line
116 function get_subect

this function do not retunr the tracker queue name I have try to add it
but
my knowledge of php is almost null

I think this could be added as we have the tracker queue id in
tr_tracker

(I

I understanded the code), the only that I need to know is how I can
retrieve
the Tracker Queue name with this tr_tracker which function could I use
or

how to construct the sentence that will return the queue name in order
to

be

appended at the begining of the return sentence.

Many Thanks

–
View this message in context:

http://old.nabble.com/email-Notification-in-Tracker-1.6-tp262111
59s3
741p26211159.html
Sent from the egroupware-developers mailing list archive at
Nabble.com.

Let Crystal Reports handle the reporting - Free Crystal Reports 2008
30-Day
trial. Simplify your report design, integration and deployment - and
focus
on
what you do best, core application coding. Discover what’s new with
Crystal Reports now. http://p.sf.net/sfu/bobj-july

eGroupWare-developers mailing list
eGroupWare-developers@lists.sourceforge.net

https://lists.sourceforge.net/lists/listinfo/egroupware-develope
rs

–
Ralf Becker
Director Software Development

Stylite GmbH
[open style of IT]

Morschheimer Strasse 15
67292 Kirchheimbolanden

fon +49 (0) 6352 70629-0
fax +49 (0) 6352 70629-30
mailto: rb@stylite.de

www.stylite.de
www.egroupware.org

GeschÃ¤ftsfÃ¼hrer Andre Keller,
Gudrun MÃ¼ller, Ralf Becker
Registergericht Kaiserslautern HRB 30575
Umsatzsteuer-Id / VAT-Id: DE214280951

Let Crystal Reports handle the reporting - Free Crystal Reports 2008
30-Day
trial. Simplify your report design, integration and deployment - and focus
on
what you do best, core application coding. Discover what’s new with
Crystal Reports now. http://p.sf.net/sfu/bobj-july

eGroupWare-developers mailing list
eGroupWare-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/egroupware-developers

Oscar van Eijk

Oveas Functionality Provider
Zwaardenburg 63 – 3437 RJ Nieuwegein
T: +31(0)30 - 889 7812 – F: +31(0)30 - 889 9117
http://oveas.com – mailto:info@oveas.com

Oveas Functionality Provider

CLorenzo-2 2009-11-06 11:13:50 UTC #9

Hi Oscar.

tt_oscar wrote:

Changed in trunk and 1.6.

Did you read my post that adding only $data[‘tr_tracker’] only adds the
internal tracker ID of the queue and not the tracker queue name?

Thanks

–
View this message in context: http://old.nabble.com/email-Notification-in-Tracker-1.6-tp26211159s3741p26230256.html

eGroupWare-developers mailing list
eGroupWare-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/egroupware-developers

Oscar_van_Eijk-3 2009-11-06 11:35:57 UTC #10

Yep, I dir; it $data[‘tr_tracker’] should be
$this->tracker->trackers[$data[‘tr_tracker’]]; and that’s what I
added

Hi Oscar.

tt_oscar wrote:

Changed in trunk and 1.6.

Did you read my post that adding only $data[‘tr_tracker’] only adds the
internal tracker ID of the queue and not the tracker queue name?

Thanks

Oscar van Eijk

Oveas Functionality Provider
Zwaardenburg 63 – 3437 RJ Nieuwegein
T: +31(0)30 - 889 7812 – F: +31(0)30 - 889 9117
http://oveas.com – mailto:info@oveas.com

Oveas Functionality Provider