Error with egw 14.1 on postgresql 9.2.3 email composition

[Thomas_Raschbacher]

Hi.

I just upgraded to 14.1

When trying to compose a new Email i get this error:

Invalid SQL: SELECT egw_ea_identities.ident_id AS
ident_id,ident_name,ident_realname,ident_org,ident_email,egw_ea_identities.acc_id
AS acc_id,egw_ea_credentials.cred_username AS
acc_imap_username,acc_imap_logintype,acc_domain FROM egw_ea_identities
JOIN egw_ea_accounts ON egw_ea_accounts.acc_id=egw_ea_identities.acc_id
LEFT JOIN egw_ea_credentials ON
egw_ea_accounts.acc_id=egw_ea_credentials.acc_id AND
egw_ea_credentials.account_id=5 AND cred_type&1 WHERE
egw_ea_identities.account_id IN (-2,-7,-1,5,0) AND
egw_ea_identities.acc_id=3 ORDER BY
egw_ea_identities.account_id,ident_realname,ident_org,ident_email
ERROR: argument of AND must be type boolean, not type integer
LINE 1: …ls.acc_id AND egw_ea_credentials.account_id=5 AND
cred_type&…
^ (-1)

I assume it is related to this:

http://svn.stylite.de/viewvc/egroupware/trunk/emailadmin/inc/class.emailadmin_credentials.inc.php?r1=44570&r2=44693&pathrev=44693

Unfortunately I am not sure how to find this point in the source but I
am sure someone familiar with the source can easily find this

Regards,
Thomas Raschbacher

P.S.: I would appreciate a CC to my email address as I do not remember
to check the imap folder for this list too often

---

Slashdot TV.
Video for Nerds. Stuff that matters.
http://tv.slashdot.org/

---

eGroupWare-developers mailing list
eGroupWare-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/egroupware-developers

[Thomas_Raschbacher]

Hi.

I just upgraded to 14.1

When trying to compose a new Email i get this error:

Invalid SQL: SELECT egw_ea_identities.ident_id AS
ident_id,ident_name,ident_realname,ident_org,ident_email,egw_ea_identities.acc_id
AS acc_id,egw_ea_credentials.cred_username AS
acc_imap_username,acc_imap_logintype,acc_domain FROM egw_ea_identities
JOIN egw_ea_accounts ON egw_ea_accounts.acc_id=egw_ea_identities.acc_id
LEFT JOIN egw_ea_credentials ON
egw_ea_accounts.acc_id=egw_ea_credentials.acc_id AND
egw_ea_credentials.account_id=5 AND cred_type&1 WHERE
egw_ea_identities.account_id IN (-2,-7,-1,5,0) AND
egw_ea_identities.acc_id=3 ORDER BY
egw_ea_identities.account_id,ident_realname,ident_org,ident_email
ERROR: argument of AND must be type boolean, not type integer
LINE 1: …ls.acc_id AND egw_ea_credentials.account_id=5 AND
cred_type&…
^ (-1)

I assume it is related to this:

http://svn.stylite.de/viewvc/egroupware/trunk/emailadmin/inc/class.emailadmin_credentials.inc.php?r1=44570&r2=44693&pathrev=44693

Unfortunately I am not sure how to find this point in the source but I
am sure someone familiar with the source can easily find this

Regards,
Thomas Raschbacher

P.S.: I would appreciate a CC to my email address as I do not remember
to check the imap folder for this list too often

I forgot the working SQL earlier (figured that out from the linked
patch):

SELECT egw_ea_identities.ident_id AS
ident_id,ident_name,ident_realname,ident_org,ident_email,egw_ea_identities.acc_id
AS acc_id,egw_ea_credentials.cred_username AS
acc_imap_username,acc_imap_logintype,acc_domain FROM egw_ea_identities
JOIN egw_ea_accounts ON egw_ea_accounts.acc_id=egw_ea_identities.acc_id
LEFT JOIN egw_ea_credentials ON
egw_ea_accounts.acc_id=egw_ea_credentials.acc_id AND
egw_ea_credentials.account_id=5 AND (cred_type&1)>0 WHERE
egw_ea_identities.account_id IN (-2,-7,-1,5,0) AND
egw_ea_identities.acc_id=3 ORDER BY
egw_ea_identities.account_id,ident_realname,ident_org,ident_email;

Regards

---

Slashdot TV.
Video for Nerds. Stuff that matters.
http://tv.slashdot.org/

---

eGroupWare-developers mailing list
eGroupWare-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/egroupware-developers

[Ralf_Becker_Stylite]

Hi Thomas,

this bug has been fixed 8 month ago, you are not using up to date 14.1
packages!

Ralf

Hi.

I just upgraded to 14.1

When trying to compose a new Email i get this error:

Invalid SQL: SELECT egw_ea_identities.ident_id AS
ident_id,ident_name,ident_realname,ident_org,ident_email,egw_ea_identities.acc_id
AS acc_id,egw_ea_credentials.cred_username AS
acc_imap_username,acc_imap_logintype,acc_domain FROM egw_ea_identities
JOIN egw_ea_accounts ON egw_ea_accounts.acc_id=egw_ea_identities.acc_id
LEFT JOIN egw_ea_credentials ON
egw_ea_accounts.acc_id=egw_ea_credentials.acc_id AND
egw_ea_credentials.account_id=5 AND cred_type&1 WHERE
egw_ea_identities.account_id IN (-2,-7,-1,5,0) AND
egw_ea_identities.acc_id=3 ORDER BY
egw_ea_identities.account_id,ident_realname,ident_org,ident_email
ERROR: argument of AND must be type boolean, not type integer
LINE 1: …ls.acc_id AND egw_ea_credentials.account_id=5 AND
cred_type&…
^ (-1)

I assume it is related to this:

http://svn.stylite.de/viewvc/egroupware/trunk/emailadmin/inc/class.emailadmin_credentials.inc.php?r1=44570&r2=44693&pathrev=44693

Unfortunately I am not sure how to find this point in the source but I
am sure someone familiar with the source can easily find this

Regards,
Thomas Raschbacher

P.S.: I would appreciate a CC to my email address as I do not remember
to check the imap folder for this list too often

---

Slashdot TV.
Video for Nerds. Stuff that matters.
http://tv.slashdot.org/

---

eGroupWare-developers mailing list
eGroupWare-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/egroupware-developers

–
Ralf Becker
Director Software Development

Stylite AG

Morschheimer Strasse 15 | Tel. +49 6352 70629 0
D-67292 Kirchheimbolanden | Fax. +49 6352 70629 30

Email: rb@stylite.de

www.stylite.de | www.egroupware.org

Managing Directors: Andre Keller | Ralf Becker | Gudrun Mueller
Chairman of the supervisory board: Prof. Dr. Birger Leon Kropshofer

VAT DE214280951 | Registered HRB 31158 Kaiserslautern Germany

[Thomas_Raschbacher]

Hi Thomas,

this bug has been fixed 8 month ago, you are not using up to date 14.1
packages!

Ralf

Hi.

that is very odd, I downloaded these files from sourceforge (
http://sourceforge.net/projects/egroupware/files/eGroupware-14.1/eGroupware-14.1.20140812/
):

with sha1sums:
7e3d0b28529435df13d373efe4e893d7c1649840
egroupware-epl-14.1.20140812.zip
f8a32e2b8adbd1bcdfb940a26b97e36632367c4a
egroupware-epl-jdots-14.1.20140812.tar.gz
a7d72a4098be9a301e71b10e2cda164d7d4b2b11
egroupware-epl-egw-pear-14.1.20140812.tar.bz2
887e857be372d82be2cdd47a196ba487321ec773
egroupware-epl-pixelegg-14.1.20140812.tar.bz2

That should be the latest version shouldn’t it?

Regards

---

Slashdot TV.
Video for Nerds. Stuff that matters.
http://tv.slashdot.org/

---

eGroupWare-developers mailing list
eGroupWare-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/egroupware-developers

[Ralf_Becker_Stylite]

Hi Thomas,

Hi Thomas,

this bug has been fixed 8 month ago, you are not using up to date 14.1
packages!

Ralf
Hi.

that is very odd, I downloaded these files from sourceforge (
http://sourceforge.net/projects/egroupware/files/eGroupware-14.1/eGroupware-14.1.20140812/
):

with sha1sums:
7e3d0b28529435df13d373efe4e893d7c1649840
egroupware-epl-14.1.20140812.zip
Just downloaded that archive again and had a look at file
emailadmin/inc/class.emailadmin_credentials.inc.php:

            '(cred_type & '.(int)$type.') > 0',    // postgreSQL

require > 0, or gives error as it expects boolean

This looks ok to me.

I think you might made a mistake unpacking the archive and still use an
older version.

Our recommendation is NOT to use archives but rpm or deb packages.

Ralf

f8a32e2b8adbd1bcdfb940a26b97e36632367c4a
egroupware-epl-jdots-14.1.20140812.tar.gz
a7d72a4098be9a301e71b10e2cda164d7d4b2b11
egroupware-epl-egw-pear-14.1.20140812.tar.bz2
887e857be372d82be2cdd47a196ba487321ec773
egroupware-epl-pixelegg-14.1.20140812.tar.bz2

That should be the latest version shouldn’t it?

Regards

–
Ralf Becker
Director Software Development

Stylite AG

Morschheimer Strasse 15 | Tel. +49 6352 70629 0
D-67292 Kirchheimbolanden | Fax. +49 6352 70629 30

Email: rb@stylite.de

www.stylite.de | www.egroupware.org

Managing Directors: Andre Keller | Ralf Becker | Gudrun Mueller
Chairman of the supervisory board: Prof. Dr. Birger Leon Kropshofer

VAT DE214280951 | Registered HRB 31158 Kaiserslautern Germany

[Thomas_Raschbacher]

This is very strange.

I have those lines: #grep -n cred_type
htdocs/egroupware/emailadmin/inc/class.emailadmin_credentials.inc.php
120: ‘(cred_type & ‘.(int)$type.’) > 0’,
// postgreSQL require > 0, or gives error as it expects boolean
130: // flatten account_id => cred_type => row array
again, to have format like from database
140:
self::$cache[$acc_id][$row[‘account_id’]][$row[‘cred_type’]] = $row;
147: if ($row[‘cred_type’] & $pattern)
241: ‘cred_type’ => $type,
254: ‘cred_type’ => $type,
282: if ($type != self::ALL) $where[] = ‘(cred_type &
’.(int)$type.’) > 0’; // postgreSQL require > 0, or gives error as it
expects boolean
378: self::write($row[‘acc_id’],
$row[‘cred_username’], $password, $row[‘cred_type’],

so that looks alright…
– also I did move my whole old egroupware 1.8 directory somewhere else
and just copied header.inc.php from it to the newly extracted one …

also my error is in email composing not emailadmin. could this not be
some other issue there?

Regards

Hi Thomas,

Hi Thomas,

this bug has been fixed 8 month ago, you are not using up to date
14.1
packages!

Ralf
Hi.

that is very odd, I downloaded these files from sourceforge (
http://sourceforge.net/projects/egroupware/files/eGroupware-14.1/eGroupware-14.1.20140812/
):

with sha1sums:
7e3d0b28529435df13d373efe4e893d7c1649840
egroupware-epl-14.1.20140812.zip
Just downloaded that archive again and had a look at file
emailadmin/inc/class.emailadmin_credentials.inc.php:

            '(cred_type & '.(int)$type.') > 0',    // postgreSQL

require > 0, or gives error as it expects boolean

This looks ok to me.

I think you might made a mistake unpacking the archive and still use an
older version.

Our recommendation is NOT to use archives but rpm or deb packages.

Ralf

f8a32e2b8adbd1bcdfb940a26b97e36632367c4a
egroupware-epl-jdots-14.1.20140812.tar.gz
a7d72a4098be9a301e71b10e2cda164d7d4b2b11
egroupware-epl-egw-pear-14.1.20140812.tar.bz2
887e857be372d82be2cdd47a196ba487321ec773
egroupware-epl-pixelegg-14.1.20140812.tar.bz2

That should be the latest version shouldn’t it?

Regards

–
Ralf Becker
Director Software Development

Stylite AG

Morschheimer Strasse 15 | Tel. +49 6352 70629 0
D-67292 Kirchheimbolanden | Fax. +49 6352 70629 30

Email: rb@stylite.de

www.stylite.de | www.egroupware.org

Managing Directors: Andre Keller | Ralf Becker | Gudrun Mueller
Chairman of the supervisory board: Prof. Dr. Birger Leon Kropshofer

VAT DE214280951 | Registered HRB 31158 Kaiserslautern Germany

---

Slashdot TV.
Video for Nerds. Stuff that matters.
http://tv.slashdot.org/

---

eGroupWare-developers mailing list
eGroupWare-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/egroupware-developers

---

Slashdot TV.
Video for Nerds. Stuff that matters.
http://tv.slashdot.org/

---

eGroupWare-developers mailing list
eGroupWare-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/egroupware-developers

[Thomas_Raschbacher]

Actually I just found it I had an idea how to find it and did.
The SQL code is similar to the one in the file you mentioned.

What I did was this:

class.emailadmin_account.inc.php:459

I changed
’cred_type&’.emailadmin_credentials::IMAP);

to
’(cred_type&’.emailadmin_credentials::IMAP.’) > 0’);

similar to what you did with the other file and now it works.

I now get a compose window and sending a test email worked too (the
compose windows did not close after sending but i did receive it on my
gmail account).

Please let me know if you think what I did is correct (the SQL generated
to the other issue that was fixed 8 months ago is similar but not the
same so I applied the same changes.

Regards

---

Slashdot TV.
Video for Nerds. Stuff that matters.
http://tv.slashdot.org/

---

eGroupWare-developers mailing list
eGroupWare-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/egroupware-developers

[Ralf_Becker_Stylite]

Hi Thomas,

Actually I just found it I had an idea how to find it and did.
The SQL code is similar to the one in the file you mentioned.

What I did was this:

class.emailadmin_account.inc.php:459

I changed
’cred_type&’.emailadmin_credentials::IMAP);

to
’(cred_type&’.emailadmin_credentials::IMAP.’) > 0’);

similar to what you did with the other file and now it works.

I now get a compose window and sending a test email worked too (the
compose windows did not close after sending but i did receive it on my
gmail account).

Please let me know if you think what I did is correct (the SQL generated
to the other issue that was fixed 8 months ago is similar but not the
same so I applied the same changes.
Good catch, commited it to Trunk and 14.1. It will be in todays 14.1
packages.

Ralf

–
Ralf Becker
Director Software Development

Stylite AG

Morschheimer Strasse 15 | Tel. +49 6352 70629 0
D-67292 Kirchheimbolanden | Fax. +49 6352 70629 30

Email: rb@stylite.de

www.stylite.de | www.egroupware.org

Managing Directors: Andre Keller | Ralf Becker | Gudrun Mueller
Chairman of the supervisory board: Prof. Dr. Birger Leon Kropshofer

VAT DE214280951 | Registered HRB 31158 Kaiserslautern Germany