Etemplate egw_link::titles() error

[paulr00001]

On deleting multiple infologs, after successfully deleting, I get this error:
"
An error happened

Argument 2 passed to egw_link::titles() must be an array, null given, called in /var/www/egroupware/etemplate/inc/class.etemplate_widget_link.inc.php on line 126 and defined
"

[ngegw]

On deleting multiple infologs, after successfully deleting, I get this
error:
"
An error happened

Argument 2 passed to egw_link::titles() must be an array, null given,
called
in /var/www/egroupware/etemplate/inc/class.etemplate_widget_link.inc.php on
line 126 and defined
"

Do you remember anything about the infologs? Like what sort of links or
attachments they had?

Nathan

[paulr00001]

OK, on further testing, I don’t think it was related to the deletion of infologs. I get the same error, simply opening them.

• Once the popped up infolog contents finish loading, the error pops up behind the infolog detail window.
• Ownership, Delegation, or Project linkage don’t seem to matter and all of the infologs I’ve opened caused the error.

"
An error happened

Argument 2 passed to egw_link::titles() must be an array, null given, called
in /var/www/egroupware/etemplate/inc/class.etemplate_widget_link.inc.php on
line 126 and defined
"

If it helps at all, this still happens on the checkout I did several hours ago, r43896. Please let me know if there is anything I can do to help test and squash this bug or others. My boss has authorized some time for me to look into this.

Regards,
Paul

[ngegw]

I understand that could get annoying fast.
I’m assuming you’re on Trunk, and the list looks different from what
you’re used to (no more pagination buttons).
In Firebug / Chrome network tools tab, look for an AJAX request
to json.php?menuaction=home.queue. It should have a request that looks
something like:
{“request”:{“parameters”:{“u5”:{“menuaction”:“file.etemplate_widget_link.ajax_link_titles.etemplate”,“parameters”:[<GOOD
STUFF …>]}}}}

There will be something in those parameters that doesn’t work. If you could
post that, it could help.

Nathan

[paulr00001]

Thanks for helping!

Here it is:

{“request”:{“parameters”:{“u1”:{“menuaction”:“infolog.etemplate_widget_link.ajax_link_titles.etemplate”,“parameters”:[{“projectmanager”:[],“home-accounts”:[],“file”:[],“infolog”:[“0”]}]},“u2”:{“menuaction”:“etemplate.etemplate_widget_link.ajax_link_list”,“parameters”:[{“to_id”:“30410”,“to_app”:“infolog”}]}}}}

[paulr00001]

I made this go away by checking the offending variable before the call to egw_link::titles()

I’m sure there is a better way to solve this, but at least the endless error popups are gone

public static function ajax_link_titles(array $app_ids)
{
        $response = array();
        foreach($app_ids as $app => $ids)
        {
                if(count($ids)) {
                        $response[$app] = egw_link::titles($app, $ids);
                }
        }
        egw_json_response::get()->data($response);
}

egroupware/etemplate/inc/class.etemplate_widget_link.inc.php

[ngegw]

I made this go away by checking the offending variable before the call to
egw_link::titles() I’m sure there is a better way to solve this, but at
least the endless error popups are gone

Glad it’s not bugging you anymore. I wish I knew where that ‘0’ was coming
from.
As an alternative, could you try this to see if we can stop it before it
makes the request?

phpgwapi/js/egw_links.js line 438:

• if (typeof _callback != ‘function’)

• if (typeof _callback != ‘function’ || !_app || !_id)

Nathan

[paulr00001]

Making the change you suggested to egw_links.js did not fix the error.

[ngegw]

Pity. I would have liked to stop it closer to the source, but your fix
works, so that’s fine with me.
Thanks for fixing that. I committed it, with an error log so we can
hopefully track it back to its source later.

Nathan