Groupdav broken - r32392 / $this->bo->now

[Hans-Jurgen_Tappe]

Hi!

Rev. 32392 in 1.8 broke the groupdav calendar.

— calendar/inc/class.calendar_groupdav.inc.php (revision 32411)
+++ calendar/inc/class.calendar_groupdav.inc.php (working copy)
@@ -107,8 +107,8 @@
// ToDo: add parameter to only return id & etag
$filter = array(
‘users’ => $user,
-‘start’ => $this->bo->now - 100243600,
-‘end’ => $this->bo->now + 365243600,
+‘start’ => time() - 100243600,
+‘end’ => time() + 365243600,

The problem seems to be that for groupdav.php. the variable
$this->bo->now is not initialized.

The change in rev. 32392 is not obviously wrong, so i want to discuss it
here, first. The intent is not to call time() too often and also, a fine
resolution of the time stamp is not required at this place because the
granularity is “1 day”.

So maybe, the better fix would be an initialization of $this->bo->now?

Please comment / commit the better approach.

Thanks a lot!
Hans-Jürgen

---

Start uncovering the many advantages of virtual appliances
and start using them to simplify application deployment and
accelerate your shift to cloud computing.
http://p.sf.net/sfu/novell-sfdev2dev

---

eGroupWare-developers mailing list
eGroupWare-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/egroupware-developers

[Leithoff_Klaus]

Actually it is defined in calendar_bo as
$this->now_su = egw_time::to(‘now’,‘ts’);
So the fast fix would be to use now_su.
(since I guess this was the intention)

kl@stylite.de
Stylite GmbH
[ open style of IT ]
Morschheimer Strasse 15
67292 Kirchheimbolanden

fon 06352 . 70629-0
fax 06352 . 70629-30
www.stylite.de

Geschäftsführer: Andre Keller, Gudrun Müller, Ralf Becker
Handelsregister Kaiserslautern HRB 30575
USt-ID: DE214280951

[Leithoff_Klaus]

I did dig around in trunk a bit.
It should be bo->now as it is supposed to be usertime.
In trunk in calendar_bo it is defined as such.
… I backported that one from trunk.

kl@stylite.de
Stylite GmbH
[ open style of IT ]
Morschheimer Strasse 15
67292 Kirchheimbolanden

fon 06352 . 70629-0
fax 06352 . 70629-30
www.stylite.de

Geschäftsführer: Andre Keller, Gudrun Müller, Ralf Becker
Handelsregister Kaiserslautern HRB 30575
USt-ID: DE214280951

[Hans-Jurgen_Tappe]

Hi Klaus!

I did dig around in trunk a bit.
It should be bo->now as it is supposed to be usertime.
In trunk in calendar_bo it is defined as such.
… I backported that one from trunk.

Thanks a lot. Everything runs smoothly now.

Best regards,
Hans-Jürgen

---

Virtualization is moving to the mainstream and overtaking non-virtualized
environment for deploying applications. Does it make network security
easier or more difficult to achieve? Read this whitepaper to separate the
two and get a better understanding.
http://p.sf.net/sfu/hp-phase2-d2d

---

eGroupWare-developers mailing list
eGroupWare-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/egroupware-developers