How do debug notifications not working?

jaytraxx 2012-06-27 14:32:02 UTC #21

Hi Lukasz,

you can see it in svn changelog:
http://www.egroupware.org/svn-changelog

And on 06/06/2012:
http://dev.egroupware.org/viewvc/egroupware?revision=39411&view=revision
http://dev.egroupware.org/viewvc/egroupware?revision=39411&view=revision

It think it should be included in the mentioned package because the fix
is made on 6th of June and the package is from 13th of June.

Hope this helps.
Christian

Sorry for digging it out, but is this fix included in 1.8.004.20120613 ?
can’t see it in published changelog…

https://www.egroupware.org/changelog

TA,
Lukasz

Hi Lukasz, It’s definitely included in the next releases, you do not
have to worry about

Bye Christian

Lukasz Sokol<el.es.cr http://el.es.cr@gmail.com> schrieb:

Hi Christian,

Hi Lukasz,

this is fixed now in 1.8 version. See svn changelog:
http://dev.egroupware.org/viewvc/egroupware?revision=39411&view=revision
You do not have to wait for the official patch being released.
Just edit the file
/notifications/inc/class.notifications_popup.inc.php according to
the changes mentioned in the svn changelog:

http://dev.egroupware.org/viewvc/egroupware/branches/1.8/notifications/inc/class.notifications_popup.inc.php?r1=31889&r2=39411&pathrev=39411
<http://dev.egroupware.org/viewvc/egroupware/branches/1.8/notifications/inc/class.notifications_popup.inc.php?r1
=31889&r2=39411&pathrev=39411>

Lines 110 and 111 have to look like this: 110 if
($session[‘loginid’] == $this->recipient->account_lid. ‘@’.
$GLOBALS[‘egw_info’][‘user’][‘domain’]) { 111 $user_sessions[] =
$session[‘session_php’];

in 110 session_lid was changed to loginid in 111 session_id was
changed to session_php

Let me know if it works for you.

Yes It Does! Thank you! Fixed manually, but it will be pulled-in too
when next update happens, right (saved the file and the diff just
in case)

Is the trail I found with Firebug (XHR POST transfer date set to
GMT when local time is GMT+1) a cul-de-sac ?
What’s a cul-de-sac
?
dead-end street

Bye Christian

TA, Lukasz

Live Security Virtual Conference
Exclusive live event will cover all the ways today’s security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/

eGroupWare-developers mailing list
eGroupWare-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/egroupware-developers

–
jaytraxx
christian binder
batschkastr. 32
83395 freilassing
tel :: +49 (8654) 650247
mail :: christian@jaytraxx.de mailto:christian@jaytraxx.de

Ralf_Becker_Stylite 2012-06-27 14:38:03 UTC #22

Hi Lukasz,

Sorry for digging it out, but is this fix included in 1.8.004.20120613 ?

If Christian commited the fix on June 6th and release is from June 13th,
it’s in.

can’t see it in published changelog…

https://www.egroupware.org/changelog

Only certain changes / commit-messages make it into release changelog.
Maybe Christian did not find it important enough to put it in changelog,
or maybe he did not know how

Changelog contains only first line of commit messages starting with "* "
(asterisk followed by a space) eg.

MyApp: fixed comunity bug #12345: blah failed with error X

Ralf

Hi Lukasz, It’s definitely included in the next releases, you do not
have to worry about

Bye Christian

Lukasz Sokol <el.es.cr http://el.es.cr@gmail.com> schrieb:

Hi Christian,

Hi Lukasz,

this is fixed now in 1.8 version. See svn changelog:
http://dev.egroupware.org/viewvc/egroupware?revision=39411&view=revision

You do not have to wait for the official patch being released.
Just edit the file
/notifications/inc/class.notifications_popup.inc.php according to
the changes mentioned in the svn changelog:

http://dev.egroupware.org/viewvc/egroupware/branches/1.8/notifications/inc/class.notifications_popup.inc.php?r1=31889&r2=39411&pathrev=39411
<http://dev.egroupware.org/viewvc/egroupware/branches/1.8/notifications/inc/class.notifications_popup.inc.php?r1

=31889&r2=39411&pathrev=39411>

Lines 110 and 111 have to look like this: 110 if
($session[‘loginid’] == $this->recipient->account_lid. ‘@’.
$GLOBALS[‘egw_info’][‘user’][‘domain’]) { 111 $user_sessions[] =
$session[‘session_php’];

in 110 session_lid was changed to loginid in 111 session_id was
changed to session_php

Let me know if it works for you.

Yes It Does! Thank you! Fixed manually, but it will be pulled-in too
when next update happens, right (saved the file and the diff just
in case)

Is the trail I found with Firebug (XHR POST transfer date set to
GMT when local time is GMT+1) a cul-de-sac ?

What’s a cul-de-sac
?

dead-end street

Bye Christian

TA, Lukasz

Live Security Virtual Conference
Exclusive live event will cover all the ways today’s security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/

eGroupWare-developers mailing list
eGroupWare-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/egroupware-developers

–
Ralf Becker
Director Software Development

Stylite AG

Morschheimer Strasse 15 | Tel. +49 6352 70629 0
D-67292 Kirchheimbolanden | Fax. +49 6352 70629 30

Email: rb@stylite.de

www.stylite.de | www.egroupware.org

Managing Directors: Andre Keller | Ralf Becker | Gudrun Mueller
Chairman of the supervisory board: Prof. Dr. Birger Leon Kropshofer

VAT DE214280951 | Registered HRB 31158 Kaiserslautern Germany

Live Security Virtual Conference
Exclusive live event will cover all the ways today’s security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/

eGroupWare-developers mailing list
eGroupWare-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/egroupware-developers

jaytraxx 2012-06-27 14:47:47 UTC #23

Hi Ralf,

Only certain changes / commit-messages make it into release changelog.
Maybe Christian did not find it important enough to put it in changelog,
or maybe he did not know how
… the latter

Changelog contains only first line of commit messages starting with "* "
(asterisk followed by a space) eg.

MyApp: fixed comunity bug #12345: blah failed with error X

We never finish learning … now I know how to make my commits more
prominent

Thanks. I will keep it in mind for the future.
Christian

el_es 2012-06-27 15:02:16 UTC #24

Hi Ralf,

Only certain changes / commit-messages make it into release
changelog. Maybe Christian did not find it important enough to put
it in changelog, or maybe he did not know how
… the latter

Changelog contains only first line of commit messages starting with
"* " (asterisk followed by a space) eg.

MyApp: fixed comunity bug #12345: blah failed with error X

We never finish learning … now I know how to make my commits more
prominent

Thanks. I will keep it in mind for the future. Christian

Thank you for prompt reply

Lukasz

eGroupWare-developers mailing list
eGroupWare-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/egroupware-developers