class.calendar_so.inc.php on line 1978

Anthony_Messina 2013-09-01 18:34:49 UTC #1

PHP Warning: Invalid argument supplied for foreach() in
/var/www/egroupware/calendar/inc/class.calendar_so.inc.php on line 1978 #1 /var/www/egroupware/calendar/inc/class.calendar_so.inc.php(1773):
calendar_so->delete_alarms(‘4464’) #2 /var/www/egroupware/calendar/inc/class.calendar_boupdate.inc.php(1517):
calendar_so->delete(‘4464’) #3 /var/www/egroupware/calendar/inc/class.calendar_groupdav.inc.php(1282):
calendar_boupdate->delete(‘4464’) #4 /var/www/egroupware/phpgwapi/inc/class.groupdav.inc.php(1341):
calendar_groupdav->delete(Array, ‘a50799ea-6244-4…’) #5 /var/www/egroupware/egw-pear/HTTP/WebDAV/Server.php(1879): groupdav-

DELETE(Array) #6 /var/www/egroupware/egw-pear/HTTP/WebDAV/Server.php(305):
HTTP_WebDAV_Server->http_DELETE() #7 /var/www/egroupware/phpgwapi/inc/class.groupdav.inc.php(1604):
HTTP_WebDAV_Server->ServeRequest() #8 /var/www/egroupware/groupdav.php(53): groupdav->ServeRequest()

Here’s a patch to fix the error reported when deleting a calendar event that
has no alarms:

egroupware]# svn diff */
Index: calendar/inc/class.calendar_so.inc.php

— calendar/inc/class.calendar_so.inc.php (revision 43687)
+++ calendar/inc/class.calendar_so.inc.php (working copy)
@@ -1975,7 +1975,7 @@
//error_log(METHOD."($cal_id) ".function_backtrace());
$alarms = $this->read_alarms($cal_id);

          foreach($alarms as $id => $alarm)

          if (isset($alarms)) foreach($alarms as $id => $alarm)
          {
                  $this->async->cancel_timer($id);
          }

–
Anthony - http://messinet.com - http://messinet.com/~amessina/gallery
8F89 5E72 8DF0 BCF0 10BE 9967 92DC 35DC B001 4A4E

Ralf_Becker_Stylite 2013-09-02 06:50:46 UTC #2

Hi Anthony,

thanks for the report. It’s fixed now in SVN.

That new warnings incl. a trace are nice

Ralf

PHP Warning: Invalid argument supplied for foreach() in
/var/www/egroupware/calendar/inc/class.calendar_so.inc.php on line 1978
#1 /var/www/egroupware/calendar/inc/class.calendar_so.inc.php(1773):
calendar_so->delete_alarms(‘4464’)
#2 /var/www/egroupware/calendar/inc/class.calendar_boupdate.inc.php(1517):
calendar_so->delete(‘4464’)
#3 /var/www/egroupware/calendar/inc/class.calendar_groupdav.inc.php(1282):
calendar_boupdate->delete(‘4464’)
#4 /var/www/egroupware/phpgwapi/inc/class.groupdav.inc.php(1341):
calendar_groupdav->delete(Array, ‘a50799ea-6244-4…’)
#5 /var/www/egroupware/egw-pear/HTTP/WebDAV/Server.php(1879): groupdav-

DELETE(Array)
#6 /var/www/egroupware/egw-pear/HTTP/WebDAV/Server.php(305):
HTTP_WebDAV_Server->http_DELETE()
#7 /var/www/egroupware/phpgwapi/inc/class.groupdav.inc.php(1604):
HTTP_WebDAV_Server->ServeRequest()
#8 /var/www/egroupware/groupdav.php(53): groupdav->ServeRequest()

Here’s a patch to fix the error reported when deleting a calendar event that
has no alarms:

egroupware]# svn diff */
Index: calendar/inc/class.calendar_so.inc.php

— calendar/inc/class.calendar_so.inc.php (revision 43687)
+++ calendar/inc/class.calendar_so.inc.php (working copy)
@@ -1975,7 +1975,7 @@
//error_log(METHOD."($cal_id) ".function_backtrace());
$alarms = $this->read_alarms($cal_id);
          foreach($alarms as $id => $alarm)
          if (isset($alarms)) foreach($alarms as $id => $alarm)
           {
                   $this->async->cancel_timer($id);
           }
Learn the latest–Visual Studio 2012, SharePoint 2013, SQL 2012, more!
Discover the easy way to master current and previous Microsoft technologies
and advance your career. Get an incredible 1,500+ hours of step-by-step
tutorial videos with LearnDevNow. Subscribe today and save!
http://pubads.g.doubleclick.net/gampad/clk?id=58040911&iu=/4140/ostg.clktrk

eGroupWare-developers mailing list
eGroupWare-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/egroupware-developers

–
Ralf Becker
Director Software Development

Stylite AG

Morschheimer Strasse 15 | Tel. +49 6352 70629 0
D-67292 Kirchheimbolanden | Fax. +49 6352 70629 30

Email: rb@stylite.de

www.stylite.de | www.egroupware.org

Managing Directors: Andre Keller | Ralf Becker | Gudrun Mueller
Chairman of the supervisory board: Prof. Dr. Birger Leon Kropshofer

VAT DE214280951 | Registered HRB 31158 Kaiserslautern Germany

Learn the latest–Visual Studio 2012, SharePoint 2013, SQL 2012, more!
Discover the easy way to master current and previous Microsoft technologies
and advance your career. Get an incredible 1,500+ hours of step-by-step
tutorial videos with LearnDevNow. Subscribe today and save!
http://pubads.g.doubleclick.net/gampad/clk?id=58040911&iu=/4140/ostg.clktrk

eGroupWare-developers mailing list
eGroupWare-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/egroupware-developers

Anthony_Messina 2013-09-02 16:10:42 UTC #3

That’s great, Ralf. Thanks again! -A

Hi Anthony,

thanks for the report. It’s fixed now in SVN.

That new warnings incl. a trace are nice

Ralf
PHP Warning: Invalid argument supplied for foreach() in
/var/www/egroupware/calendar/inc/class.calendar_so.inc.php on line 1978
#1 /var/www/egroupware/calendar/inc/class.calendar_so.inc.php(1773):
calendar_so->delete_alarms(‘4464’)
#2 /var/www/egroupware/calendar/inc/class.calendar_boupdate.inc.php(1517):
calendar_so->delete(‘4464’)
#3 /var/www/egroupware/calendar/inc/class.calendar_groupdav.inc.php(1282):
calendar_boupdate->delete(‘4464’)
#4 /var/www/egroupware/phpgwapi/inc/class.groupdav.inc.php(1341):
calendar_groupdav->delete(Array, ‘a50799ea-6244-4…’)
#5 /var/www/egroupware/egw-pear/HTTP/WebDAV/Server.php(1879): groupdav-

DELETE(Array)

#6 /var/www/egroupware/egw-pear/HTTP/WebDAV/Server.php(305):
HTTP_WebDAV_Server->http_DELETE()
#7 /var/www/egroupware/phpgwapi/inc/class.groupdav.inc.php(1604):
HTTP_WebDAV_Server->ServeRequest()
#8 /var/www/egroupware/groupdav.php(53): groupdav->ServeRequest()

Here’s a patch to fix the error reported when deleting a calendar event
that has no alarms:

egroupware]# svn diff */
Index: calendar/inc/class.calendar_so.inc.php

— calendar/inc/class.calendar_so.inc.php (revision 43687)
+++ calendar/inc/class.calendar_so.inc.php (working copy)
@@ -1975,7 +1975,7 @@
             //error_log(__METHOD__."($cal_id)
".function_backtrace()); $alarms = $this->read_alarms($cal_id);
          foreach($alarms as $id => $alarm)
          if (isset($alarms)) foreach($alarms as $id => $alarm)

           {
                   $this->async->cancel_timer($id);
           }

–
Anthony - http://messinet.com - http://messinet.com/~amessina/gallery
8F89 5E72 8DF0 BCF0 10BE 9967 92DC 35DC B001 4A4E