Issue in upgrade from 17.1 to 19.1

[vishakha]

Thanks for sharing this file Ralf. This is much helpful

What I’m unable to find is the jscalendar, I have used it in my date fields and instantiated like this

This was used before,

$this->jscal = createObject('phpgwapi.jscalendar');
$this->jscal->input('lastdateworked', date('m/d/Y'))

How do I access all the js ibraries that were used in phpgwapi

[RalfBecker]

jscalendar is such an ancient library, it is simply no longer available in our current API.

Our current API and eTemplate2 uses jQuery DatePicker:

EGroupware/egroupware/blob/master/api/js/jsapi/egw_calendar.js#L241

If logged into EGroupware you can eg. call it via the JavaScript console of your browser:

egw.calendar(jQuery('<input value="2020-07-17"/>').prependTo('div.egw_fw_content_browser_div'), false, function(v){console.log(v);});

Ralf

[vishakha]

DatePicker

Is there a way to instantiate this in PHP, since the script is already loaded I should be able to use it anywhere.
It returns the calendar object in the browser console.
I have a custom JS file in my application, when I do console.log(egw.calendar), it gives me an error saying egw is not defined.

Do you have any documentation on how to instantiate this calendar to be able to use in in a custom date field of your custom application

[vishakha]

Please advice how to instantiate this calendar to be able to use in in a custom date field of your custom application

[vishakha]

How do I use a datepicker on a custom field.
I’m not using the etemplate engine, it’s pure HTML. I have a custom JS file where I can initialize the datepicker for that field. If datepicker is loaded by default, how do I enable it for the field, please advice for the initialization best practices

[RalfBecker]

I already wrote you how to initialize the datapicker, scroll a couple of comments up:

egw.calendar(jQuery('<input value="2020-07-17"/>').prependTo('div.egw_fw_content_browser_div'), false, function(v){console.log(v);});

Instead of creating a new input field, as I do in the above example, you could also just specify an id:

jQuery('<input value="2020-07-17" id="mydate"/>').prependTo('div.egw_fw_content_browser_div');
egw.calendar(jQuery('#mydata'), false, function(v){console.log(v);});

The official jQueryUI docu about datepicker is here: https://jqueryui.com/datepicker/

We only initialize it with language and date-format of the current user.

Ralf

[vishakha]

I have used this initialization like you described before in my custom js file of custom application.
The issue is that it says egw not defined, not sure if I have to extend anything before using this code in my js file

[RalfBecker]

Then you probably have not included our header on server-side, have a look at our example app:

EGroupware/example

Ralf

[vishakha]

ded our header on server-side, have a look at our example app:

The header is good, but I have these errors in the console now. while selecting the input

jquery.js?1594672809:6702 Uncaught TypeError: Cannot read property 'defaultView' of null
    at getStyles (jquery.js?1594672809:6702)
    at curCSS (jquery.js?1594672809:6715)
    at Function.css (jquery.js?1594672809:7172)
    at jquery.js?1594672809:7349
    at access (jquery.js?1594672809:4428)
    at jQuery.fn.init.css (jquery.js?1594672809:7331)
    at datepicker_getZindex (jquery-ui.js?1594672814:3783)
    at HTMLInputElement._showDatepicker (jquery-ui.js?1594672814:4526)
    at HTMLInputElement.dispatch (jquery.js?1594672809:5226)
    at HTMLInputElement.elemData.handle (jquery.js?1594672809:4878)

HTML

<input type="text" id="input-datepicker" value="2020-07-17" class="hasDatepicker" size="10">

JS

$(document).ready(function () {
  egw.calendar(jQuery('#input-datepicker'), false, function(v){});
});

[RalfBecker]

That’s probably caused by you not taking care of our asynchronous loading of javascript files.

You need to wait for javascript files to be loaded:

egw_LAB.wait(function() {
   jQuery(document).ready(function () {
      egw.calendar(jQuery('#input-datepicker'), false, function(v){});
   });
}

If you would use our rendering engine / eTemplate2, all that would be taken care of automatic!

Ralf

[RalfBecker]

An other possibility is to store your javascript in our standard place $app/js/app.js, then it will be loaded automatic and started after all javascript is loaded and ready to run.

Ralf

[vishakha]

The egw_LAB.wait(function() doesn’t seem to work, all egw_js files are still loaded after my custom js file.
I still get the same errors in the console.

I tried the other possibility you mentioned as per the standard, created an app.js file and placed the following code inside.

app.classes.myapp = AppJS.extend(
  {
    appname: 'myapp',


    /**
     * Initialize javascript for this application
     *
     * @memberOf myapp
     */
    init: function() {
      console.log("app test my cutom app");
      egw.calendar(jQuery('#input-datepicker'), false, function(v){});
    },


  });

But I couldn’t see the app.js loaded in the network tab, is there any any other code that needs to be added in the app.js file for it to be picked up ?

[vishakha]

If I’m not using the Etemplate system, will app.js still work ?

[vishakha]

The app js doesn’t seem to load. I used the code given in the above comment.
Also the egw_LAB.wait(function() { doesn’t do anything in my custom JS file.

Please help, this is the last step I want to fix in my new upgraded version

[RalfBecker]

I modified our example app branch step1 as an example for you:

cd /path/to/egroupware
git clone -b step1
patch -p1 -d example <<EOF
diff --git a/js/app.js b/js/app.js
new file mode 100644
index 0000000..ad7835a
--- /dev/null
+++ b/js/app.js
@@ -0,0 +1,9 @@
+/*egw:uses
+       /vendor/bower-asset/jquery/dist/jquery.js;
+       /vendor/bower-asset/jquery-ui/jquery-ui.js;
+*/
+egw_LAB.wait(function() {
+       jQuery(function () {
+               egw.calendar(jQuery('#input-datepicker'), false, function(v){});
+       });
+});
diff --git a/src/Ui.php b/src/Ui.php
index 92087e7..560a81e 100644
--- a/src/Ui.php
+++ b/src/Ui.php
@@ -12,6 +12,8 @@

 namespace EGroupware\Example;

+use EGroupware\Api\Framework;
+
 class Ui
 {
        /**
@@ -30,6 +32,9 @@ class Ui
         */
        public function index(array $content=null)
        {
+               Framework::includeJS('/example/js/app.js');
+               echo $GLOBALS['egw']->framework->header();
                echo "Hello World :)";
+               echo "<p><input type='text' id='input-datepicker' value=''/></p>\n";
        }
 }
EOF

The loading works, but jQuery still throws that TypeError.

As far as I can tell that’s a problem/bug in jQuery

Ralf

[vishakha]

Thanks for the insight Ralf

This worked for me, just using simple datepicker, no wait function and egw calendar. So there is something up with egw calendar initialization

// egw_LAB.wait(function() {
           jQuery(function () {
              // egw.calendar(jQuery('#input-datepicker'), false, function(v){});
             jQuery( "#input-datepicker" ).datepicker();
             });
    // });

[vishakha]

This is how it shows up, no way to change the year though

[vishakha]

Added other datepicker properties and it seems to be working fine this way

[RalfBecker]

That’s what our initialization does, setting up datepicker according to the preferences of the user.

Ralf

[vishakha]

Hi Ralf.

I finished removing the deprecated code for latest upgrade version 20.1 on my local server.
However after starting the upgrade on production server, I ran into the same access log errors.

2020-07-29 08:48:17: (mod_fastcgi.c.421) FastCGI-stderr: # Instance=default, User=vish, Request=POST https://project.qa.com:8081/egroupware/json.php?menuaction=home.jdots_framework.ajax_exec.t>
2020-07-29 08:48:17: (mod_fastcgi.c.421) FastCGI-stderr: PHP Warning: Creating default object from empty value in /home/www.project.com/public_html/egroupware/api/src/Db.php on line 510
2020-07-29 08:48:17: (mod_fastcgi.c.421) FastCGI-stderr: #1 /home/www.project.com/public_html/egroupware/api/src/Db.php(344): EGroupware\Api\Db->_connect()
2020-07-29 08:48:17: (mod_fastcgi.c.421) FastCGI-stderr: #2 /home/www.project.com/public_html/egroupware/api/src/Db.php(604): EGroupware\Api\Db->connect()
2020-07-29 08:48:17: (mod_fastcgi.c.421) FastCGI-stderr: #3 [internal function]: EGroupware\Api\Db->__wakeup()
2020-07-29 08:48:17: (mod_fastcgi.c.421) FastCGI-stderr: #4 /home/www.project.com/public_html/egroupware/api/src/loader.php(79): unserialize()
2020-07-29 08:48:17: (mod_fastcgi.c.421) FastCGI-stderr: #5 /home/www.project.com/public_html/egroupware/header.inc.php(92): require_once('/home/www.temps...')
2020-07-29 08:48:17: (mod_fastcgi.c.421) FastCGI-stderr: #6 /home/www.project.com/public_html/egroupware/json.php(110): include_once('/home/www.temps...')
2020-07-29 08:48:17: (mod_fastcgi.c.421) FastCGI-stderr: #7 {main}
2020-07-29 08:48:17: (mod_fastcgi.c.421) FastCGI-stderr: # Instance=default, User=vish, Request=GET https://project.qa.com:8081/egroupware/json.php?menuaction=EGroupware\Api\Framework::ajax_ge>
2020-07-29 08:48:17: (mod_fastcgi.c.421) FastCGI-stderr: PHP Warning: Creating default object from empty value in /home/www.project.com/public_html/egroupware/api/src/Db.php on line 510
2020-07-29 08:48:17: (mod_fastcgi.c.421) FastCGI-stderr: #1 /home/www.project.com/public_html/egroupware/api/src/Db.php(344): EGroupware\Api\Db->_connect()
2020-07-29 08:48:17: (mod_fastcgi.c.421) FastCGI-stderr: #2 /home/www.project.com/public_html/egroupware/api/src/Db.php(604): EGroupware\Api\Db->connect()
2020-07-29 08:48:17: (mod_fastcgi.c.421) FastCGI-stderr: #3 [internal function]: EGroupware\Api\Db->__wakeup()
2020-07-29 08:48:17: (mod_fastcgi.c.421) FastCGI-stderr: #4 /home/www.project.com/public_html/egroupware/api/src/loader.php(79): unserialize()
2020-07-29 08:48:17: (mod_fastcgi.c.421) FastCGI-stderr: #5 /home/www.project.com/public_html/egroupware/header.inc.php(92): require_once('/home/www.project...')
2020-07-29 08:48:17: (mod_fastcgi.c.421) FastCGI-stderr: #6 /home/www.project.com/public_html/egroupware/json.php(110): include_once('/home/www.project...')
2020-07-29 08:48:17: (mod_fastcgi.c.421) FastCGI-stderr: #7 {main}
2020-07-29 08:48:17: (mod_fastcgi.c.421) FastCGI-stderr: # Instance=default, User=vish, Request=POST https://project.qa.com:8081/egroupware/json.php?menuaction=status.jdots_framework.ajax_exec>
2020-07-29 08:48:17: (mod_fastcgi.c.421) FastCGI-stderr: Database error (EGroupware\Api\Db\Exception\InvalidSql): Invalid SQL: UPDATE egw_access_log SET  WHERE
2020-07-29 08:48:17: (mod_fastcgi.c.421) FastCGI-stderr: You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near 'WHERE' at>
2020-07-29 08:48:17: (mod_fastcgi.c.421) FastCGI-stderr: #0 /home/www.project.com/public_html/egroupware/api/src/Db/Deprecated.php(64): EGroupware\Api\Db->query()
2020-07-29 08:48:17: (mod_fastcgi.c.421) FastCGI-stderr: #1 /home/www.project.com/public_html/egroupware/api/src/Db.php(1980): EGroupware\Api\Db\Deprecated->query()
2020-07-29 08:48:17: (mod_fastcgi.c.421) FastCGI-stderr: #2 /home/www.project.com/public_html/egroupware/api/src/Session.php(1893): EGroupware\Api\Db->update()
2020-07-29 08:48:17: (mod_fastcgi.c.421) FastCGI-stderr: #3 /home/www.project.com/public_html/egroupware/api/src/Session.php(1315): EGroupware\Api\Session->update_dla()
2020-07-29 08:48:17: (mod_fastcgi.c.421) FastCGI-stderr: #4 /home/www.project.com/public_html/egroupware/api/src/Egw.php(304): EGroupware\Api\Session->verify()
2020-07-29 08:48:17: (mod_fastcgi.c.421) FastCGI-stderr: #5 /home/www.project.com/public_html/egroupware/api/src/Egw.php(259): EGroupware\Api\Egw->verify_session()
2020-07-29 08:48:17: (mod_fastcgi.c.421) FastCGI-stderr: #6 /home/www.project.com/public_html/egroupware/api/src/loader.php(83): EGroupware\Api\Egw->wakeup2()
2020-07-29 08:48:17: (mod_fastcgi.c.421) FastCGI-stderr: #7 /home/www.project.com/public_html/egroupware/header.inc.php(92): require_once('/home/www.project...')
2020-07-29 08:48:17: (mod_fastcgi.c.421) FastCGI-stderr: #8 /home/www.project.com/public_html/egroupware/json.php(110): include_once('/home/www.project...')
2020-07-29 08:48:17: (mod_fastcgi.c.421) FastCGI-stderr: #9 {main}
2020-07-29 08:48:17: (mod_fastcgi.c.421) FastCGI-stderr: # Instance=default, User=vish, Request=POST https://project.qa.com:8081/egroupware/json.php?menuaction=status.jdots_framework.ajax_exec>

Production Server Details:

DB Server: MariaDB Server
Version: 10.1.34-MariaDB
PHP 7.4
Maria db is used
Lighttpd server is used

Local server details:

Mysql
PHP 7.2
Apache is used.

The upgrade was successful on the local server, I compared the schema setup file which is identical. Not sure what part of code is causing the values of the update access log query empty.
Please help