Issue with tracker mail handler

Raphael_Alla 2009-07-19 06:31:18 UTC #1

Hi,

I have just noticed several issues with the automated processing of emails
when these emails use UTF-8 characters such as é è ï etc.

The issues are in the file class.tracker_mailhandler.inc.php

The function html::purify removes characters which are encoded in latin1
there is no conversion of emails header / body received in latin1 into
utf-8

I have patched the file class.tracker_mailhandler.inc.php, but i am worried
the patch may not work in all situations

Index: tracker/inc/class.tracker_mailhandler.inc.php

— tracker/inc/class.tracker_mailhandler.inc.php (revision 27439)
+++ tracker/inc/class.tracker_mailhandler.inc.php (working copy)
@@ -225,6 +225,7 @@
#return ($body);
break;
}

          $body = utf8_encode($body);
          return html::purify($body);
  }

@@ -241,6 +242,7 @@
'elseif ($matches[2] == “b” ||
$matches[2] == “B”) { return base64_decode ($matches[3]); } ’ .
'else { return $matches[3]; } '
), $header);

          $header = utf8_encode($header);
  }

  /**

–
Raphael Alla
Alphalog Calédonie
Mitija Australia
+61 4 15 678 576
+687 78 86 86
http://www.mitija.com
http://www.alphalog.nc

Raphael_Alla 2009-07-19 07:00:35 UTC #2

Hi,

I have discovered even more issues with the mail handling of the tracker:

html emails do not appear well in the tracker, the html code becomes
visible
attachment to the email (such as screen copies) are lost! This is a
feature request for attachment to become linked files in the tracker

Hi,

I have just noticed several issues with the automated processing of emails
when these emails use UTF-8 characters such as é è ï etc.

The issues are in the file class.tracker_mailhandler.inc.php

The function html::purify removes characters which are encoded in latin1

there is no conversion of emails header / body received in latin1 into
utf-8

I have patched the file class.tracker_mailhandler.inc.php, but i am worried
the patch may not work in all situations

Index: tracker/inc/class.tracker_mailhandler.inc.php

— tracker/inc/class.tracker_mailhandler.inc.php (revision 27439)
+++ tracker/inc/class.tracker_mailhandler.inc.php (working copy)
@@ -225,6 +225,7 @@
#return ($body);
break;
}
          $body = utf8_encode($body);
          return html::purify($body);
  }
@@ -241,6 +242,7 @@
'elseif ($matches[2] == “b” ||
$matches[2] == “B”) { return base64_decode ($matches[3]); } ’ .
'else { return $matches[3]; } '
), $header);
          $header = utf8_encode($header);
  }

  /**
–
Raphael Alla
Alphalog Calédonie
Mitija Australia
+61 4 15 678 576
+687 78 86 86
http://www.mitija.com
http://www.alphalog.nc

–
Raphael Alla
Alphalog Calédonie
Mitija Australia
+61 4 15 678 576
+687 78 86 86
http://www.mitija.com
http://www.alphalog.nc

Oscar_van_Eijk-3 2009-07-19 07:48:18 UTC #3

Hi Raphael,

I’ll have a look at your patch. More issues have been reported about
incoming HTML mails, but none reproducible by me, so any input is
welcome

Handling attachments is on the roadmap for 1.8. I made a start already;
it’ll be available in trunk soon.

Oscar

Hi,

I have discovered even more issues with the mail handling of the
tracker:

html emails do not appear well in the tracker, the html code
becomes visible

attachment to the email (such as screen copies) are lost! This is a
feature request for attachment to become linked files in the tracker

R.
    Hi,
    
    I have just noticed several issues with the automated
    processing of emails when these emails use UTF-8 characters
    such as Ã© Ã¨ Ã¯ etc.
    
    The issues are in the file class.tracker_mailhandler.inc.php
    1) The function html::purify removes characters which are
    encoded in latin1
    2) there is no conversion of emails header / body received in
    latin1 into utf-8
    
    I have patched the file class.tracker_mailhandler.inc.php, but
    i am worried the patch may not work in all situations
    
    Index: tracker/inc/class.tracker_mailhandler.inc.php
    ===================================================================
    --- tracker/inc/class.tracker_mailhandler.inc.php
    (revision 27439)
    +++ tracker/inc/class.tracker_mailhandler.inc.php
    (working copy)
    @@ -225,6 +225,7 @@
                                    #return ($body);
                                    break;
                    }
    +               $body = utf8_encode($body);
                    return html::purify($body);
            }
    
    @@ -241,6 +242,7 @@
                                            'elseif ($matches[2]
    == "b" || $matches[2] == "B") { return base64_decode
    ($matches[3]); } ' .
                                            'else { return
    $matches[3]; } '
                            ),  $header);
    +               $header = utf8_encode($header);
            }
    
            /**
    
    -- 
    Raphael Alla
    Alphalog CalÃ©donie
    Mitija Australia
    +61 4 15 678 576
    +687 78 86 86
    http://www.mitija.com
    http://www.alphalog.nc
–
Raphael Alla
Alphalog CalÃ©donie
Mitija Australia
+61 4 15 678 576
+687 78 86 86
http://www.mitija.com
http://www.alphalog.nc

Enter the BlackBerry Developer Challenge
This is your chance to win up to $100,000 in prizes! For a limited time,
vendors submitting new applications to BlackBerry App World™ will have
the opportunity to enter the BlackBerry Developer Challenge. See full prize
details at: http://p.sf.net/sfu/Challenge
_______________________________________________ eGroupWare-developers mailing list eGroupWare-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/egroupware-developers

Oscar van Eijk

Oveas Functionality Provider
Zwaardenburg 63 – 3437 RJ Nieuwegein
T: +31(0)30 - 889 7812 – F: +31(0)30 - 889 9117
http://oveas.com – mailto:info@oveas.com

Oveas Functionality Provider

Oscar_van_Eijk-3 2009-07-20 09:33:12 UTC #4

Raphael (and anyone with similar issues),

I’ve made some changes to the decoding; it works for all situations I
can test w/ my mailclients; except for the HTML; the code is still
displayed. I’ll look into that asap.
If the latest updates don’t work, please send an example mail to
helptest(a)oveas.net using the failing encoding format so I can parse
them in my test environment.
Please use some special chars in the header and the mailbody and a
description in the body as well.

If you send an email there, please notify me here so I know I have to
check my testsys

Oscar

Hi,

I have discovered even more issues with the mail handling of the
tracker:

html emails do not appear well in the tracker, the html code
becomes visible

attachment to the email (such as screen copies) are lost! This is a
feature request for attachment to become linked files in the tracker

R.
    Hi,
    
    I have just noticed several issues with the automated
    processing of emails when these emails use UTF-8 characters
    such as Ã© Ã¨ Ã¯ etc.
    
    The issues are in the file class.tracker_mailhandler.inc.php
    1) The function html::purify removes characters which are
    encoded in latin1
    2) there is no conversion of emails header / body received in
    latin1 into utf-8
    
    I have patched the file class.tracker_mailhandler.inc.php, but
    i am worried the patch may not work in all situations
    
    Index: tracker/inc/class.tracker_mailhandler.inc.php
    ===================================================================
    --- tracker/inc/class.tracker_mailhandler.inc.php
    (revision 27439)
    +++ tracker/inc/class.tracker_mailhandler.inc.php
    (working copy)
    @@ -225,6 +225,7 @@
                                    #return ($body);
                                    break;
                    }
    +               $body = utf8_encode($body);
                    return html::purify($body);
            }
    
    @@ -241,6 +242,7 @@
                                            'elseif ($matches[2]
    == "b" || $matches[2] == "B") { return base64_decode
    ($matches[3]); } ' .
                                            'else { return
    $matches[3]; } '
                            ),  $header);
    +               $header = utf8_encode($header);
            }
    
            /**
    
    -- 
    Raphael Alla
    Alphalog CalÃ©donie
    Mitija Australia
    +61 4 15 678 576
    +687 78 86 86
    http://www.mitija.com
    http://www.alphalog.nc
–
Raphael Alla
Alphalog CalÃ©donie
Mitija Australia
+61 4 15 678 576
+687 78 86 86
http://www.mitija.com
http://www.alphalog.nc

Enter the BlackBerry Developer Challenge
This is your chance to win up to $100,000 in prizes! For a limited time,
vendors submitting new applications to BlackBerry App World™ will have
the opportunity to enter the BlackBerry Developer Challenge. See full prize
details at: http://p.sf.net/sfu/Challenge
_______________________________________________ eGroupWare-developers mailing list eGroupWare-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/egroupware-developers

Oscar van Eijk

Oveas Functionality Provider
Zwaardenburg 63 – 3437 RJ Nieuwegein
T: +31(0)30 - 889 7812 – F: +31(0)30 - 889 9117
http://oveas.com – mailto:info@oveas.com

Oveas Functionality Provider

Pongracz_Istvan-2 2009-07-20 11:33:24 UTC #5

Hi,

Check your mail testsys. I sent a mail a minute ago.

Cheers,

IStván