Mail notification: save already notified messages in session data

jaytraxx 2009-02-09 22:22:23 UTC #1

Hi all,

I’m currently working on the mail notifications and encountered that the recent flag is not reliable enough to filter messages by. There are several reasons why and I just heard things like ‘Keep your hands off the recent flag’ on many internet articles.

So, if nobody of the other devs objects I will do the following:

Filter the messages by the ‘UNSEEN’ flag, NOT ‘RECENT’
Notify on all ‘UNSEEN’ messages first
write all UIDs of messages being notified into the users session
Notify on all ‘UNSEEN’ and not already notified messages in further steps

A very small disadvantage will be: The user gets notified again on all ‘UNSEEN’ messages if he re-enters eGW. Yes, I could store the UIDs of the messages already notified about into a table but I don’t want to create a caching table like it had been before in eGW 1.2. This will be very ugly.

Comments welcome.

Bye
Christian

Oscar_van_Eijk-3 2009-02-10 07:14:05 UTC #2

Hi Cristian,

What about a combination:
if (Recent || (!Recent && Unseen)) {
notify();
}

You’ll have the same disadvantage, but it’ll occur less often.

Oscar

Hi all,

I’m currently working on the mail notifications and encountered that the
recent flag is not reliable enough to filter messages by. There are several
reasons why and I just heard things like ‘Keep your hands off the recent
flag’ on many internet articles.

So, if nobody of the other devs objects I will do the following:

Filter the messages by the ‘UNSEEN’ flag, NOT ‘RECENT’

Notify on all ‘UNSEEN’ messages first

write all UIDs of messages being notified into the users session

Notify on all ‘UNSEEN’ and not already notified messages in further steps

A very small disadvantage will be: The user gets notified again on all
’UNSEEN’ messages if he re-enters eGW. Yes, I could store the UIDs of the
messages already notified about into a table but I don’t want to create a
caching table like it had been before in eGW 1.2. This will be very ugly.

Comments welcome.

Bye
Christian

Oscar van Eijk

Oveas Functionality Provider
Zwaardenburg 63 – 3437 RJ Nieuwegein
T: +31(0)30 - 889 7812 – F: +31(0)30 - 889 9117
http://oveas.com – mailto:info@oveas.com

Oveas Functionality Provider

Leithoff_Klaus 2009-02-10 09:31:28 UTC #3

Another way would be to store the last notified uid with the preferences of
either
felamimail or notifications.
A preference to store and retrieve does not have to bee used and seen in the
prefernence
listing of
that application
You are able to set and retrieve the value in question with the preference
functionality.
So while you are within the session store the uids already notivied, and
update the
preference
with the last one notified. If there is no notified list with the session
check the last
notified uid, and
start of from there.

egroupware-developers@lists.sourceforge.net

Hi Cristian,

What about a combination:
if (Recent || (!Recent && Unseen)) {
notify();
}

You’ll have the same disadvantage, but it’ll occur less often.

Oscar

Hi all,

I’m currently working on the mail notifications and encountered that the
recent flag is not reliable enough to filter messages by. There are several
reasons why and I just heard things like ‘Keep your hands off the recent
flag’ on many internet articles.

So, if nobody of the other devs objects I will do the following:

Filter the messages by the ‘UNSEEN’ flag, NOT ‘RECENT’

Notify on all ‘UNSEEN’ messages first

write all UIDs of messages being notified into the users session

Notify on all ‘UNSEEN’ and not already notified messages in further steps

A very small disadvantage will be: The user gets notified again on all
’UNSEEN’ messages if he re-enters eGW. Yes, I could store the UIDs of the
messages already notified about into a table but I don’t want to create a
caching table like it had been before in eGW 1.2. This will be very ugly.

Comments welcome.

Bye
Christian

Oscar van Eijk

Oveas Functionality Provider
Zwaardenburg 63 – 3437 RJ Nieuwegein
T: +31(0)30 - 889 7812 – F: +31(0)30 - 889 9117
[http://oveas.com – mailto:info@oveas.com

-> http://oveas.com]

Create and Deploy Rich Internet Apps outside the browser with
Adobe®AIR™
software. With Adobe AIR, Ajax developers can use existing skills and code
to
build responsive, highly engaging applications that combine the power of
local
resources and data with the reach of the web. Download the Adobe AIR SDK
and
Ajax docs to start building applications
today-http://p.sf.net/sfu/adobe-com

eGroupWare-developers mailing list
eGroupWare-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/egroupware-developers

–
Stylite GmbH
[ open style of IT ]
Morschheimer Strasse 15
67292 Kirchheimbolanden

fon 06352 . 70629-0
fax 06352 . 70629-30
www.stylite.de

Handelsregister Kaiserslautern HRB 30575
Geschäftsführer: Andre Keller, Gudrun Müller, Nigel Vickers, Ralf Becker

Oscar_van_Eijk-3 2009-02-10 11:13:51 UTC #4

Wouldn’t you consider that ‘abuse’ of the preferences functionality?

Prefs are not designed fot that, so any future developer might expect all
exisiting
preferences to be visible, hence, there’s always a chance new fieldsnames
are introduced that
conflict with this kind of implementations.

Likely? I guess not… it’s just that I’m not fond of this kinda
constructions :-S

Just my 2c,

Oscar

developers"
egroupware-developers@lists.sourceforge.net

Another way would be to store the last notified uid with the preferences of
either
felamimail or notifications.
A preference to store and retrieve does not have to bee used and seen in
the prefernence
listing of
that application
You are able to set and retrieve the value in question with the preference
functionality.
So while you are within the session store the uids already notivied, and
update the
preference
with the last one notified. If there is no notified list with the session
check the last
notified uid, and
start of from there.

Von: “Oscar van Eijk” oscar.van.eijk@oveas.com
An: "development of eGroupWare,for active developers"
egroupware-developers@lists.sourceforge.net
Datum: Tue, 10 Feb 2009 08:14:05 +0100

Hi Cristian,

What about a combination:
if (Recent || (!Recent && Unseen)) {
notify();
}

You’ll have the same disadvantage, but it’ll occur less often.

Oscar

Hi all,

I’m currently working on the mail notifications and encountered that the
recent flag is not reliable enough to filter messages by. There are
several

reasons why and I just heard things like ‘Keep your hands off the recent
flag’ on many internet articles.

So, if nobody of the other devs objects I will do the following:

Filter the messages by the ‘UNSEEN’ flag, NOT ‘RECENT’

Notify on all ‘UNSEEN’ messages first

write all UIDs of messages being notified into the users session

Notify on all ‘UNSEEN’ and not already notified messages in further
steps

A very small disadvantage will be: The user gets notified again on all
’UNSEEN’ messages if he re-enters eGW. Yes, I could store the UIDs of the
messages already notified about into a table but I don’t want to create a
caching table like it had been before in eGW 1.2. This will be very ugly.

Comments welcome.

Bye
Christian

Oscar van Eijk

Oveas Functionality Provider
Zwaardenburg 63 – 3437 RJ Nieuwegein
T: +31(0)30 - 889 7812 – F: +31(0)30 - 889 9117
[http://oveas.com – mailto:info@oveas.com

-> http://oveas.com]

Create and Deploy Rich Internet Apps outside the browser with
Adobe®AIR™

software. With Adobe AIR, Ajax developers can use existing skills and code
to

build responsive, highly engaging applications that combine the power of
local

resources and data with the reach of the web. Download the Adobe AIR SDK
and

Ajax docs to start building applications
today-http://p.sf.net/sfu/adobe-com

eGroupWare-developers mailing list
eGroupWare-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/egroupware-developers

Stylite GmbH
[ open style of IT ]
Morschheimer Strasse 15
67292 Kirchheimbolanden

fon 06352 . 70629-0
fax 06352 . 70629-30
www.stylite.de

Handelsregister Kaiserslautern HRB 30575
Geschäftsführer: Andre Keller, Gudrun Müller, Nigel Vickers, Ralf Becker

–

Oscar van Eijk

Oveas Functionality Provider
Zwaardenburg 63 – 3437 RJ Nieuwegein
T: +31(0)30 - 889 7812 – F: +31(0)30 - 889 9117
[http://oveas.com – mailto:info@oveas.com

-> …/…/…/…/redirect.php?go=http%3A%2F%2Foveas.com]

jaytraxx 2009-02-10 16:18:54 UTC #5

Hi Oscar,

I wouldn’t consider it as an abuse. We already do that in calendar => save the last state of user-calendars chosen.

Always remembering the highest uid was already what I thought once but I also read that this method is not reliable enough. Consider a user or admin doing something weird with its mailbox and the uids start by 1. Nobody will know that they have to resets eGW’s last saved uid. But besides that, thx a lot Klaus for “storming your brain” for this.

Oscar, thx also for your idea. The bad thing is that “recent” often gets cleared by the first process accessing the imap server. Therefore it could happen very often that

if (Recent || (!Recent && Unseen))

will result in false even if there are new mails.

I think I’ll stick on the first metioned method (UNSEEN + a non-persistant user cache). I use a tool in my office which does the same (for years) and I didn’t get angry with it till now

Thx for your responses.
Bye
christian

tt_oscar:

Wouldn’t you consider that ‘abuse’ of the preferences functionality?

Prefs are not designed fot that, so any future developer might expect all
exisiting
preferences to be visible, hence, there’s always a chance new fieldsnames
are introduced that
conflict with this kind of implementations.

Likely? I guess not… it’s just that I’m not fond of this kinda
constructions :-S

Just my 2c,

Oscar

----------------original message-----------------
From: “Klaus Leithoff” kl@stylite.de
To: oscar.van.eijk@oveas.com, "development of eGroupWare,for active
developers"
egroupware-developers@lists.sourceforge.net
Date: Tue, 10 Feb 2009 10:31:28 +0100

Another way would be to store the last notified uid with the preferences of
either
felamimail or notifications.
A preference to store and retrieve does not have to bee used and seen in
the prefernence
listing of
that application
You are able to set and retrieve the value in question with the preference
functionality.
So while you are within the session store the uids already notivied, and
update the
preference
with the last one notified. If there is no notified list with the session
check the last
notified uid, and
start of from there.

----------------ursprüngliche Nachricht-----------------
Von: “Oscar van Eijk” oscar.van.eijk@oveas.com
An: "development of eGroupWare,for active developers"
egroupware-developers@lists.sourceforge.net
Datum: Tue, 10 Feb 2009 08:14:05 +0100

Hi Cristian,

What about a combination:
if (Recent || (!Recent && Unseen)) {
notify();
}

You’ll have the same disadvantage, but it’ll occur less often.

Oscar

On Mon, 2009-02-09 at 14:22 -0800, jaytraxx wrote:

Hi all,

I’m currently working on the mail notifications and encountered that the
recent flag is not reliable enough to filter messages by. There are
several

reasons why and I just heard things like ‘Keep your hands off the recent
flag’ on many internet articles.

So, if nobody of the other devs objects I will do the following:

Filter the messages by the ‘UNSEEN’ flag, NOT ‘RECENT’

Notify on all ‘UNSEEN’ messages first

write all UIDs of messages being notified into the users session

Notify on all ‘UNSEEN’ and not already notified messages in further
steps

A very small disadvantage will be: The user gets notified again on all
’UNSEEN’ messages if he re-enters eGW. Yes, I could store the UIDs of the
messages already notified about into a table but I don’t want to create a
caching table like it had been before in eGW 1.2. This will be very ugly.

Comments welcome.

Bye
Christian

Oscar van Eijk

Oveas Functionality Provider
Zwaardenburg 63 – 3437 RJ Nieuwegein
T: +31(0)30 - 889 7812 – F: +31(0)30 - 889 9117
[http://oveas.com – mailto:info@oveas.com

-> http://oveas.com]

Create and Deploy Rich Internet Apps outside the browser with
Adobe®AIR™

software. With Adobe AIR, Ajax developers can use existing skills and code
to

build responsive, highly engaging applications that combine the power of
local

resources and data with the reach of the web. Download the Adobe AIR SDK
and

Ajax docs to start building applications
today-http://p.sf.net/sfu/adobe-com

eGroupWare-developers mailing list
eGroupWare-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/egroupware-developers

Stylite GmbH
[ open style of IT ]
Morschheimer Strasse 15
67292 Kirchheimbolanden

fon 06352 . 70629-0
fax 06352 . 70629-30
www.stylite.de

Handelsregister Kaiserslautern HRB 30575
Geschäftsführer: Andre Keller, Gudrun Müller, Nigel Vickers, Ralf Becker

–

Oscar van Eijk

Oveas Functionality Provider
Zwaardenburg 63 – 3437 RJ Nieuwegein
T: +31(0)30 - 889 7812 – F: +31(0)30 - 889 9117
[http://oveas.com – mailto:info@oveas.com

-> …/…/…/…/redirect.php?go=http%3A%2F%2Foveas.com]

Create and Deploy Rich Internet Apps outside the browser with Adobe®AIR™
software. With Adobe AIR, Ajax developers can use existing skills and code to
build responsive, highly engaging applications that combine the power of local
resources and data with the reach of the web. Download the Adobe AIR SDK and
Ajax docs to start building applications today-http://p.sf.net/sfu/adobe-com

eGroupWare-developers mailing list
eGroupWare-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/egroupware-developers

Oscar_van_Eijk-3 2009-02-10 19:55:58 UTC #6

Hi Christian,

The fact it has already been done doesn’t mean it is (was) no abuse, but
hey, it’s just my thoughts
About my suggestion, what I mailed was not exactly what I had in mind; a
bit more worked out, it would be:
if (! // Negate everything
that follows
($obj->Recent == ‘R’ || // Recent and seen or
($obj->Recent == ’ ’ && // not recent but
$obj->Unseen == ’ ')) // seen
)
{
notify();
}

Better change the IMap spec… whoever came up with those flags :-? you
have my vote for your implementation

Oscar

Hi Oscar,

I wouldn’t consider it as an abuse. We already do that in calendar => save
the last state of user-calendars chosen.

Always remembering the highest uid was already what I thought once but I
also read that this method is not reliable enough. Consider a user or admin
doing something weird with its mailbox and the uids start by 1. Nobody will
know that they have to resets eGW’s last saved uid. But besides that, thx a
lot Klaus for “storming your brain” for this.

Oscar, thx also for your idea. The bad thing is that “recent” often gets
cleared by the first process accessing the imap server. Therefore it could
happen very often that

if (Recent || (!Recent && Unseen))

will result in false even if there are new mails.

I think I’ll stick on the first metioned method (UNSEEN + a non-persistant
user cache). I use a tool in my office which does the same (for years) and I
didn’t get angry with it till now

Thx for your responses.
Bye
christian

tt_oscar wrote:

Wouldn’t you consider that ‘abuse’ of the preferences functionality?

Prefs are not designed fot that, so any future developer might expect all
exisiting
preferences to be visible, hence, there’s always a chance new fieldsnames
are introduced that
conflict with this kind of implementations.

Likely? I guess not… it’s just that I’m not fond of this kinda
constructions :-S

Just my 2c,

Oscar

From: “Klaus Leithoff” kl@stylite.de
To: oscar.van.eijk@oveas.com, "development of eGroupWare,for active
developers"
egroupware-developers@lists.sourceforge.net
Date: Tue, 10 Feb 2009 10:31:28 +0100

Another way would be to store the last notified uid with the preferences
of
either

felamimail or notifications.
A preference to store and retrieve does not have to bee used and seen in
the prefernence
listing of
that application
You are able to set and retrieve the value in question with the preference
functionality.
So while you are within the session store the uids already notivied, and
update the
preference
with the last one notified. If there is no notified list with the session
check the last
notified uid, and
start of from there.

Von: “Oscar van Eijk” oscar.van.eijk@oveas.com
An: "development of eGroupWare,for active developers"
egroupware-developers@lists.sourceforge.net
Datum: Tue, 10 Feb 2009 08:14:05 +0100

Hi Cristian,

What about a combination:
if (Recent || (!Recent && Unseen)) {
notify();
}

You’ll have the same disadvantage, but it’ll occur less often.

Oscar

Hi all,

I’m currently working on the mail notifications and encountered that the
recent flag is not reliable enough to filter messages by. There are
several

reasons why and I just heard things like ‘Keep your hands off the recent
flag’ on many internet articles.

So, if nobody of the other devs objects I will do the following:

Filter the messages by the ‘UNSEEN’ flag, NOT ‘RECENT’

Notify on all ‘UNSEEN’ messages first

write all UIDs of messages being notified into the users session

Notify on all ‘UNSEEN’ and not already notified messages in further
steps

A very small disadvantage will be: The user gets notified again on all
’UNSEEN’ messages if he re-enters eGW. Yes, I could store the UIDs of the
messages already notified about into a table but I don’t want to create a
caching table like it had been before in eGW 1.2. This will be very ugly.

Comments welcome.

Bye
Christian

Oscar van Eijk

Oveas Functionality Provider
Zwaardenburg 63 – 3437 RJ Nieuwegein
T: +31(0)30 - 889 7812 – F: +31(0)30 - 889 9117
[http://oveas.com – mailto:info@oveas.com mailto:info@oveas.com

-> http://oveas.com]

Create and Deploy Rich Internet Apps outside the browser with
Adobe®AIR™

software. With Adobe AIR, Ajax developers can use existing skills and
code
to

build responsive, highly engaging applications that combine the power of
local

resources and data with the reach of the web. Download the Adobe AIR SDK
and

Ajax docs to start building applications
today-http://p.sf.net/sfu/adobe-com

eGroupWare-developers mailing list
eGroupWare-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/egroupware-developers

Stylite GmbH
[ open style of IT ]
Morschheimer Strasse 15
67292 Kirchheimbolanden

fon 06352 . 70629-0
fax 06352 . 70629-30
www.stylite.de

Handelsregister Kaiserslautern HRB 30575
Geschäftsführer: Andre Keller, Gudrun Müller, Nigel Vickers, Ralf Becker

–

Oscar van Eijk

Oveas Functionality Provider
Zwaardenburg 63 – 3437 RJ Nieuwegein
T: +31(0)30 - 889 7812 – F: +31(0)30 - 889 9117
[http://oveas.com – mailto:info@oveas.com

-> …/…/…/…/redirect.php?go=http%3A%2F%2Foveas.com]

Create and Deploy Rich Internet Apps outside the browser with
Adobe®AIR™
software. With Adobe AIR, Ajax developers can use existing skills and code
to
build responsive, highly engaging applications that combine the power of
local
resources and data with the reach of the web. Download the Adobe AIR SDK
and
Ajax docs to start building applications
today-http://p.sf.net/sfu/adobe-com

eGroupWare-developers mailing list
eGroupWare-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/egroupware-developers

Oscar van Eijk

Oveas Functionality Provider
Zwaardenburg 63 – 3437 RJ Nieuwegein
T: +31(0)30 - 889 7812 – F: +31(0)30 - 889 9117
http://oveas.com – mailto:info@oveas.com

Oveas Functionality Provider