Missing error trap in calendar

Hans-Jurgen_Tappe 2009-10-01 16:58:01 UTC #1

Hi!

I recently had put some events into Nirvana when copying and moving an
existing event.

The existing event was sth. like “holidays” and has been inserted as a
single full-day even with daily recurrence until end of holidays.
(It could as well have been a single event just spanning the days.)

When copy-moving the event, I forgot to update the end of reecurrence
date and thus the events never show up.

Can we please add the following check in class.calendar_uiforms.inc.php
in order to prevent the user (me) from forgetting to update the
recurrence end date and thus creating invisible even entries?

if (($event[‘recur_type’] != MCAL_RECUR_NONE) &&
(isset($event[‘recur_enddate’]))) &&
($event[‘start’] > $event[‘recur_enddate’]))
{
$msg = lang(‘repetition’).": ".lang(‘Error: Starttime has to be before
the endtime !!!’);
$button = ‘’;
break;
}

Thanks a lot!
Hans-Jürgen

P.S.: Be free to optimize the condition statement.

Come build with us! The BlackBerry® Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9-12, 2009. Register now!
http://p.sf.net/sfu/devconf

eGroupWare-developers mailing list
eGroupWare-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/egroupware-developers

Ralf_Becker_6 2009-10-01 19:27:02 UTC #2

Hi Hans-Jürgen,

commited that one to.

Thanks again

Btw. have you seen the new calendar filters in trunk (by participant
status or event ownership), you might want to implement them in your
calendar module too.

Ralf

Hans-Juergen Tappe schrieb:

Hi!

I recently had put some events into Nirvana when copying and moving an
existing event.

The existing event was sth. like “holidays” and has been inserted as a
single full-day even with daily recurrence until end of holidays.
(It could as well have been a single event just spanning the days.)

When copy-moving the event, I forgot to update the end of reecurrence
date and thus the events never show up.

Can we please add the following check in class.calendar_uiforms.inc.php
in order to prevent the user (me) from forgetting to update the
recurrence end date and thus creating invisible even entries?

if (($event[‘recur_type’] != MCAL_RECUR_NONE) &&
(isset($event[‘recur_enddate’]))) &&
($event[‘start’] > $event[‘recur_enddate’]))
{
$msg = lang(‘repetition’).": ".lang(‘Error: Starttime has to be before
the endtime !!!’);
$button = ‘’;
break;
}

Thanks a lot!
Hans-Jürgen

P.S.: Be free to optimize the condition statement.

Come build with us! The BlackBerry® Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9-12, 2009. Register now!
http://p.sf.net/sfu/devconf

eGroupWare-developers mailing list
eGroupWare-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/egroupware-developers

–
Ralf Becker
Director Software Development

Stylite GmbH
[open style of IT]

Morschheimer Strasse 15
67292 Kirchheimbolanden

fon +49 (0) 6352 70629-0
fax +49 (0) 6352 70629-30
mailto: rb@stylite.de

www.stylite.de
www.egroupware.org

Geschäftsführer Andre Keller,
Gudrun Müller, Ralf Becker
Registergericht Kaiserslautern HRB 30575
Umsatzsteuer-Id / VAT-Id: DE214280951

eGroupWare-developers mailing list
eGroupWare-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/egroupware-developers

Hans-Jurgen_Tappe 2009-10-02 09:42:22 UTC #3

Hi Ralf!

Ralf Becker schrieb:

commited that one to.

Great, thank you.

Btw. have you seen the new calendar filters in trunk (by participant
status or event ownership), you might want to implement them in your
calendar module too.

I’ll put that on my list, but there are already so many options in the
modules, it may confuse the users. Let’s see.

Best regards,
Hans-Jürgen

eGroupWare-developers mailing list
eGroupWare-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/egroupware-developers

Ralf_Becker_6 2009-10-03 06:20:53 UTC #4

Hi Hans-Jürgen,

Hans-Juergen Tappe schrieb:

Hi Ralf!

Ralf Becker schrieb:

commited that one to.

Great, thank you.

Btw. have you seen the new calendar filters in trunk (by participant
status or event ownership), you might want to implement them in your
calendar module too.

I’ll put that on my list, but there are already so many options in the
modules, it may confuse the users.

That option is important, if you want to show a public calendar (eg. of
a pseudo user), but dont want everyone to “write into” (invite) that
calendar: using a status filter accepted, solves that situation.

Ralf

Ralf Becker
Director Software Development

Stylite GmbH
[open style of IT]

Morschheimer Strasse 15
67292 Kirchheimbolanden

fon +49 (0) 6352 70629-0
fax +49 (0) 6352 70629-30
mailto: rb@stylite.de

www.stylite.de
www.egroupware.org

Geschäftsführer Andre Keller,
Gudrun Müller, Ralf Becker
Registergericht Kaiserslautern HRB 30575
Umsatzsteuer-Id / VAT-Id: DE214280951

eGroupWare-developers mailing list
eGroupWare-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/egroupware-developers

Hans-Jurgen_Tappe 2009-10-03 06:54:28 UTC #5

Hi Ralf!

Ralf Becker schrieb:

Btw. have you seen the new calendar filters in trunk (by participant
status or event ownership), you might want to implement them in your
calendar module too.
That option is important, if you want to show a public calendar (eg. of
a pseudo user), but dont want everyone to “write into” (invite) that
calendar: using a status filter accepted, solves that situation.

OK, understood. I’ll do (but give me some time).

Best regards,
Hans-Jürgen

eGroupWare-developers mailing list
eGroupWare-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/egroupware-developers