MSIE stack overflow error with trunk@41074

Anthony_Messina 2013-01-17 22:38:30 UTC #1

The following patch prevents the “Stack overflow at line: 291” error received
when using MSIE 8. It appears to me that there was an extra ‘=’ sign in
there, which errored out on Windows machines when using eMail or certain
features of the calendar.

http://svn.egroupware.org/egroupware/trunk@41074

Thanks. -A

diff --git a/phpgwapi/js/jsapi/jsapi.js b/phpgwapi/js/jsapi/jsapi.js
index 2b025d5…3884066 100644
— a/phpgwapi/js/jsapi/jsapi.js
+++ b/phpgwapi/js/jsapi/jsapi.js
@@ -286,7 +286,7 @@ window.egw_getFramework = function()
{
return framework;
}

  else if (typeof window.parent.egw_getFramework != "undefined" &&

window !== window.parent)

  else if (typeof window.parent.egw_getFramework != "undefined" &&

window != window.parent)
{
return window.parent.egw_getFramework();
}

–
Anthony - http://messinet.com - http://messinet.com/~amessina/gallery
8F89 5E72 8DF0 BCF0 10BE 9967 92DC 35DC B001 4A4E

Leithoff_Klaus 2013-01-18 08:32:48 UTC #2

since this was introduced by Nathan, I think he should say something about his intention
about using !== here. It should be supported by Javascript 1.2 and above.
I guess != would do the same, as we may assume: if they are unequal, the type does
not make any difference.

kl@stylite.de
Stylite AG
[ open style of IT ]
Morschheimer Strasse 15
67292 Kirchheimbolanden
fon 06352 . 70629-0
fax 06352 . 70629-30
www.stylite.de | www.egroupware.org

Managing Directors: Andre Keller | Ralf Becker | Gudrun Mueller
Chairman of the supervisory board: Prof. Dr. Birger Leon Kropshofer

VAT DE214280951 | Registered HRB 31158 Kaiserslautern Germany

Leithoff_Klaus 2013-01-18 09:06:13 UTC #3

I should read commit messages before I engage in tickets. Nathan already did it with
r41311: Fix for IE overflow from Anthony Messina
Klaus

ngegw 2013-01-18 15:17:04 UTC #4

Sorry, end of the day yesterday. Pretty sure it was just a typo.
Fixed, thanks Anthony.

Anthony_Messina 2013-01-18 21:24:56 UTC #5

I should read commit messages before I engage in tickets. Nathan already did
it with r41311: Fix for IE overflow from Anthony Messina
Klaus

Sorry, end of the day yesterday. Pretty sure it was just a typo.
Fixed, thanks Anthony.’

No problem at all. I just pulled down an update and noticed that things
weren’t working properly at work, but whorked splendidly everywhere else, as
usual

Thank you for the fix! -A

–
Anthony - http://messinet.com - http://messinet.com/~amessina/gallery
8F89 5E72 8DF0 BCF0 10BE 9967 92DC 35DC B001 4A4E