Opening documents with Collabora disabled fails

[J_Roeleveld]

Disabled “Collabora” application as with it enabled, I am unable to open documents. (Test environment has no internet access and I have not had time to set up Collabora locally yet)

I then am still unable to open document. Logs show:

==> nginx/egw_test.antarean.org.error_log <==
2017/12/18 06:50:06 [error] 1884#1884: *214 FastCGI sent in stderr: "PHP message: Database error (EGroupware\Api\Db\Exception\InvalidSql): Invalid SQL: SELECT collab_member_id FROM egw_collab_member  ORDER BY `collab_member_id` DESC LIMIT 1;
ERROR:  operator does not exist: ` integer
LINE 1: ...collab_member_id FROM egw_collab_member  ORDER BY `collab_me...
                                                             ^
HINT:  No operator matches the given name and argument type(s). You might need to add explicit type casts. (-1)
PHP message: #0 /var/www/egw.antarean.org/egroupware/api/src/Db/Deprecated.php(64): EGroupware\Api\Db->query('SELECT collab_m...', NULL, NULL, false, -1, false, 2, true)
PHP message: #1 /var/www/egw.antarean.org/egroupware/api/src/Db.php(2102): EGroupware\Api\Db\Deprecated->query('SELECT collab_m...', 541, '/var/www/egw.an...', false, -1, false, 2)
PHP message: #2 /var/www/egw.antarean.org/egroupware/filemanager/inc/class.filemanager_collab_bo.inc.php(544): EGroupware\Api\Db->select('egw_collab_memb...', 'collab_member_i...', '', 541, '/var/www/egw.an...', false, 'ORDER BY `colla...')
PHP message: #3 /var/www/egw.antarean.org/egroupware/filemanager/inc/class.filemanager_collab_bo.inc.php(86): filemanager_collab_bo->MEMBER_getLastMember()
PHP message: #4 /var/www/egw.antarean.org/egroupware/filemanager/inc/class.filemanager_collab.inc.php(59): filemanager_collab_bo->initSession('9a87dcc69d39fb5...')
PHP message: #5 /var/www/egw.antarean.org/egroupware/filemanager/inc/class.filemanager_collab.inc.php(105): filemanager_collab->join_session('9a87dcc69d39fb5...', '6')
PHP message: #6 /var/www/egw.antarean.org/egroupware/index.php(155): filemanager_collab->poll()
PHP message: #7 {main}
PHP message: # Instance=default, User=joost, Request=POST http://egw_test.antarean.org/index.php?menuaction=filemanager.filemanager_collab.poll, User-agent=Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Firefox/52.0" while reading response header from upstream, client: 10.55.16.44, server: egw_test.anta

This seems to be caused in file “filemanager/inc/class.filemanager_collab_bo.inc.php” at line “544” by quotes. The following diff fixes this:

diff --git a/filemanager/inc/class.filemanager_collab_bo.inc.php b/filemanager/inc/class.filemanager_collab_bo.inc.php
index cdb01817d1..1420ff80ee 100644
--- a/filemanager/inc/class.filemanager_collab_bo.inc.php
+++ b/filemanager/inc/class.filemanager_collab_bo.inc.php
@@ -541,7 +541,7 @@ class filemanager_collab_bo
                                __LINE__,
                                __FILE__,
                                false,
-                               "ORDER BY `collab_member_id` DESC LIMIT 1;"
+                               "ORDER BY collab_member_id DESC LIMIT 1;"
                );
                $last_row = $query->fetchRow();
                return is_array($last_row)? $last_row['collab_member_id']: 0;
@@ -556,4 +556,4 @@ class filemanager_collab_bo
                $date = new DateTime();
                return $date->getTimestamp();
        }
-}
\ No newline at end of file
+}

[J_Roeleveld]

Hi,

Going through the logs, I found a few other errors as well which occur when opening a document. Double quotes ( " ) are forcing PostgreSQL to see the quoted part as a field name. This causes issues.
The following diff resolves these (and the previous error):

diff --git a/filemanager/inc/class.filemanager_collab_bo.inc.php b/filemanager/inc/class.filemanager_collab_bo.inc.php
index cdb01817d1..8831c4cb78 100644
--- a/filemanager/inc/class.filemanager_collab_bo.inc.php
+++ b/filemanager/inc/class.filemanager_collab_bo.inc.php
@@ -162,7 +162,7 @@ class filemanager_collab_bo
                                __LINE__,
                                __FILE__,
                                'filemanager');
-               $where_query = 'collab_es_id ="'.$es_id.'" AND collab_optype != "AddMember" AND'.
+               $where_query = 'collab_es_id =\''.$es_id.'\' AND collab_optype != "AddMember" AND'.
                                ' collab_optype != "RemoveMember" AND collab_optype !="AddCursor" AND'.
                                ' collab_optype !="RemoveCursor"';
                // cleanup the op table
@@ -333,7 +333,7 @@ class filemanager_collab_bo
                $query = $this->db->select(
                                self::OP_TABLE,
                                'collab_opspec',
-                               'collab_es_id ="'. $es_id.'" AND collab_seq >'.$seq_head,
+                               'collab_es_id =\''. $es_id.'\' AND collab_seq >'.$seq_head,
                                __LINE__,
                                __FILE__,
                                false, 'ORDER BY collab_seq ASC','filemanager');
@@ -415,7 +415,7 @@ class filemanager_collab_bo
                $this->db->update(
                                self::MEMBER_TABLE,
                                array('collab_is_active' => $is_active),
-                               'collab_es_id ="'.$es_id.'" AND collab_member_id="'.$member_id.'"',
+                               'collab_es_id =\''.$es_id.'\' AND collab_member_id=\''.$member_id.'\'',
                                __LINE__,
                                __FILE__,
                                'filemanager'
@@ -541,7 +541,7 @@ class filemanager_collab_bo
                                __LINE__,
                                __FILE__,
                                false,
-                               "ORDER BY `collab_member_id` DESC LIMIT 1;"
+                               "ORDER BY collab_member_id DESC LIMIT 1;"
                );
                $last_row = $query->fetchRow();
                return is_array($last_row)? $last_row['collab_member_id']: 0;
@@ -556,4 +556,4 @@ class filemanager_collab_bo
                $date = new DateTime();
                return $date->getTimestamp();
        }
-}
\ No newline at end of file
+}