[PATCH] SiteMgr broken after commit 40106

Anthony_Messina 2012-08-14 11:47:00 UTC #1

The following patch allows SiteMgr to work properly (the page rendering
function didn’t have access to $sitemgr_info):

diff --git a/sitemgr/sitemgr-site/inc/class.site_controler.inc.php
b/sitemgr/sitemgr-site/inc/class.site_controler.inc.php
index c76e7a8…a7604f2 100644
— a/sitemgr/sitemgr-site/inc/class.site_controler.inc.php
+++ b/sitemgr/sitemgr-site/inc/class.site_controler.inc.php
@@ -118,7 +118,7 @@ class site_controler
*/
public function processRequest()
{

          global $page, $objbo, $objui, $Common_BO;

          global $page, $objbo, $objui, $sitemgr_info, $Common_BO;

          $page = CreateObject('sitemgr.Page_SO');

@@ -243,4 +243,4 @@ interface site_renderer
* Generate page using the template (SiteMgr UI method)
*/
public function generatePage();
-}
\ No newline at end of file
+}

–
Anthony - http://messinet.com - http://messinet.com/~amessina/gallery
8F89 5E72 8DF0 BCF0 10BE 9967 92DC 35DC B001 4A4E

Leithoff_Klaus 2012-08-14 12:31:25 UTC #2

Thx, I will put that one in.
There may be other issues, please feel free to report them here.

kl@stylite.de
Stylite AG
[ open style of IT ]
Morschheimer Strasse 15
67292 Kirchheimbolanden
fon 06352 . 70629-0
fax 06352 . 70629-30
www.stylite.de | www.egroupware.org

Managing Directors: Andre Keller | Ralf Becker | Gudrun Mueller
Chairman of the supervisory board: Prof. Dr. Birger Leon Kropshofer

VAT DE214280951 | Registered HRB 31158 Kaiserslautern Germany

Anthony_Messina 2012-08-14 12:38:16 UTC #3

Thx, I will put that one in.
There may be other issues, please feel free to report them here.

kl@stylite.de
Stylite AG
[ open style of IT ]
Morschheimer Strasse 15
67292 Kirchheimbolanden
fon 06352 . 70629-0
fax 06352 . 70629-30
www.stylite.de | www.egroupware.org

Should probably also only enable caching for production mode, or else you get
what I have at http://messinet.com – after editing SiteManager as an admin,
the cached instance shows up on the public page:

@@ -222,7 +222,7 @@ class site_controler
error_log(METHOD."() rendered page $cache_name in
".number_format(microtime(true)-$GLOBALS[‘egw_info’][‘flags’]
[‘page_start_time’], 3).‘sec’);

            // only use cache for Production site and GET requests

-// if (isset($cache_name) && $this->mode == ‘Production’ &&
$_SERVER[‘REQUEST_METHOD’] == ‘GET’)

          if (isset($cache_name) && $this->mode == 'Production' &&

$_SERVER[‘REQUEST_METHOD’] == ‘GET’)
{
egw_cache::setInstance(CLASS, $cache_name,
ob_get_contents(), $cache_time = 7200);
}

–
Anthony - http://messinet.com - http://messinet.com/~amessina/gallery
8F89 5E72 8DF0 BCF0 10BE 9967 92DC 35DC B001 4A4E

Ralf_Becker_Stylite 2012-08-14 12:43:36 UTC #4

Hi Anthony,

caching should have been completly disabled, because it is far from
ready. Really disabled it now with a commit.

Ralf

Thx, I will put that one in.
There may be other issues, please feel free to report them here.

kl@stylite.de
Stylite AG
[ open style of IT ]
Morschheimer Strasse 15
67292 Kirchheimbolanden
fon 06352 . 70629-0
fax 06352 . 70629-30
www.stylite.de | www.egroupware.org

Should probably also only enable caching for production mode, or else you get
what I have at http://messinet.com – after editing SiteManager as an admin,
the cached instance shows up on the public page:

@@ -222,7 +222,7 @@ class site_controler
error_log(METHOD."() rendered page $cache_name in
".number_format(microtime(true)-$GLOBALS[‘egw_info’][‘flags’]
[‘page_start_time’], 3).‘sec’);
             // only use cache for Production site and GET requests
-// if (isset($cache_name) && $this->mode == ‘Production’ &&
$_SERVER[‘REQUEST_METHOD’] == ‘GET’)
          if (isset($cache_name) && $this->mode == 'Production' &&
$_SERVER[‘REQUEST_METHOD’] == ‘GET’)
{
egw_cache::setInstance(CLASS, $cache_name,
ob_get_contents(), $cache_time = 7200);
}

Live Security Virtual Conference
Exclusive live event will cover all the ways today’s security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/

eGroupWare-developers mailing list
eGroupWare-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/egroupware-developers

–
Ralf Becker
Director Software Development

Stylite AG

Morschheimer Strasse 15 | Tel. +49 6352 70629 0
D-67292 Kirchheimbolanden | Fax. +49 6352 70629 30

Email: rb@stylite.de

www.stylite.de | www.egroupware.org

Managing Directors: Andre Keller | Ralf Becker | Gudrun Mueller
Chairman of the supervisory board: Prof. Dr. Birger Leon Kropshofer

VAT DE214280951 | Registered HRB 31158 Kaiserslautern Germany

Live Security Virtual Conference
Exclusive live event will cover all the ways today’s security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/

eGroupWare-developers mailing list
eGroupWare-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/egroupware-developers

Leithoff_Klaus 2012-08-14 12:53:45 UTC #5

As the caching is not ready yet, he switched it off completely with r40137: disabled caching, until it is ready

kl@stylite.de
Stylite AG
[ open style of IT ]
Morschheimer Strasse 15
67292 Kirchheimbolanden
fon 06352 . 70629-0
fax 06352 . 70629-30
www.stylite.de | www.egroupware.org

Managing Directors: Andre Keller | Ralf Becker | Gudrun Mueller
Chairman of the supervisory board: Prof. Dr. Birger Leon Kropshofer

VAT DE214280951 | Registered HRB 31158 Kaiserslautern Germany

Anthony_Messina 2012-08-14 12:54:45 UTC #6

Hi Anthony,

caching should have been completly disabled, because it is far from
ready. Really disabled it now with a commit.

Ralf

Thanks, Ralf. I’ll pull down that rev and hold onto it for a while…

-A

–
Anthony - http://messinet.com - http://messinet.com/~amessina/gallery
8F89 5E72 8DF0 BCF0 10BE 9967 92DC 35DC B001 4A4E