Readonlys and ALL : Bug and patch (?)

Raphael_Alla-2 2006-10-29 11:47:15 UTC #1

Hi,

An undocumented feature in etemplate seems to be when the key ALL
is set in the readonlys array. This turns the whole template into a
readonly template, and all entries and inputs are readonly.

It came however to my attention that this behaviour will not work for
extensions, as the code only checks whether $readonlys[$name] is set.
Because the feature is undocumented I am unsure whether this is a bug
or not.

An easy way to fix this is to replace line 833 (as per the version of
CVS head) of etemplate/inc/class.uietemplates.inc.php by something
along those lines:
$_readonlys = $readonlys[$name];
if ($readonlys[‘ALL’]) $_readonlys = true;
$extra_label =
$this->extensionPreProcess($type,$form_name,$value,$cell,$_readonlys);

I hope it helps

Raphael

Raphael Alla
Mitija Australia
+61 4 15 678 576
http://www.mitija.com

Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642

eGroupWare-developers mailing list
eGroupWare-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/egroupware-developers

ralfbecker_dr 2006-10-29 17:43:01 UTC #2

Hi Raphael,

so far this is only internally used to make whole templates readonly.
Not sure if I want to make that a feature, do you need that?

Ralf

Raphael Alla schrieb:

Hi,

An undocumented feature in etemplate seems to be when the key ALL
is set in the readonlys array. This turns the whole template into a
readonly template, and all entries and inputs are readonly.

It came however to my attention that this behaviour will not work for
extensions, as the code only checks whether $readonlys[$name] is set.
Because the feature is undocumented I am unsure whether this is a bug
or not.

An easy way to fix this is to replace line 833 (as per the version of
CVS head) of etemplate/inc/class.uietemplates.inc.php by something
along those lines:
$_readonlys = $readonlys[$name];
if ($readonlys[‘ALL’]) $_readonlys = true;
$extra_label =
$this->extensionPreProcess($type,$form_name,$value,$cell,$_readonlys);

I hope it helps

Raphael

–
eGroupWare Training & Support ==> http://www.egroupware-support.de
1.2 Release Offer: 250Euro for a Standard Update or Installation
including 1h Telefonsupport und ein gedrucktes deutsches Handbuch

eGroupWare-developers mailing list
eGroupWare-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/egroupware-developers

Raphael_Alla-2 2006-10-29 23:22:46 UTC #3

I discovered the feature when looking at the code, and found it convenient
as it allows to use the same e-template for both viewing and editing a form.
I started using it in my code and stumbled on the issue when using "date"
widgets.

One of the great things about e-templates is that widgets update the way
they display each other when they are read-only or editable; therefore a
template “looks good” in both situations. In my view this is a useful
feature.

Hi Raphael,

so far this is only internally used to make whole templates readonly.
Not sure if I want to make that a feature, do you need that?

Ralf

Raphael Alla schrieb:

Hi,

An undocumented feature in etemplate seems to be when the key ALL
is set in the readonlys array. This turns the whole template into a
readonly template, and all entries and inputs are readonly.

It came however to my attention that this behaviour will not work for
extensions, as the code only checks whether $readonlys[$name] is set.
Because the feature is undocumented I am unsure whether this is a bug
or not.

An easy way to fix this is to replace line 833 (as per the version of
CVS head) of etemplate/inc/class.uietemplates.inc.php by something
along those lines:
$_readonlys = $readonlys[$name];
if ($readonlys[‘ALL’]) $_readonlys = true;
$extra_label =
$this->extensionPreProcess($type,$form_name,$value,$cell,$_readonlys);

I hope it helps

Raphael

–
eGroupWare Training & Support ==> http://www.egroupware-support.de
1.2 Release Offer: 250Euro for a Standard Update or Installation
including 1h Telefonsupport und ein gedrucktes deutsches Handbuch

Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job
easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642

eGroupWare-developers mailing list
eGroupWare-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/egroupware-developers

–
Raphael Alla
Mitija Australia
+61 4 15 678 576
http://www.mitija.com

ralfbecker_dr 2006-10-30 06:27:49 UTC #4

Hi Raphael,

Raphael Alla schrieb:

I discovered the feature when looking at the code, and found it
convenient as it allows to use the same e-template for both viewing and
editing a form. I started using it in my code and stumbled on the issue
when using “date” widgets.

One of the great things about e-templates is that widgets update the way
they display each other when they are read-only or editable; therefore a
template “looks good” in both situations. In my view this is a useful
feature.

Ok, then let’s make it an official feature.

Ralf

Hi Raphael,

so far this is only internally used to make whole templates readonly.
Not sure if I want to make that a feature, do you need that?

Ralf

Raphael Alla schrieb:
> Hi,
>
> An undocumented feature in etemplate seems to be when the key __ALL__
> is set in the readonlys array. This turns the whole template into a
> readonly template, and all entries and inputs are readonly.
>
> It came however to my attention that this behaviour will not work for
> extensions, as the code only checks whether $readonlys[$name] is set.
> Because the feature is undocumented I am unsure whether this is a bug
> or not.
>
> An easy way to fix this is to replace line 833 (as per the version of
> CVS head) of etemplate/inc/class.uietemplates.inc.php by something
> along those lines:
>                 $_readonlys = $readonlys[$name];
>                 if ($readonlys['__ALL__']) $_readonlys = true;
>                 $extra_label =
> $this->extensionPreProcess($type,$form_name,$value,$cell,$_readonlys);
>
> I hope it helps
>
> Raphael

--
eGroupWare Training & Support ==> http://www.egroupware-support.de
1.2 Release Offer: 250Euro for a Standard Update or Installation
including 1h Telefonsupport und ein gedrucktes deutsches Handbuch

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services,
security?
Get stuff done quickly with pre-integrated technology to make your
job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache
Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
<http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642>
_______________________________________________
eGroupWare-developers mailing list
eGroupWare-developers@lists.sourceforge.net
<mailto:eGroupWare-developers@lists.sourceforge.net>
https://lists.sourceforge.net/lists/listinfo/egroupware-developers

–
Raphael Alla
Mitija Australia
+61 4 15 678 576
http://www.mitija.com http://www.mitija.com

eGroupWare-developers mailing list
eGroupWare-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/egroupware-developers

Raphael_Alla-2 2006-10-30 08:36:58 UTC #5

Great

Hi Raphael,

Raphael Alla schrieb:

I discovered the feature when looking at the code, and found it
convenient as it allows to use the same e-template for both viewing and
editing a form. I started using it in my code and stumbled on the issue
when using “date” widgets.

One of the great things about e-templates is that widgets update the way
they display each other when they are read-only or editable; therefore a
template “looks good” in both situations. In my view this is a useful
feature.

Ok, then let’s make it an official feature.

Ralf
R.
Hi Raphael,

so far this is only internally used to make whole templates
readonly.
Not sure if I want to make that a feature, do you need that?

Ralf

Raphael Alla schrieb:
> Hi,
>
> An undocumented feature in etemplate seems to be when the key
ALL
> is set in the readonlys array. This turns the whole template into
a
> readonly template, and all entries and inputs are readonly.
>
> It came however to my attention that this behaviour will not work
for
> extensions, as the code only checks whether $readonlys[$name] is
set.
> Because the feature is undocumented I am unsure whether this is a
bug
> or not.
>
> An easy way to fix this is to replace line 833 (as per the version
of
> CVS head) of etemplate/inc/class.uietemplates.inc.php by something
> along those lines:
>                 $_readonlys = $readonlys[$name];
>                 if ($readonlys['__ALL__']) $_readonlys = true;
>                 $extra_label =
>
$this->extensionPreProcess($type,$form_name,$value,$cell,$_readonlys);
>
> I hope it helps
>
> Raphael

--
eGroupWare Training & Support ==> http://www.egroupware-support.de
1.2 Release Offer: 250Euro for a Standard Update or Installation
including 1h Telefonsupport und ein gedrucktes deutsches Handbuch
Using Tomcat but need to do more? Need to support web services,
security?
Get stuff done quickly with pre-integrated technology to make your
job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache
Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
<
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642>
_______________________________________________
eGroupWare-developers mailing list
eGroupWare-developers@lists.sourceforge.net
<mailto:eGroupWare-developers@lists.sourceforge.net>
https://lists.sourceforge.net/lists/listinfo/egroupware-developers
–
Raphael Alla
Mitija Australia
+61 4 15 678 576
http://www.mitija.com http://www.mitija.com
Using Tomcat but need to do more? Need to support web services,
security?
Get stuff done quickly with pre-integrated technology to make your job
easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache
Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642

eGroupWare-developers mailing list
eGroupWare-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/egroupware-developers

–
eGroupWare Training & Support ==> http://www.egroupware-support.de
1.2 Release Offer: 250Euro for a Standard Update or Installation
including 1h Telefonsupport und ein gedrucktes deutsches Handbuch

Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job
easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642

eGroupWare-developers mailing list
eGroupWare-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/egroupware-developers

–
Raphael Alla
Mitija Australia
+61 4 15 678 576
http://www.mitija.com