Small bug in class.link_widget.inc.php / patch proposed

[egw-dev]

Hello,

In etemplates V1, on the link-list widgets, links to files are not
correctly populated, thus leading to 404 errors…

In the class.link_widget.inc.php , function pre_process, after the line
328 in the case ‘link-list’, may you please add this line which corrects
file links on etemplates v1…

// Add the link towards the file in the link list…
$value[$row][‘view’] = egw::link(’/webdav.php’.$value[$row][‘icon’]);

which gives this block…

---

if ($link[‘app’] == egw_link::VFS_APPNAME)
{
$value[$row][‘target’] = ‘_blank’;
$value[$row][‘label’] = ‘Delete’;
$value[$row][‘help’] = lang(‘Delete this file’);
if ($value[‘link_list_format’] != ‘text’)
{
$value[$row][‘title’] = preg_replace(’/: ([^
]+) /’,’: ',$value[$row][‘title’]); // remove mime-type, it’s alread
in the icon
}
$value[$row][‘icon’] =
egw_link::vfs_path($link[‘app2’],$link[‘id2’],$link[‘id’],true);

                 // Add the link towards the file in the link list..
                 $value[$row]['view'] = 

egw::link(’/webdav.php’.$value[$row][‘icon’]);
}

---

Thank you,

Thomas

---

Mobile security can be enabling, not merely restricting. Employees who
bring their own devices (BYOD) to work are irked by the imposition of MDM
restrictions. Mobile Device Manager Plus allows you to control only the
apps on BYO-devices by containerizing them, leaving personal data untouched!
https://ad.doubleclick.net/ddm/clk/304595813;131938128;j

---

eGroupWare-developers mailing list
eGroupWare-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/egroupware-developers

[Ralf_Becker_Stylite]

Hallo Thomas,

EGroupware sources have been moved to Github:

https://github.com/EGroupware/egroupware

of for 14.3

https://github.com/EGroupware/egroupware/tree/14.2

Please open a pull request there.

Ralf

Hello,

In etemplates V1, on the link-list widgets, links to files are not
correctly populated, thus leading to 404 errors…

In the class.link_widget.inc.php , function pre_process, after the line
328 in the case ‘link-list’, may you please add this line which corrects
file links on etemplates v1…

// Add the link towards the file in the link list…
$value[$row][‘view’] = egw::link(’/webdav.php’.$value[$row][‘icon’]);

which gives this block…

---

if ($link[‘app’] == egw_link::VFS_APPNAME)
{
$value[$row][‘target’] = ‘_blank’;
$value[$row][‘label’] = ‘Delete’;
$value[$row][‘help’] = lang(‘Delete this file’);
if ($value[‘link_list_format’] != ‘text’)
{
$value[$row][‘title’] = preg_replace(’/: ([^
]+) /’,’: ',$value[$row][‘title’]); // remove mime-type, it’s alread
in the icon
}
$value[$row][‘icon’] =
egw_link::vfs_path($link[‘app2’],$link[‘id2’],$link[‘id’],true);

                 // Add the link towards the file in the link list..
                 $value[$row]['view'] = 

egw::link(’/webdav.php’.$value[$row][‘icon’]);
}

---

Thank you,

Thomas

–
Ralf Becker
Director Software Development

Stylite AG

Isaac-Fulda-Allee 9 | Tel. +49 6131 32702-0
D-55124 Mainz | Fax. +49 6131 32702-70

Email: rb@stylite.de

www.stylite.de | www.egroupware.org

Managing Directors: Andre Keller | Ralf Becker | Gudrun Mueller
Chairman of the supervisory board: Prof. Dr. Birger Leon Kropshofer

VAT DE214280951 | Registered HRB 46224 Mainz Germany