SMS notifications backend - preliminary version

Aleksander_Adamowsk2 2007-12-14 00:06:18 UTC #1

Hi!

I’m attaching a preliminary version of the SMS backend for notifications app.

It uses the /usr/sbin/sendsms script (from the smstools package:
http://smstools.meinemullemaus.de/) to send out SMS notifications to
recipients who have their cell number set in the eGW addressbook
repository of user accounts.

This is most useful with accounts from LDAP database, where the
"mobile" LDAP attribute is automatically used.

The sms backend has yet to be placed in the notifications app’s
backend chains. It is the decision of Christian, the author of new
notifications app, how to implement it.

I’m also sending sms_backend_chain.patch, which shows how to insert
the sms backend into the “all” chain.

–
Best Regards,
Aleksander Adamowski
http://olo.org.pl

jaytraxx 2007-12-14 07:47:34 UTC #2

Hi Aleksander,

wow, you’re faaast ! I will integrate it as soon as possible. There will be some minor design changes in future for all backends and I will also apply that to your backend if you allow … There will be also the possibility to enable/disable backends in future, so the massive choices of available chains could be reduced by the admin.

Btw, your patch for modifying the chains bellow is in the wrong direction (it removes the sms backend from all instead of adding sms notification).

Bye
Christian

Aleksander Adamowski-3:

Hi!

I’m attaching a preliminary version of the SMS backend for notifications app.

It uses the /usr/sbin/sendsms script (from the smstools package:
http://smstools.meinemullemaus.de/) to send out SMS notifications to
recipients who have their cell number set in the eGW addressbook
repository of user accounts.

This is most useful with accounts from LDAP database, where the
"mobile" LDAP attribute is automatically used.

The sms backend has yet to be placed in the notifications app’s
backend chains. It is the decision of Christian, the author of new
notifications app, how to implement it.

I’m also sending sms_backend_chain.patch, which shows how to insert
the sms backend into the “all” chain.

–
Best Regards,
Aleksander Adamowski
http://olo.org.pl

— class.notification.inc.php 2007-12-13 13:44:49.000000000 +0100
+++ class.notification.inc.php 2007-12-13 12:52:18.000000000 +0100
@@ -52,7 +52,7 @@
‘popup_and_email’ => array(‘popup’ => ‘continue’, ‘email’ => ‘stop’),
‘winpopup_and_email’ => array(‘winpopup’ => ‘continue’, ‘email’ => ‘stop’),
‘egwpopup_and_winpopup’ => array(‘popup’ => ‘continue’, ‘winpopup’ => ‘stop’),
  'all' => array('sms' => 'continue', 'popup' => 'continue', 'winpopup' => 'continue', 'email' => 'stop'),
  'all' => array('popup' => 'continue', 'winpopup' => 'continue', 'email' => 'stop'),
);

/**
SF.Net email is sponsored by:
Check out the new SourceForge.net Marketplace.
It’s the best place to buy or sell services
for just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace

eGroupWare-developers mailing list
eGroupWare-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/egroupware-developers

Aleksander_Adamowsk2 2007-12-14 10:36:24 UTC #3

Hi Aleksander,

wow, you’re faaast ! I will integrate it as soon as possible. There will be
some minor design changes in future for all backends and I will also apply
that to your backend if you allow …

No problem, do whatever you wish, but please pay attention to
untrusted data escaping.

Btw, your patch for modifying the chains bellow is in the wrong direction
(it removes the sms backend from all instead of adding sms notification).

Yeah, I got the patch reversed by mistake… It should be exactly the
other way around. You can use the “-R” option to the patch utility in
order to inverse its patching logic.

–
Best Regards,
Aleksander Adamowski
http://olo.org.pl

SF.Net email is sponsored by:
Check out the new SourceForge.net Marketplace.
It’s the best place to buy or sell services
for just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace

eGroupWare-developers mailing list
eGroupWare-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/egroupware-developers

jaytraxx 2007-12-14 10:47:10 UTC #4

Forgot something:
Thanks !

This backend will be very valuable…

Bye
Christian

Aleksander Adamowski-3:

On 12/14/07, jaytraxx christian@jaytraxx.de wrote:

Hi Aleksander,

wow, you’re faaast ! I will integrate it as soon as possible. There will be
some minor design changes in future for all backends and I will also apply
that to your backend if you allow …

No problem, do whatever you wish, but please pay attention to
untrusted data escaping.

Btw, your patch for modifying the chains bellow is in the wrong direction
(it removes the sms backend from all instead of adding sms notification).

Yeah, I got the patch reversed by mistake… It should be exactly the
other way around. You can use the “-R” option to the patch utility in
order to inverse its patching logic.

–
Best Regards,
Aleksander Adamowski
http://olo.org.pl

SF.Net email is sponsored by:
Check out the new SourceForge.net Marketplace.
It’s the best place to buy or sell services
for just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace

eGroupWare-developers mailing list
eGroupWare-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/egroupware-developers

Aleksander_Adamowsk2 2007-12-14 11:10:47 UTC #5

Forgot something:
Thanks !

This backend will be very valuable…

No problem, I should thank you for writing such a versatile
notifications subsystem

Without that I wouldn’t be able to create a backend I need.

–
Best Regards,
Aleksander Adamowski
http://olo.org.pl

eGroupWare-developers mailing list
eGroupWare-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/egroupware-developers