Strange behaviour when re-editing recurrence events

somogyi 2022-07-27 08:42:13 UTC #1

Hi!

Egroupware version: 21.1.20220408 (docker)

We noticed a strange behaviour in Egroupware calendar.
When i create a recurrence event for example with 2 days repeat and then i want to change this event for example to 2 weeks recurrence, than the old event (with 2 days recurrence) and the new event is appear in calandar. If i refresh the page the old event id disappear.
Maybe the push service not pushing this “event” to the browser?

The problem is when a user experience this issue, he assume the old event is still exist and he try to delete or change this “non-existent” event and this generate a lot of notification email or just simply confusing.

Summary steps to reproduce:

Create an event with 2 days recurrence (save)
Re-edit this event and change recurrence to weekly (save)
Result: The old and the new one also appear in calendar
When refresh page the old event disappear

Thank you for your help!

BR,
Z

StefanU 2022-07-27 09:30:17 UTC #2

Hi Somogyi.

I have tried this out (The way I have understood it). I cannot reproduce this. For me, only the processed appointment is displayed correctly.

You should check Push.
Check the browser console…

Stefan

somogyi 2022-07-27 09:53:41 UTC #3

Hi Stefan!

Thank you for your reply.

The push service seems to be working, but i have an error in browser console (see attached screenshot).

Can you help with this?

BR,
Z

RalfBecker 2022-07-27 11:53:40 UTC #4

@ngegw: could this be caused by using jsonq() and receiving an other message here:

github.com

EGroupware/egroupware/blob/master/calendar/js/app.ts#L674




		// Ask for the real data, we don't have it
		let process_data = (data) =>
		{
			// Store it, which will call all registered listeners
			egw.dataStoreUID(data.uid, data.data);


			// Any existing events were updated.  Run this to catch new events or events moved into view
			this._update_events(this.state, [data.uid]);
		}
		egw.jsonq("calendar.calendar_ui.ajax_get", [[pushData.id]]).then((data) =>
		{
			if(typeof data.uid !== "undefined")
			{
				return process_data(data)
			}
			for(let e of data)
			{
				process_data(e);
			}
		});

Ralf

ngegw 2022-07-27 14:34:24 UTC #5

Problem is somewhere in there, but jsonq itself is probably not the problem.
For some reason we’re getting back undefined. It’s probably the server giving back something unexpected instead of the calendar data.

RalfBecker 2022-07-27 15:17:28 UTC #6

@somogyi That means you need to open the developer tools, reproduce the problem, and when it happens report here the data which was sent. Alternatively you can also use the network tab to inspect the data of that AJAX request.

Ralf

somogyi 2022-07-27 17:43:48 UTC #7

@RalfBecker, thank you.

So the response data after second change on the event is below.
I think (but im absolutely not sure) the problem is the event ETAG updated after change, but the push data contains the old ETAG ?!

Egw_ajax_response_220727.json.odt (18.1 KB)

BR,
Z

somogyi 2022-09-06 06:59:56 UTC #8

the problem is noticable in the latest version also (21.1.20220905)

Can you help me with this?

BR,
Z

RalfBecker 2022-09-06 07:44:35 UTC #9

@ngegw According to his data, there are only “apply” response types, no “data”. Therefore we get the error, as the callback will be called with null or undefined and gives that error.

Ralf

ngegw 2022-09-06 17:54:43 UTC #10

That’ll do it.

As a quick confirmation, this change should make the error stop:

diff --git a/calendar/js/app.ts b/calendar/js/app.ts
index 9e6253b38a…435f7674c9 100644
— a/calendar/js/app.ts
+++ b/calendar/js/app.ts
@@ -678,6 +678,10 @@ export class CalendarApp extends EgwApp
}
egw.jsonq(“calendar.calendar_ui.ajax_get”, [[pushData.id]]).then((data) =>
{

```
                  if(!data)
```
```
                  {
```
```
                          return;
```

                  }
                  if(typeof data.uid !== "undefined")
                  {
                          return process_data(data)

I’m not sure that’s the final fix, but if we can’t reproduce it this will help point the direction.

Nathan

somogyi 2022-09-06 19:30:04 UTC #11

Hi @ngegw,

Thank you for your reply.

I’ve tried to apply this section in app.ts but doesn’t seem to work.

ngegw 2022-09-06 21:25:18 UTC #12

You were unable to make the change, or the error persists after the change?

somogyi 2022-09-07 04:43:42 UTC #13

Ive made changes in the app.ts file, but the error persists after that.

RalfBecker 2022-09-07 05:45:09 UTC #14

You are using 21.1, not master?

In the first case, you also have to make the change in the generated app.js file!

Ralf

somogyi 2022-09-07 06:28:28 UTC #15

Yes im using 21.1 (21.1.20220905).

Ive also changed app.js too. Didnt work.

Is there any other step required after change or just clear cache in browser and test?

RalfBecker 2022-09-08 06:41:20 UTC #16

You need to switch minifying off under Admin > Site configuration.

Ralf

somogyi 2022-09-16 10:03:25 UTC #17

I tried this code in the app.js with turned off minify option:
egw.jsonq(“calendar.calendar_ui.ajax_get”, [[pushData.id]]).then((data) => {
if(!data)
{
return;
}
if(typeof data.uid !== “undefined”)
{
return process_data(data);
}
});

Sadly thats not worked:confused:
In console:

BUT the interesting effect, that if i shut down push docker container, then the code is working. So if the push is down and change the suggested code, than it works…

RalfBecker 2022-09-16 10:57:50 UTC #18

We’re currently testing the new maintenance release 21.1.20220916, so you could just update

Ralf