Trunk - addressbook - merge 2 accounts function

[Randy_J_Houlahan_B.S]

My user creates 2 addressbook entries and when I try to merge them I get error:

No edit permission for the target contact! and

0 contact(s) merged, 2 failed because of insufficient rights !!!

No ACL was changed during test.

Randy

[Leithoff_Klaus]

Strange, I tried to reproduce that on trunk - no luck.
-A User, creates an entry in his addressbook (say: XYZ), in personal Addressbook
-The user has read only access to other addressbooks
-there is a defaultdocument defined, the user has access rights to this document
-the user tries to merge the addressbook data of XYZ with that entry -> works for me
-the user tries to merge any addressbook data of adresses within the read-only address area -> works for me

-> conclusion: for me it works, even with jaytraxx recent changes (tested before and after)

In theory the access to an addressbook-entry is only read while merging. There are however some repair
actions on entrys when accessing (e.g.: removing non existing links).
But I doubt, that this causes the error.
Try to check if it was access to the file or to the contact is causing the error message:

Can the user access/browse to the document in question and is he able to open it in filemanager?

[Randy_J_Houlahan_B.S]

It appears that this statement is returning null. in the merge function in addressbook_bo

parent::search(array(‘id’=>$ids),false)

As a result the function fails I get this error in my log:

[Tue Jan 11 23:09:24 2011] [error] [client 216.121.186.147] PHP Warning: array_merge() [function.array-merge]: Argument #2 is not an array in /var/www/html/system/addressbook/inc/class.addressbook_bo.inc.php on line 1553,

I also ensured $ids has value, it does. It has the 2 id’s in it:

Array
(
[0] => 13116
[1] => 13115
)

parent::search(array(‘id’=>$ids),false) results in:

Invalid SQL: SELECT DISTINCT egw_addressbook.contact_id AS id FROM egw_addressbook LEFT JOIN egw_accounts ON egw_addressbook.account_id=egw_accounts.account_id LEFT JOIN egw_addressbook_extra ON egw_addressbook.contact_id=egw_addressbook_extra.contact_id WHERE contact_tid != ‘D’ AND (egw_addressbook.contact_owner=5 OR contact_private=0 AND egw_addressbook.contact_owner IN (-6,-1,4,2008,5,0) OR egw_addressbook.contact_owner IS NULL) AND (account_expires IS NULL OR account_expires = -1 OR account_expires > 1294805747) AND AND egw_addressbook.contact_id IN (13116,13115):
You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near ‘AND egw_addressbook.contact_id IN (13116,13115)’ at line 1

Click here to resume your eGroupWare Session.

[Leithoff_Klaus]

Looking at the SQL and the error, we see there is something missing.
there is a double AND and nothing in between
it seems that adding criteria and filters in addressbook_sql works well but the additional AND is introduced trying to build the query.
Please check the filters too.

The array_merge Problem is probably something regarding the retrieval of custom_fields.
Best regards
Leithoff, Klaus

[Randy_J_Houlahan_B.S]

The array merge results from the empty query.  the merge is used to combine the contact/accounts data before saving I believe.
I wonder how I have the error on my trunk download  and not yours.  I am 99.9% sure I have not made changes to any related classes.

I only change email and sitemgr for my own hacks.

Thanks,
Randy
 

[Leithoff_Klaus]

So filters and criteria look all fine?
Check filter and criteria as they are passed to etemplate/inc/class.so_sql_cf.inc.php (and etemplate/inc/class.so_sql.inc.php)
After that query should be constructed by etemplate/inc/class.so_sql(cf).inc.php.
So it would help to find out why an extra EMPTY criteria/filter part is introduced to the query.

As he complains about the second parameter

Argument #2 is not an array
it should be the merge of the contact data with the customfield data.

[Randy_J_Houlahan_B.S]

Criteria for so_sqlcf->search($criteria,) :

Array
(
[id] => Array
(
[0] => 13133
[1] => 13132
)

)

Criteria for so_sql->search($criteria,) :
Array
(
[0] => egw_addressbook.contact_id IN (13133,13132)
)

No filters or anything set on the addressbooh UI/nm.

[Leithoff_Klaus]

filters and criteria will be glued together in etemplate/inc/class.so_sql.inc.php
function &search
If there is nothing passed to the db->select statement then the error would not occur
so just above the db_select statement please print out the $query and the $join parameter.
If the double AND or the reason for it is found there we can check above where it comes from, if it
is introduced within the db->select we must search there.

In line 1019 is an echo statement echoing the just executed sql. (giving a fatal error you should not get to that place)
Try to direct that and the above to error log with error_log(…) (to avoid problems with bufferoutput and ajax/json)

best regards
klausi