Unable to delete LDAP user

Anthony_Messina 2010-04-17 22:49:47 UTC #1

Using svn trunk@29866, I am unable to delete an account where both my accounts
and contacts are stored in LDAP. I receive the following SQL error after
submitting “Delete ALL records” of this user on the account deletion page.

I use PostgreSQL:

Invalid SQL: DELETE FROM egw_addressbook WHERE :
ERROR: syntax error at end of input
LINE 1: DELETE FROM egw_addressbook WHERE
^

Any ideas? Thanks. -A

–
Anthony - http://messinet.com - http://messinet.com/~amessina/gallery
8F89 5E72 8DF0 BCF0 10BE 9967 92DC 35DC B001 4A4E

Anthony_Messina 2010-04-17 23:34:00 UTC #2

Using svn trunk@29866, I am unable to delete an account where both my
accounts and contacts are stored in LDAP. I receive the following SQL
error after submitting “Delete ALL records” of this user on the account
deletion page.

I use PostgreSQL:

Invalid SQL: DELETE FROM egw_addressbook WHERE :
ERROR: syntax error at end of input
LINE 1: DELETE FROM egw_addressbook WHERE
^

Any ideas? Thanks. -A

Further use of admin-cli.php at least gives a trace while trying to delete
account “test”…

./admin-cli.php --delete-user webmaster,XXXXXXX,test
Database error: Invalid SQL: DELETE FROM egw_addressbook WHERE :
ERROR: syntax error at end of input
LINE 1: DELETE FROM egw_addressbook WHERE
^ #0 /var/www/egroupware/phpgwapi/inc/class.egw_db.inc.php(674): egw_db-

halt(‘Invalid SQL: DE…’, 750, ‘/var/www/egroup…’) #1 /var/www/egroupware/phpgwapi/inc/class.egw_db.inc.php(1845): egw_db-
query(‘DELETE FROM egw…’, 750, ‘/var/www/egroup…’) #2 /var/www/egroupware/etemplate/inc/class.so_sql.inc.php(750): egw_db-
delete(‘egw_addressbook’, NULL, 750, ‘/var/www/egroup…’, ‘phpgwapi’) #3 /var/www/egroupware/etemplate/inc/class.so_sql_cf.inc.php(341): so_sql-
delete(Array) #4 /var/www/egroupware/addressbook/inc/class.addressbook_so.inc.php(741):
so_sql_cf->delete(Array) #5 /var/www/egroupware/addressbook/inc/class.addressbook_bo.inc.php(1330):
addressbook_so->deleteaccount(Array) #6 [internal function]: addressbook_bo->deleteaccount(Array) #7 /var/www/egroupware/phpgwapi/inc/common_functions.inc.php(867):
call_user_func(Array, Array) #8 /var/www/egroupware/phpgwapi/inc/class.hooks.inc.php(152):
ExecMethod(‘addressbook.add…’, Array) #9 /var/www/egroupware/admin/inc/class.admin_cmd_delete_account.inc.php(73):
hooks->single(Array, ‘addressbook’) #10 /var/www/egroupware/admin/inc/class.admin_cmd.inc.php(169):
admin_cmd_delete_account->exec() #11 /var/www/egroupware/admin/admin-cli.php(147): admin_cmd->run(NULL, true,
false) #12 /var/www/egroupware/admin/admin-cli.php(337):
run_command(Object(admin_cmd_delete_account)) #13 /var/www/egroupware/admin/admin-cli.php(61): do_delete_account(‘test’,
NULL) #14 {main} # Instance=messinet.com, User=webmaster, URL=http://
Database error: Invalid SQL: DELETE FROM egw_addressbook WHERE :
ERROR: syntax error at end of input
LINE 1: DELETE FROM egw_addressbook WHERE
^

–
Anthony - http://messinet.com - http://messinet.com/~amessina/gallery
8F89 5E72 8DF0 BCF0 10BE 9967 92DC 35DC B001 4A4E

Anthony_Messina 2010-04-18 00:11:02 UTC #3

./admin-cli.php --delete-user webmaster,XXXXXXX,test
Database error: Invalid SQL: DELETE FROM egw_addressbook WHERE :
ERROR: syntax error at end of input
LINE 1: DELETE FROM egw_addressbook WHERE
^

Commenting “parent::deleteaccount($data);” as follows around line 1330 in
/var/www/egroupware/addressbook/inc/class.addressbook_bo.inc.php

    function deleteaccount($data)
    {
            // delete/move personal addressbook

// parent::deleteaccount($data);
}

allows the account to be deleted. This particular account did not have any
contacts or personal addresses in LDAP or otherwise.

Even further, if I leave the parent::deleteaccount($data) enabled above, but I
comment out the following:

// $this->soextra->delete(array($this->extra_owner => $account_id));

at line 741 of
/var/www/egroupware/addressbook/inc/class.addressbook_so.inc.php

the account deletion can proceed.

This change seems to occur here:
http://svn.egroupware.org/viewvc/egroupware?view=rev&revision=29739

-A

Anthony - http://messinet.com - http://messinet.com/~amessina/gallery
8F89 5E72 8DF0 BCF0 10BE 9967 92DC 35DC B001 4A4E

Ralf_Becker_Stylite 2010-04-18 09:43:23 UTC #4

Hi Anthony,

Nathan is currently working on supporting an advanced query syntax all
over EGroupware. These changes are causing the problems you experience.

Thanks for letting us know, so we can fix it.

Please keep in mind: Trunk is not meant for productive use, it’s our
development “branch”.

Ralf

./admin-cli.php --delete-user webmaster,XXXXXXX,test
Database error: Invalid SQL: DELETE FROM egw_addressbook WHERE :
ERROR: syntax error at end of input
LINE 1: DELETE FROM egw_addressbook WHERE
^

Commenting “parent::deleteaccount($data);” as follows around line 1330 in
/var/www/egroupware/addressbook/inc/class.addressbook_bo.inc.php
    function deleteaccount($data)
    {
            // delete/move personal addressbook
// parent::deleteaccount($data);
}

allows the account to be deleted. This particular account did not have any
contacts or personal addresses in LDAP or otherwise.

Even further, if I leave the parent::deleteaccount($data) enabled above, but I
comment out the following:

// $this->soextra->delete(array($this->extra_owner => $account_id));

at line 741 of
/var/www/egroupware/addressbook/inc/class.addressbook_so.inc.php

the account deletion can proceed.

This change seems to occur here:
http://svn.egroupware.org/viewvc/egroupware?view=rev&revision=29739

-A

Download Intel® Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev

eGroupWare-developers mailing list
eGroupWare-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/egroupware-developers

–
Ralf Becker
Director Software Development

Stylite GmbH
[open style of IT]

Morschheimer Strasse 15
67292 Kirchheimbolanden

fon +49 (0) 6352 70629-0
fax +49 (0) 6352 70629-30
mailto: rb@stylite.de

www.stylite.de
www.egroupware.org

Geschäftsführer Andre Keller,
Gudrun Müller, Ralf Becker
Registergericht Kaiserslautern HRB 30575
Umsatzsteuer-Id / VAT-Id: DE214280951

Download Intel® Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev

eGroupWare-developers mailing list
eGroupWare-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/egroupware-developers

Anthony_Messina 2010-04-18 19:09:49 UTC #5

Nathan is currently working on supporting an advanced query syntax all
over EGroupware. These changes are causing the problems you experience.

Thanks for letting us know, so we can fix it.

Please keep in mind: Trunk is not meant for productive use, it’s our
development “branch”.

Ralf

thanks, ralf. i do realize trunk isn’t meant for production, but it’s a good
way for me to test. i pull eGW down into a git repo and make little local
modifications which i can pull to my actual production service. if i find
something that doesn’t work, i just do a git-revert and try to work it out.

http://messinet.com/trac/egw/

thanks again and enjoy the day

–
Anthony - http://messinet.com - http://messinet.com/~amessina/gallery
8F89 5E72 8DF0 BCF0 10BE 9967 92DC 35DC B001 4A4E

ngegw 2010-04-20 17:48:57 UTC #6

Could you please try SVN r29910.
Hopefully that takes care of both issues.

Nathan

eGroupWare-developers mailing list
eGroupWare-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/egroupware-developers

Anthony_Messina 2010-04-21 00:23:59 UTC #7

Could you please try SVN r29910.
Hopefully that takes care of both issues.

excellent, sir. i confirm that this fixes the issue regarding adding personal
contacts as well as deleting accounts. thank you. -a

–
Anthony - http://messinet.com - http://messinet.com/~amessina/gallery
8F89 5E72 8DF0 BCF0 10BE 9967 92DC 35DC B001 4A4E