DB Tools broken?

AlexS 2020-07-29 05:55:19 UTC #1

Hello together,
I tried to add a new table via DB Tools, but after I select an application the page goes to the old etemplate editor:

Can someone confirm this?
Thank you and
BR
Alex

RalfBecker 2020-07-29 07:05:45 UTC #2

Just tried it, and I can select an application.

Anything in JavaScript console or webserver logs?

Ralf

AlexS 2020-07-29 11:02:14 UTC #3

Hello @RalfBecker,

when selecting the application from the selectbox I get this in the error log:

2020/07/29 10:53:52 [error] 8#8: *4043 FastCGI sent in stderr: “
PHP message: Error reading etemplate request data for id=etemplate_asig_6FEBX/MnSex7d/nWWdcIEgL9jRyVHNuIz3HCekvDHBI=!
PHP message: EGroupware\Api\Etemplate\Request::read(‘etemplate_asig_6FEBX/MnSex7d/nWWdcIEgL9jRyVHNuIz3HCekvDHBI=’, …) eT2 request not found / expired --> redirecting app etemplate to /index.php?menuaction=etemplate.editor.edit&redirect=1596020032.1159 (_GET[menuaction]=etemplate.db_tools.edit, isJSONRequest()=FALSE)” while reading response header from upstream, client: 172.19.0.1, server: _, request: “POST /egroupware/etemplate/process_exec.php?menuaction=etemplate.db_tools.edit HTTP/1.1”, upstream: “fastcgi://172.19.0.3:9000”, host: “localhost”, referrer: "http://localhost/egroupware/index.php?menuaction=etemplate.db_tools.edit"
2020/07/29 10:53:52 [error] 8#8: *4043 FastCGI sent in stderr: “
PHP message: PHP Warning: Use of undefined constant name - assumed ‘name’ (this will throw an Error in a future version of PHP) in /var/www/egroupware/etemplate/inc/class.boetemplate.inc.php(211) : eval()'d code on line 1
PHP message: #1 /var/www/egroupware/etemplate/inc/class.boetemplate.inc.php(211): eval()
PHP message: #2 /var/www/egroupware/etemplate/inc/class.etemplate.inc.php(1449): boetemplate::expand_name(‘window.open(egw…’, 0, 3, 0, 0, Array)
PHP message: #3 /var/www/egroupware/etemplate/inc/class.etemplate.inc.php(1749): etemplate->show_cell(Array, Array, Array, ‘exec’, 0, 3, ‘’, NULL, ‘/0/4A/1’)
PHP message: #4 /var/www/egroupware/etemplate/inc/class.etemplate.inc.php(873): etemplate->show_cell(Array, Array, Array, ‘exec’, 0, 3, ‘all’, NULL, ‘/0/4A’)
PHP message: #5 /var/www/egroupware/etemplate/inc/class.etemplate.inc.php(1504): etemplate->show_grid(Array, Array, Array, ‘exec’, 0, 0, ‘/0’)
PHP message: #6 /var/www/egroupware/etemplate/inc/class.etemplate.inc.php(699): etemplate->show_cell(Array, Array, Array, ‘exec’, 0, 0, ‘’, NULL, ‘/0’)
PHP message: #7 /var/www/egroupware/etemplate/inc/class.etemplate.inc.php(258): etemplate->show(Array, Array, Array, ‘exec’)
PHP message: #8 /var/www/egroupware/etemplate/inc/class.editor.inc.php(547): etemplate->exec(‘etemplate.edito…’, Array, Array, Array, Array, 0, ‘/^cont/’)
PHP message: #9 /var/www/egroupware/index.php(155): editor->edit()
PHP message: #10 {main}
PHP message: # Instance=default, User=asig, Request=GET http://localhost/egroupware/index.php?menuaction=etemplate.editor.edit&redirect=1596020032.1159, User-agent=Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:78.0) Gecko/20100101 Firefox/78.0” while reading response header from upstream, client: 172.19.0.1, server: _, request: “GET /egroupware/index.php?menuaction=etemplate.editor.edit&redirect=1596020032.1159 HTTP/1.1”, upstream: “fastcgi://172.19.0.3:9000”, host: “localhost”, referrer: "http://localhost/egroupware/index.php?menuaction=etemplate.d

In the console log I don’t see something strange…
Thanks again and
BR
Alex

RalfBecker 2020-07-29 11:05:08 UTC #4

Hi Alex,

That explains the behavior.

Question is now, did you leave that open for a long time, and the eTemplate requests simply timed out, or do you have a problem storing eTemplate requests?

Ralf

AlexS 2020-07-29 11:11:47 UTC #5

Hi Ralf,
I just logged out and in again, same issue. How can I check the Problem with the storing of the eTemplate requests. Could it be a file permission issue?
Thank you
Alex

RalfBecker 2020-07-29 11:46:33 UTC #6

The GET request to db_tools calling etemplate::exec() which creates a new request - to store it’s state - and sends it’s id back to the client:

github.com

EGroupware/etemplate/blob/master/inc/class.etemplate.inc.php#L287


		{
			$hooked = isset(self::$previous_content) || !isset($GLOBALS['egw']->template) ?
				self::$previous_content : $GLOBALS['egw']->template->get_var('phpgw_body');
		}
		self::$request->hooked = $hooked ? $hooked : self::$hook_content;
		self::$request->hook_app = $hooked ? $GLOBALS['egw_info']['flags']['currentapp'] : self::$hook_app;
		self::$request->app_header = $GLOBALS['egw_info']['flags']['app_header'];
		if (self::$request->output_mode == -1) self::$request->output_mode = 0;
		self::$request->template = $this->as_array(2);


		$html = html::form(html::input('etemplate_exec_id',self::$request->id(),'hidden',' id="etemplate_exec_id"').$html.
			html::input_hidden(array(
				'submit_button' => '',
				'innerWidth'    => '',
			),'',false),array(),$this->sitemgr ? '' : '/etemplate/process_exec.php?menuaction='.$method.
				// if url contains cd=yes/no, keep it, as otherwise framework might reload popups opened as main page
				(!empty($_GET['cd'])&&in_array($_GET['cd'],array('yes','no'))?'&cd='.$_GET['cd'] : ''),
			'',self::$name_form,self::$form_options.
			// dont set the width of popups!
			($output_mode != 0 ? '' : ' onsubmit="this.innerWidth.value=window.innerWidth ? window.innerWidth : document.body.clientWidth;"'));
			//echo "to_process="; _debug_array(self::$request->to_process);

When the template is submitted later, eTemplate reads the id, and if it does not find a request with that id, it redirects to the apps index page, as a last resort fallback:

github.com

EGroupware/etemplate/blob/master/inc/class.etemplate.inc.php#L423


	*
	* @return mixed false if no sessiondata and $this->sitemgr, else the returnvalue of exec of the method-calls
	*/
	function process_exec($etemplate_exec_id = null, $submit_button = null, $exec = null, $type = 'regular' )
	{
		if(!$etemplate_exec_id) $etemplate_exec_id = $_POST['etemplate_exec_id'];
		if(!$submit_button) $submit_button = $_POST['submit_button'];
		if(!$exec) $exec = $_POST;


		//echo "process_exec: _POST ="; _debug_array($_POST);
		if (!$etemplate_exec_id || !(self::$request = Api\Etemplate\Request::read($etemplate_exec_id)))
		{
			if ($this->sitemgr) return false;
			//echo "uitemplate::process_exec() id='$_POST[etemplate_exec_id]' invalid session-data !!!"; _debug_array($_SESSION);
			// this prevents an empty screen, if the sessiondata gets lost somehow
			$redirect = array(
				'menuaction' => $_GET['menuaction'],
			);
			if (!$_POST && $_SERVER['REQUEST_METHOD'] == 'POST')
			{
				$redirect['post_empty'] = 1;

Ralf