Framework::refresh_opener, is it possible to refresh the parent pop up window instead of the main app window?

AlexS 2020-01-26 17:12:53 UTC #1

Dear Developers,
I am developing an accounting application in EGroupware. For this I have a Nextmatch index

and from there I open an edit Pop up (booking edit) which it self directly (not via iframe) includes a Nextmatch widget with the booking lines:

From this nextmatch you can open each line of the booking via a new edit (booking line edit):

On the save button of this booking-line edit form I have the following:

if ($save_result === 0) {
//Close window
//$msg, $app, $id=null, $type=null, $targetapp=null, $replace=null, $with=null, $msg_type=null
Framework::refresh_opener($msg, $this->app, $content[$this->name_id], ‘update’, null, null, null, $msg_type);
Framework::window_close();
}

On save the window closes as expected, but the

refresh_opener

refreshes the main application window and not the booking edit Pop up window as I would like it to.

I there an EGroupware way to refresh the edit Pop up window instead?

Thank you for your support!

BR Alex

Placing a nextmatch in an edit form prevents regular form submit and field validation?

RalfBecker 2020-01-29 12:44:50 UTC #2

Framework::refresh_opener always refreshes the main window because the refresh is carried out by the framework object:

github.com

EGroupware/egroupware/blob/master/api/js/jsapi/egw.js#L183


			if (window.framework && sidebox)
			{
				window.framework.setSidebox.apply(window.framework, JSON.parse(sidebox));
			}
			egw_redirect = JSON.parse(egw_redirect);
			egw.link_handler.apply(egw, egw_redirect);
			return;	// do NOT execute any further code, as IE(11) will give errors because framework already redirects
		}


		// call egw_refresh on opener, if attr specified
		var refresh_opener = egw_script.getAttribute('data-refresh-opener');
		if (refresh_opener && window.opener)
		{
			refresh_opener = JSON.parse(refresh_opener) || {};
			window.opener.egw(window.opener).refresh.apply(egw(window.opener), refresh_opener);
		}


		// close window / call window.close(), if data-window-close is specified
		var window_close = egw_script.getAttribute('data-window-close');
		if (window_close)
		{

github.com

EGroupware/egroupware/blob/master/api/js/jsapi/egw_message.js#L351


			{
				var app_obj = _wnd.egw.window.app[app];
				if (typeof app_obj.observer == 'function' &&
					app_obj.observer(_msg, _app, _id, _type, _msg_type, _links) === false && app === _app)
				{
					no_regular_refresh = true;
				}
			}
			if (no_regular_refresh) return;


			// if we have a framework template, let it deal with refresh, unless it returns a DOMwindow for us to refresh
			if (win.framework && win.framework.refresh &&
				!(win = win.framework.refresh(_msg, _app, _id, _type, _targetapp, _replace, _with, _msg_type)))
			{
				return;
			}


			// if window registered an app_refresh method or overwritten app_refresh, just call it
			if(typeof win.app_refresh == "function" && typeof win.app_refresh.registered == "undefined" ||
				typeof win.app_refresh != "undefined" && win.app_refresh.registered(_app))
			{

Only way to avoid that would be implementing an observer in your app.js:

github.com

EGroupware/egroupware/blob/master/api/js/jsapi/egw_message.js#L337




			var win = typeof _targetapp != 'undefined' ? _wnd.egw_appWindow(_targetapp) : _wnd;


			this.message(_msg, _msg_type);


			if(typeof _links == "undefined")
			{
				_links = [];
			}


			// notify app observers: if observer for _app itself returns false, no regular refresh will take place
			// app's own observer can replace current app_refresh functionality
			var no_regular_refresh = false;
			for(var app in _wnd.egw.window.app)	// run observers in main window (eg. not iframe, which might be opener!)
			{
				var app_obj = _wnd.egw.window.app[app];
				if (typeof app_obj.observer == 'function' &&
					app_obj.observer(_msg, _app, _id, _type, _msg_type, _links) === false && app === _app)
				{
					no_regular_refresh = true;
				}

If your observer returns true, the the frameworks refresh method is not called. Obviously your observer should carry out the wanted refresh, as it is not happening otherwise.

Be aware that observer methods get called for refresh requests of other apps too!

Ralf

Determine open windows of an application

AlexS 2020-01-29 15:00:05 UTC #3

Hello Ralf,
thanks a lot for your reply, I will check it out.
BR Alex