Global price list edit by group

MZiemian 2023-10-02 15:17:29 UTC #1

Hello.

Does anyone be able to set some group ACL to allow edit global price list entries?
I can’t find this setting anywhere Admin group can edit without any problem, but other not. I have set ACL to allow edit entries within “Projects” app, but no effects… What should be “Data access from” and “Data access by” fields, if for example user is in group “Traders” ?

Appreciate if someone can share their findings.

EGW is latest docker, running Debian 11.

RalfBecker 2023-10-02 17:47:23 UTC #2

There is no ACL for updating the global price list, you have to be admin to do so:

github.com

EGroupware/projectmanager/blob/master/inc/class.projectmanager_pricelist_bo.inc.php#L261


	function delete($keys=null,$only_return_query=false)
	{
		if (!$this->check_acl(Acl::EDIT,(int)(is_array($keys) ? $keys['pm_id'] : $keys)))
		{
			return false;
		}
		return parent::delete($keys);
	}


	/**
	 * checks if the user has sufficent rights for a certain action
	 *
	 * For project-spez. prices/data you need a EGW_ACL_BUDGET right of the project for read or
	 * EGW_ACL_EDIT_BUDGET for write or delete.
	 * For general pricelist data you need atm. no extra read rights, but is_admin to write/delete.
	 *
	 * @param int $required EGW_ACL_{READ|WRITE|DELETE}
	 * @param int $pm_id=0 project-id for project-spez. prices/data to check, default 0 = general pricelist
	 * @param array/int $data=null data/id of pricelist-entry, default null = use $this->data ($pm_id is ignored)
	 * @return boolean true if the user has the rights, false otherwise
	 */

Ralf

MZiemian 2023-10-03 08:23:27 UTC #3

Thanks, Ralf.

Are there any plans to add such functionality? If not, maybe it will be good idea? I don’t thing this will be hard to achieve, as the engine itself should easily handle it, like for other parts…

Best,

Martin.

RalfBecker 2023-10-03 17:15:43 UTC #4

No plans, thought easy to add. Buy 2 hour support budget and we will add a config for other groups or users allowed to edit the global pricelist.

Or send a pull request …

Ralf